From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B1982BF3F3 for ; Sat, 5 Sep 2026 00:36:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788568575; cv=none; b=ODZA4b0bv/6ZPkWq/mnpZUlOHkS5pKFLUnrp6mrVQMutOPf9g26se4UHcR+0hK0sHEZZ7s41ufVrVW1Iv/TSD9shN+oJ3kK+Lycd3K86k5iDYo4dAu+ewJ+fApRerhSZ9iJAY1mfhB8RzMVKPWOVboL+UPobLXaccc3ykr9vvec= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788568575; c=relaxed/simple; bh=8HzIcvm2I4PGEsFdux3m3Apu6yc5GgCA35XtCp1TzvE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=MOYvLSDgiW92lFm6hg11f+eExV6+YIDnbHkA+/9eF+dExNmLprHb2VjLf2fGcb5xFZ4JIYuAEqVkj/fvXdUX0GntEQBhnc7PsUZxD9h1NJJldWi6JxneNZ2nOznz+vhz4W5mZe6hVObx8bJFItHS6oS/GzlgfX+6JFhjSC9N4P0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QYV0a0Gy; arc=none smtp.client-ip=209.85.215.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QYV0a0Gy" Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-cbe6295f05bso1967483a12.1 for ; Fri, 04 Sep 2026 17:36:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788568573; x=1789173373; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=l2i3q/8SP6YXjJaU7ec/Y5TJPcKgIJqQrS0aacfBKX4=; b=QYV0a0GyWciguOP+EZ3ZYvLeJQzt4kQ8ETzl3bU1C4JGe6/dtnhNNx5el60HikHdpd sZhBxc2JHcLHWaVoyY5ltmgTSI1GR9adC+Lm0cmsCHcIxYBhgyD4eouCEk1aJgq1z1ZS 7FdT03EcPfJHVB6ssUqoxZ8M7Ej1hMppEW2q62t1yOwXthCj3u2yLxAS6ExzeNxQSbEI TeE/dbmGOuYMlqbu8Rf6DNLgXMHmXJ0qWFgoxrilCC5ODAjO2tMZ7O3SJspM6UC1KZlc rgedTtgB8oWGy+vtozR3eHCHUJgzfnpK/uE3h5QnZMJB94UNlUR1r+cuY4eIYoypHov1 EbdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788568573; x=1789173373; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=l2i3q/8SP6YXjJaU7ec/Y5TJPcKgIJqQrS0aacfBKX4=; b=SYwFVOAe8NeJIJkIVK4bQeRRjCAR7r9AUE1n8iHwTmLh025YhjivKz8vUGAvrdLepc FdeEdd7l9Z4bi4l0ZstRt5nKzoE7G4I5gSUIbS42MhQMefzDhIHZxnDj70Iy5mhkIYcT tveVStaRKpU8T1rLv4kEoGGSqSVSh5qe7ldU+PoWlkhUfCk6BQz1aubXSaQbwqPFsm7D PoTKZEGqGYdeI+zj4+RFIGeMaWTvXYS9Osr0m1Y7rbmOnxOQyXWh0gKaAvm3BCzYwogG /xW3JAMgPh2e8XmmNDjyt7pyYBMQDnZ0RxD3Wpw0Kfq2/98AoRm6k2D8E/Yfyl7z1qm5 DVjQ== X-Forwarded-Encrypted: i=1; AKwUvByFQUl/Io9RaAR5SMdsZIRKHCevmvAYF44Q+QzYPU4ynW4H47Bvl9nlu5eM9Kmhs1ERA3HFEgw=@vger.kernel.org X-Gm-Message-State: AFuF++kVILGgshEHUs7E4EhLV6gUrYLi2JtaDmQLZ/YvqZWt1W5Zmy5R 31w3bZa7Soo8HQKubY86UItT3vAEu9MR3QJWCy9/1sDFM1+0P3DVBQXwteKVawfA X-Gm-Gg: AYBFou2hnVSGcV/XtlKQVv1TLrkpqQFgJlfC1lolsQM+M6Zkh0LEDrNjWqRVDDpjkkP Z+fKCnIEltfBWeZFK75G/gCRS5F0I0TNeBubISbEKU6VtnlbHOr6Pe+yyeqh3MuuHWRUdOhMeIS xLDU/npABzcvh9kZV1p5AMLUFyYpbWG35vMpojGuYhiG2ydo3tfyTXfHnYy9H1U7BC3JXTReyhA xTHsrMijLi8XD5EZaeZKYxB2BJpfJTlwZya+LFCH38EZSOFPmoBYGJPQiEYyzB7Jef+7do6gguf qxcG5/kM1EdQvhvVcgAGGWM1YOEBRxAhcYYPSdPyDIaGASQyq/rjorJ121sEjv4km1Gppo8PLCT Qy9gv90+WrzLlVEi8/aF1hDJzUjvPv6WyfqYetG+fdf/fHD4Nw+bj5a4hx39zNDfVS1qgjD5QZX HAO69aJQObzO+hwdOJN8qd/6fIziipANUNHWee3S52MNqH6wY1kQuKuBulRF8C X-Received: by 2002:a17:90b:584f:b0:38f:657:6823 with SMTP id 98e67ed59e1d1-39b27c8b9e4mr7191704a91.8.1788568572711; Fri, 04 Sep 2026 17:36:12 -0700 (PDT) Received: from tradnomic.. ([2601:646:8300:7570:4132:9566:38a4:e435]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39b25f88475sm6760895a91.1.2026.09.04.17.36.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Sep 2026 17:36:12 -0700 (PDT) From: Rafael Alejandro Diaz Cruz To: gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org, Rafael Alejandro Diaz Cruz , syzbot+4a5c87a01894ca37f25c@syzkaller.appspotmail.com, Alan Stern Subject: [PATCH usb-next v2] USB: gadget: Fix UAF on refcount inside gadgetfs_bind() Date: Fri, 4 Sep 2026 17:36:07 -0700 Message-ID: <20260905003607.1686172-1-rafad900@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When usb_ep_alloc_request() fails, gadgetfs_bind() takes the following error path: if (!dev->req) goto enomem; // ... enomem: gadgetfs_unbind (gadget); return -ENOMEM; In normal case, get_dev() will be called to increment refcounter from gadget->dev->count but in error case, this increment is skipped and gadgetfs_unbind() will decrement it via put_dev(). Going down the error path leads to a refcount imbalance which will cause UAF in close()/umount() operations due to refcount dropping below 0. Fix this by moving get_dev() above the error paths so that refcounter is incremented before the put_dev() call. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Reported-by: syzbot+4a5c87a01894ca37f25c@syzkaller.appspotmail.com Link: https://syzkaller.appspot.com/bug?extid=4a5c87a01894ca37f25c Signed-off-by: Rafael Alejandro Diaz Cruz Reviewed-by: Alan Stern --- Changes from v1: Removed syzkaller reference in description Added Reviewed-by: tag. drivers/usb/gadget/legacy/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/legacy/inode.c b/drivers/usb/gadget/legacy/inode.c index 3e2bce7543d4..181b19e7fc2f 100644 --- a/drivers/usb/gadget/legacy/inode.c +++ b/drivers/usb/gadget/legacy/inode.c @@ -1679,6 +1679,7 @@ static int gadgetfs_bind(struct usb_gadget *gadget, } set_gadget_data (gadget, dev); + get_dev(dev); dev->gadget = gadget; gadget->ep0->driver_data = dev; @@ -1696,7 +1697,6 @@ static int gadgetfs_bind(struct usb_gadget *gadget, spin_lock_irq(&dev->lock); dev->state = STATE_DEV_UNCONNECTED; spin_unlock_irq(&dev->lock); - get_dev (dev); return 0; enomem: -- 2.43.0