From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE8E1525A8D for ; Mon, 7 Sep 2026 20:00:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788811236; cv=none; b=neTkEQ7VlpOI3UrjkXRws6ak8NABOw3XP2JRS7VQnJfFhMoXYgnoW6P1LUmVMD/FxkhxcHVlCNu3yETSUVVm9lqfZk0D2608QGzakg5QglgnfPKPUtpFGK908EwkSZgA/pS70k47IDyj8ZimG1GDMwltJxg7RRTZU3QnsAQF/Bg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788811236; c=relaxed/simple; bh=n94sQMp119ARgVDJp3TC6/lDn8rFSI3J+RmPKvAk1nk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fJ9rVjgFTRW7dKBPMq41JHD9YjW+Gwy3Ca+nT20nHmmP00XimJ3PY6/IWGdB+KMlWuyUDAttX8cNTU63x40ghNujR3jwAqvdvNrCLXjcnqz4m7pXokZoq8h4IUkYjmpcJTs1dBajPJjCubhNQUSA3cI01hGkBm64bmgMxklwNDg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NL1RaMB5; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NL1RaMB5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 560BA1F00A3A; Mon, 7 Sep 2026 20:00:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788811234; bh=aA2IjrjRtZEUI2U9VjyIVvFFzwenpj4afbkPbx6GYVU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=NL1RaMB5eOs8PEGOYlOMXzRxsbJo4jLbv0yiIUJPmFWqt2qx+O+FVI4DqT7vi5L4q x04Y4ROrtttuqvuq+RonC/yduuEx2Ignl0L3pwATlH3qSnJGVXIR1f+lnZ+s8rdRHY SfJQbC9M0wmENfz5q6IC0C7n4Sfo52Wu7Wy43h/n0xxgiw1E7499s3lNES/gQ/8hnX uGlgj1gREp0jmjKquJWgVxNYuEIFVbYQ7LCs5MEExaiUiWeEwigF9lIThBqInhZNsH fN9ITz7377kCtqQKA4+cW3wf22ebnqe8wtjMSh87CvWiX2RrvCdIPMrM1L2YFqcN/t qj6S32uClhW/A== From: Sasha Levin To: stable@vger.kernel.org Cc: Doruk Tan Ozturk , Jiri Kosina , Sasha Levin Subject: [PATCH 5.15.y] HID: sony: fix UAF of ghl_poke_timer / ghl_urb at driver unbind Date: Mon, 7 Sep 2026 16:00:32 -0400 Message-ID: <20260907200032.327280-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026090334-elevation-quill-589f@gregkh> References: <2026090334-elevation-quill-589f@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Doruk Tan Ozturk [ Upstream commit a26705bd2e2728833e7a538ce91e58a5eeff496a ] For GHL (Guitar Hero Live) dongles, sony_probe() arms a periodic timer: ghl_magic_poke() (the timer callback) submits sc->ghl_urb, and the URB completion ghl_magic_poke_cb() re-arms the timer with mod_timer(). sony_remove() drained the timer with timer_delete_sync() and then freed the URB with usb_free_urb(): timer_delete_sync(&sc->ghl_poke_timer); usb_free_urb(sc->ghl_urb); timer_delete_sync() does not block re-arming, and while the URB is in flight the timer is not pending, so the sync delete is a no-op. A URB completion that runs after the delete re-arms the timer, and usb_free_urb() only drops a reference -- it does not kill an in-flight URB. sc is allocated with devm_kzalloc() and freed once sony_remove() returns, so the re-armed ghl_poke_timer (embedded in sc) then fires on freed memory, a use-after-free from timer softirq. This is a disconnect/rmmod race. Poison the URB first, then shut the timer down, before freeing the URB. usb_poison_urb() kills any in-flight URB and permanently rejects further submissions, so a poke timer that is still pending cannot re-submit the URB from ghl_magic_poke() in the window before timer_shutdown_sync() runs. usb_kill_urb() would not suffice: it only cancels the in-flight URB and leaves it submittable once it returns, so the pending timer could re-submit it and put a fresh URB in flight over the freed sc. timer_shutdown_sync() then drains any last callback and blocks re-arming. The probe error path is unaffected: it is only reached before the timer is armed. Reproduced under KASAN on next-20260710 via dummy_hcd + raw-gadget emulation of the GHL PS4 dongle (VID 0x1430 / PID 0x07bb): hid-sony binds and arms the poke timer, the poke URB is held in flight, the driver is unbound (freeing sc), then the URB is released. The completion re-arms the timer on the freed sc, and the re-armed timer fires ~8 s later: BUG: KASAN: slab-use-after-free in ghl_magic_poke+0x98/0xb0 Read of size 8 at addr ffff88810b02fd50 by task swapper/0/0 ghl_magic_poke+0x98/0xb0 call_timer_fn+0x35/0x2b0 __run_timers+0x69c/0x9a0 run_timer_softirq+0x173/0x2a0 Allocated by task 169: sony_probe Freed by task 338: devres_release_group <- hid_device_remove (sony_remove) Found by 0sec (https://0sec.ai) using automated source analysis. Fixes: cc894ac55360 ("HID: sony: support for ghlive ps3/wii u dongles") Cc: stable@vger.kernel.org Assisted-by: 0sec:multi-model Signed-off-by: Doruk Tan Ozturk Signed-off-by: Jiri Kosina [ changed the old del_timer_sync() call to timer_shutdown_sync() ] Signed-off-by: Sasha Levin --- drivers/hid/hid-sony.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c index c330d5a20ca04..b4858304c18da 100644 --- a/drivers/hid/hid-sony.c +++ b/drivers/hid/hid-sony.c @@ -3085,7 +3085,9 @@ static void sony_remove(struct hid_device *hdev) struct sony_sc *sc = hid_get_drvdata(hdev); if (sc->quirks & (GHL_GUITAR_PS3WIIU | GHL_GUITAR_PS4)) { - del_timer_sync(&sc->ghl_poke_timer); + /* poison, not kill: a pending timer must not re-submit during teardown */ + usb_poison_urb(sc->ghl_urb); + timer_shutdown_sync(&sc->ghl_poke_timer); usb_free_urb(sc->ghl_urb); } -- 2.53.0