From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF4B232D0E3 for ; Tue, 8 Sep 2026 16:15:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788884152; cv=none; b=N5JTI71EXA5kSy7SyPxppmjVAVnt2GA3XimX7P5dROU7plzbYwsjzfOgPjG2F74Eq1bxqFvV7nnRCnkoNBLsZYH0wLLouOH8jpQLaQC5IR0XrUaVQa4cISw0pf6tgRR/T3D7LvMdvcw2J9KXIyzTFu0HDwW/UeUJ7MjE0k6RavE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788884152; c=relaxed/simple; bh=2mMWeifNG86gA8IE73hVZJ4hNNz6IZrpC8kK5H74Ql0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=n7YxqhxZcYwptSm2oKNUCCAUhes1QrUrL6ClsLF4xBT7KtL7kL8ugnqQzb0yTkkVOoCZMsos2VBHmM6ZUM6WS6Er+Js+N5xsjiaF9r+ooClkIxMFZV5680eX7z8zOlwXqvL/2FJY2wljkkXZX+rIsALH8DQkamEb8CLL9zDOM8s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Qgrlfi1+; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Qgrlfi1+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CB2321F00A3D; Tue, 8 Sep 2026 16:15:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788884150; bh=H9ls6+y6p7kfA6J/6ExndQ9OqCGgUEOz1gq0RUZ8ZIw=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Qgrlfi1+kItU6LTRThHfnhInty3ZQhAKVBurqjpWmqDzaiS74cs4pjaWEnfkx5htx d7VXR/X9gKSpasRWi5e/Dw/DHxDZ6XEXgSRvqOk1QWntJsQr5QDy8xMFsPRXgcIjxw fIJpSCtVqwtByTVD1BNcmC0ErS45oS9ZgYumCFyBRCG2BbLGxaaNa8vV5qapBf0qAP frlzgLo6cJ1h/BMjTostLb0A9AaDNF7fR6E9P4cL06+MAh9SABChW3n6kI0iKcsRiQ BAJfxnZe5Zl9+1QGHJmT0ubVu4tknPkrh99U0Bvd2ew1gUt/9nIWSLQSOLYrImmyil tLP3OgOJmJQWw== From: Sasha Levin To: stable@vger.kernel.org Cc: Ye Bin , Jan Kara , Zhang Yi , Theodore Ts'o , Sasha Levin Subject: [PATCH 5.15.y 1/3] jbd2: use shrink_type type instead of bool type for __jbd2_journal_clean_checkpoint_list() Date: Tue, 8 Sep 2026 12:15:46 -0400 Message-ID: <20260908161548.2612016-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026090325-massive-fabulous-a27d@gregkh> References: <2026090325-massive-fabulous-a27d@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Ye Bin [ Upstream commit 078760d950016f5982751f5512e69f26ad8feb31 ] "enum shrink_type" can clearly express the meaning of the parameter of __jbd2_journal_clean_checkpoint_list(), and there is no need to use the bool type. Signed-off-by: Ye Bin Reviewed-by: Jan Kara Reviewed-by: Zhang Yi Link: https://lore.kernel.org/r/20240407065355.1528580-2-yebin10@huawei.com Signed-off-by: Theodore Ts'o Stable-dep-of: 15cb16496446 ("jbd2: bound shrinker scans by examined checkpoint buffers") Signed-off-by: Sasha Levin --- fs/jbd2/checkpoint.c | 16 +++++++++------- fs/jbd2/commit.c | 2 +- include/linux/jbd2.h | 4 +++- 3 files changed, 13 insertions(+), 9 deletions(-) diff --git a/fs/jbd2/checkpoint.c b/fs/jbd2/checkpoint.c index 10ce0b6b4ffa2..9fcc68884e262 100644 --- a/fs/jbd2/checkpoint.c +++ b/fs/jbd2/checkpoint.c @@ -367,8 +367,6 @@ int jbd2_cleanup_journal_tail(journal_t *journal) /* Checkpoint list management */ -enum shrink_type {SHRINK_DESTROY, SHRINK_BUSY_STOP, SHRINK_BUSY_SKIP}; - /* * journal_shrink_one_cp_list * @@ -505,21 +503,25 @@ unsigned long jbd2_journal_shrink_checkpoint_list(journal_t *journal, * journal_clean_checkpoint_list * * Find all the written-back checkpoint buffers in the journal and release them. - * If 'destroy' is set, release all buffers unconditionally. + * If 'type' is SHRINK_DESTROY, release all buffers unconditionally. If 'type' + * is SHRINK_BUSY_STOP, will stop release buffers if encounters a busy buffer. + * To avoid wasting CPU cycles scanning the buffer list in some cases, don't + * pass SHRINK_BUSY_SKIP 'type' for this function. * * Called with j_list_lock held. */ -void __jbd2_journal_clean_checkpoint_list(journal_t *journal, bool destroy) +void __jbd2_journal_clean_checkpoint_list(journal_t *journal, + enum shrink_type type) { transaction_t *transaction, *last_transaction, *next_transaction; - enum shrink_type type; bool released; + WARN_ON_ONCE(type == SHRINK_BUSY_SKIP); + transaction = journal->j_checkpoint_transactions; if (!transaction) return; - type = destroy ? SHRINK_DESTROY : SHRINK_BUSY_STOP; last_transaction = transaction->t_cpprev; next_transaction = transaction; do { @@ -560,7 +562,7 @@ void jbd2_journal_destroy_checkpoint(journal_t *journal) spin_unlock(&journal->j_list_lock); break; } - __jbd2_journal_clean_checkpoint_list(journal, true); + __jbd2_journal_clean_checkpoint_list(journal, SHRINK_DESTROY); spin_unlock(&journal->j_list_lock); cond_resched(); } diff --git a/fs/jbd2/commit.c b/fs/jbd2/commit.c index 9b2225ab5fe5a..182d2c39ff0a4 100644 --- a/fs/jbd2/commit.c +++ b/fs/jbd2/commit.c @@ -536,7 +536,7 @@ void jbd2_journal_commit_transaction(journal_t *journal) * frees some memory */ spin_lock(&journal->j_list_lock); - __jbd2_journal_clean_checkpoint_list(journal, false); + __jbd2_journal_clean_checkpoint_list(journal, SHRINK_BUSY_STOP); spin_unlock(&journal->j_list_lock); jbd2_debug(3, "JBD2: commit phase 1\n"); diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h index 5377df8c85453..5583d735d4bf3 100644 --- a/include/linux/jbd2.h +++ b/include/linux/jbd2.h @@ -1435,7 +1435,9 @@ void jbd2_update_log_tail(journal_t *journal, tid_t tid, unsigned long block); extern void jbd2_journal_commit_transaction(journal_t *); /* Checkpoint list management */ -void __jbd2_journal_clean_checkpoint_list(journal_t *journal, bool destroy); +enum shrink_type {SHRINK_DESTROY, SHRINK_BUSY_STOP, SHRINK_BUSY_SKIP}; + +void __jbd2_journal_clean_checkpoint_list(journal_t *journal, enum shrink_type type); unsigned long jbd2_journal_shrink_checkpoint_list(journal_t *journal, unsigned long *nr_to_scan); int __jbd2_journal_remove_checkpoint(struct journal_head *); int jbd2_journal_try_remove_checkpoint(struct journal_head *jh); -- 2.53.0