From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D2FB51357F for ; Wed, 9 Sep 2026 10:34:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788950068; cv=none; b=RTuFNpozp63ByR1DNxK9XmQQtHAQeyAAI3PjpBPd/Jv6BdrjQ9WkS821QfiiM9UyEZgvlMMKPuvGK30bCTGDLzT005tL6DMtsxlbv11ayfKSSkhzt1uJRrySUACsxESmQ7FAuXJxL/Z2vkDldjtOznzlHG6vOX6fWQ3j7qHcrTg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788950068; c=relaxed/simple; bh=DOQq/G9wVa7oKShUNyib3jfSnZxSEVn85VYQ3SHvkhA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ivCCFtkvbFA9N/2gFAAJqOp2w30n1yOmciQB4o4C0wMVne+bSO8dbe20cayNNV/fEVKsLX46X8wl2SQkwhE6nepQYc6C+E8kcsfhE6ZYzvN/96Z7lAu6IoopNirZm7ALn7qcreC9VKCi7HbzATNPVemFiTewJC6wXqDqVFuFkX0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CKVFs22e; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CKVFs22e" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C0ED1F00A3D; Wed, 9 Sep 2026 10:34:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788950067; bh=X/IWgLhpC9nPrkDO10sh+Z51ym2L5gLy9OHeZVjHeGA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=CKVFs22eqefJcKU7pcBuRhpkjKvmYQCU5AMBKiSSDdLvwuw1onF4PUgAPHrfjeewN 2zzJnK3MwOHRJS9Qx/uhvHhbm+Uvo85z6PVkn/bSnJHcgOQaeOFURIch3ztJhtI7x6 K2tviu/Ia7WSSsQXFZHNqfQPYpOzUArgo6uSd2ubHAay/lcvMHKjZi7M5x7oYLoI6q 1638GUzA4oHQ/e2TFZFwjq/xWhB+QG4wCFDtVvl9bIqvj8zuo/yvDbdL7Bsw6U5av6 sANSrX8t/dJwzzb9yYB3UNzKZHFs3dAYcNbgthSXO4qGByUs3oIBC+kjRHfepqlmv4 pb833jU8WzD/g== From: Sasha Levin To: stable@vger.kernel.org Cc: Joseph Qi , Heming Zhao , Mark Fasheh , Joel Becker , Junxiao Bi , Changwei Ge , Jun Piao , Andrew Morton , Sasha Levin Subject: [PATCH 6.6.y 1/2] ocfs2: validate dx_root extent list fields during block read Date: Wed, 9 Sep 2026 06:34:23 -0400 Message-ID: <20260909103424.1543919-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026090340-lecturer-unwashed-3c35@gregkh> References: <2026090340-lecturer-unwashed-3c35@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Joseph Qi [ Upstream commit 775c17386a6fd695f999d4cda90e3931386570dd ] Patch series "ocfs2: consolidate extent list validation into block read callbacks". ocfs2 validates extent list fields (l_count, l_next_free_rec) at various points during extent tree traversal. This is fragile because each caller must remember to check for corrupted on-disk data before using it. This series moves those checks into the block read validation callbacks (ocfs2_validate_dx_root and ocfs2_validate_extent_block), so corrupted fields are caught early at block read time. Redundant post-read checks are then removed. This patch (of 4): Move the extent list l_count validation from ocfs2_dx_dir_lookup_rec() into ocfs2_validate_dx_root(), so that corrupted on-disk fields are caught early at block read time rather than during directory lookups. Additionally, add a l_next_free_rec <= l_count check to prevent out-of-bounds access when iterating over extent records. Both checks are skipped for inline dx roots (OCFS2_DX_FLAG_INLINE), which use dr_entries instead of dr_list. Link: https://lkml.kernel.org/r/20260403090803.3860971-1-joseph.qi@linux.alibaba.com Link: https://lkml.kernel.org/r/20260403090803.3860971-2-joseph.qi@linux.alibaba.com Signed-off-by: Joseph Qi Reviewed-by: Heming Zhao Cc: Mark Fasheh Cc: Joel Becker Cc: Junxiao Bi Cc: Changwei Ge Cc: Jun Piao Signed-off-by: Andrew Morton Stable-dep-of: bc70726ddad5 ("ocfs2: validate directory-index entry counts when reading metadata") Signed-off-by: Sasha Levin --- fs/ocfs2/dir.c | 26 +++++++++++++++++++++++++- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c index da1ab3282c181..b706092c0c1b4 100644 --- a/fs/ocfs2/dir.c +++ b/fs/ocfs2/dir.c @@ -580,7 +580,7 @@ static int ocfs2_validate_dx_root(struct super_block *sb, mlog(ML_ERROR, "Checksum failed for dir index root block %llu\n", (unsigned long long)bh->b_blocknr); - return ret; + goto bail; } if (!OCFS2_IS_VALID_DX_ROOT(dx_root)) { @@ -588,8 +588,32 @@ static int ocfs2_validate_dx_root(struct super_block *sb, "Dir Index Root # %llu has bad signature %.*s\n", (unsigned long long)le64_to_cpu(dx_root->dr_blkno), 7, dx_root->dr_signature); + goto bail; + } + + if (!(dx_root->dr_flags & OCFS2_DX_FLAG_INLINE)) { + struct ocfs2_extent_list *el = &dx_root->dr_list; + + if (le16_to_cpu(el->l_count) != ocfs2_extent_recs_per_dx_root(sb)) { + ret = ocfs2_error(sb, + "Dir Index Root # %llu has invalid l_count %u (expected %u)\n", + (unsigned long long)le64_to_cpu(dx_root->dr_blkno), + le16_to_cpu(el->l_count), + ocfs2_extent_recs_per_dx_root(sb)); + goto bail; + } + + if (le16_to_cpu(el->l_next_free_rec) > le16_to_cpu(el->l_count)) { + ret = ocfs2_error(sb, + "Dir Index Root # %llu has invalid l_next_free_rec %u (l_count %u)\n", + (unsigned long long)le64_to_cpu(dx_root->dr_blkno), + le16_to_cpu(el->l_next_free_rec), + le16_to_cpu(el->l_count)); + goto bail; + } } +bail: return ret; } -- 2.53.0