From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BAFA3D16F8 for ; Wed, 9 Sep 2026 10:55:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788951359; cv=none; b=D1fFTT7sojVcwyCWjjEVIjCIg83jUV3kImz4Tli1kwg3gaDv0kFU6nx1+ftBf4/Vwlz/6gYI4P2sGzfGLJcXsGi35mRsZ4yU18wu0h+T7Tm0d2Hz4/TBHv/Aqe+VoAHv/8wOUbioKpS4gFOSbsnHRdGieHkO3aX4uS9E8j7zVUI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788951359; c=relaxed/simple; bh=FYTguQ4FqswFlAhCV3N95kizeMw76HE9jc6H2e9NzdE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=QeGtVzmoLkIepuFcd8BLN6Vzfno3UZB5fveklq3btxJv+3b+1DRGKEqWgVJ1DQE8i8heU3t4RpQM4LMPSJzK7Fy55QWIeiUucjjAJWliz2HWl14pfPz94ROyD6V0XxjU1inuj8c62pgirB9UPNsA+y49sk7j0PcA0MvcfM/mCAI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Wtse51X1; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Wtse51X1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 67CDE1F00A3D; Wed, 9 Sep 2026 10:55:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788951356; bh=pFuW2wZfDG5IQsRUp/h6kETZHQbrjcX51Ht8tvOmvRg=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Wtse51X138NcCN1XpLaewxKBIHP898BFNCxQJYuN5Psn4GJjgLUUDuPrKBzj6ShlX JkdFee+ogH+w3zbQ8alVN0UpZeolcApbgi6QsVDaPwjq6X9F4HS9jsSrIXN0zncTR7 O5MKTzlDZtLFJfarNxH3l94EVOgKVyO70Ke1SSQ9hmdhYhtDJSzeKv5a8VbCcqvdmS jyaHLriDWuAhxujJtgF/vQmdd1DFYJXThMf8Aiv/ZuZwkmjOqfV6MSeDvTtnwNLwuu 2tq/AtmZ6lSbNoSxC160czv3uJnf71CD87kEC++OK4czez6Aiv4gz+C/4DlSDjosGY MzjmlZ8KbOi/A== From: Sasha Levin To: stable@vger.kernel.org Cc: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Sebastian Reichel , Sasha Levin Subject: [PATCH 6.6.y 1/3] power: supply: lp8788-charger: Convert to platform remove callback returning void Date: Wed, 9 Sep 2026 06:55:52 -0400 Message-ID: <20260909105554.1634698-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026090352-math-comrade-6046@gregkh> References: <2026090352-math-comrade-6046@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Uwe Kleine-König [ Upstream commit 7810ba3c5110ce66652ec6bd2abb92da5d726c3b ] The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() is renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/20230918133700.1254499-17-u.kleine-koenig@pengutronix.de Signed-off-by: Sebastian Reichel Stable-dep-of: 831c29a12d56 ("power: supply: lp8788-charger: fix use-after-free on remove") Signed-off-by: Sasha Levin --- drivers/power/supply/lp8788-charger.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/power/supply/lp8788-charger.c b/drivers/power/supply/lp8788-charger.c index 755b6a4379b85..2c81be82a41a4 100644 --- a/drivers/power/supply/lp8788-charger.c +++ b/drivers/power/supply/lp8788-charger.c @@ -714,20 +714,18 @@ static int lp8788_charger_probe(struct platform_device *pdev) return 0; } -static int lp8788_charger_remove(struct platform_device *pdev) +static void lp8788_charger_remove(struct platform_device *pdev) { struct lp8788_charger *pchg = platform_get_drvdata(pdev); flush_work(&pchg->charger_work); lp8788_irq_unregister(pdev, pchg); lp8788_psy_unregister(pchg); - - return 0; } static struct platform_driver lp8788_charger_driver = { .probe = lp8788_charger_probe, - .remove = lp8788_charger_remove, + .remove_new = lp8788_charger_remove, .driver = { .name = LP8788_DEV_CHARGER, }, -- 2.53.0