From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8ADB4AEBDB for ; Wed, 9 Sep 2026 10:55:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788951362; cv=none; b=R6UP3eZfF7e21w8rXN+yEsT8CJwPYz88iwDOhzYmH5JjD35H/bdTirhQAm6RyAnfHYeTYLVxypUx/Y9ZubR7KG87u6XFmOV+DMSH8BXHgskBKMbVKq1M+UKSFlmhNTOlIutMXhv1TzLGnTCcx4VN8hJsVnY8ehki64ULEEoa6WY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788951362; c=relaxed/simple; bh=2heZ7EswTcFNgYFR/uYDyK/GUiAaU+aOf/TReVW6Wn8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eExKy3wi+329eu7i5e+jXh1+RDPbjHcKEPu9xDfMLFtoU945LtaDs39Q50WwUoSnp146GFqq6VqnayxfRdk4LOISc0y2N1c1LGz5KC/XfMLzXN/+6228Q5z48aZar0hGdzlQiz4ARXqSqLTJsvnQH3R/PnGYTkCyScqmBFBfs6k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=J/HS4QLO; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="J/HS4QLO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC2121F00A3E; Wed, 9 Sep 2026 10:55:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788951358; bh=mTE2YoKRqrcniUzusawLkJkgH7H17oYujw+rDh1Ppe0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=J/HS4QLOWzwoFI510KRirVyUnjW2IwZLpBDfbqZDul1JD/lYlANn6OYahEvF0HFkF AfywtJ71YYJZT9vgoF+R8zxMJ8gMX7LXoq61hnFMzht0sEfHjTHMn5UfyNBFLB4Tgu ai7+mQsOokb3f2HUcllBmJMhj1UuLSD7S7h6Paj0EwFF6ofSUvDnY7doL2MsZX+MB0 Bbdw9kneqT43e/hKsr3K/yemdcVrPLcL7edCC0xZvSB+8ALZ3ouqp2yEKh1p7ryoiZ E36ihrcBPUXW3JvsCW1GzhAGrlbMkK/ivoJ9/y3k1xMTE8mUenkevs8w4Qqx1+r5DU yxlnQcnjhw1ew== From: Sasha Levin To: stable@vger.kernel.org Cc: Fan Wu , Sebastian Reichel , Sasha Levin Subject: [PATCH 6.6.y 3/3] power: supply: lp8788-charger: fix use-after-free on remove Date: Wed, 9 Sep 2026 06:55:54 -0400 Message-ID: <20260909105554.1634698-3-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260909105554.1634698-1-sashal@kernel.org> References: <2026090352-math-comrade-6046@gregkh> <20260909105554.1634698-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Fan Wu [ Upstream commit 831c29a12d560f8a3225f43050b3fbb5dfd79c66 ] lp8788_charger_remove() flushes charger_work before unregistering the IRQs. An IRQ thread can queue charger_work after flush_work() has returned. The work can then run after devres frees pchg and dereference it in lp8788_charger_event(). Unregister the IRQs first. free_irq() waits for any running threaded handler, so no handler can queue more work afterwards. Then use cancel_work_sync() to cancel pending work or wait for running work to finish. This issue was found by an in-house static analysis tool. Fixes: 98a276649358 ("power_supply: Add new lp8788 charger driver") Cc: stable@vger.kernel.org Assisted-by: Codex:gpt-5.6 Signed-off-by: Fan Wu Link: https://patch.msgid.link/20260802035442.421697-1-fanwu01@zju.edu.cn Signed-off-by: Sebastian Reichel Signed-off-by: Sasha Levin --- drivers/power/supply/lp8788-charger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/supply/lp8788-charger.c b/drivers/power/supply/lp8788-charger.c index 72b170b4ac46a..8d9a60d2f7da3 100644 --- a/drivers/power/supply/lp8788-charger.c +++ b/drivers/power/supply/lp8788-charger.c @@ -710,8 +710,8 @@ static void lp8788_charger_remove(struct platform_device *pdev) { struct lp8788_charger *pchg = platform_get_drvdata(pdev); - flush_work(&pchg->charger_work); lp8788_irq_unregister(pdev, pchg); + cancel_work_sync(&pchg->charger_work); } static struct platform_driver lp8788_charger_driver = { -- 2.53.0