From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47A7D533589 for ; Wed, 9 Sep 2026 11:00:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788951646; cv=none; b=i8U6jwZZc2SzMKXNbW3cBUFB2c3gcBZIOYRqkvNooISIyDn1ROeKmGCQyoQcmb46tZd2bsQHh88TP8PoiJN40MmjcYht83oR9tWaYhgHv4UrRjr9Kf1mAG0GSnUSvi58ueSc/BjDs3SuLYzmkZlBd7P5fDaxxPdD6W+/Ay8AH90= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788951646; c=relaxed/simple; bh=/9aAHjwIlCFk5Ilox7VAFsBI8/VykXHEt27cTaOMAAA=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=pmdnCboJ4kZbriDGN7VfSwcVhHJfp4c4SjomXDsKo3uF1QeJhT0o1TSQ0vZjQlhN3/4BgH17FEUPOqbf8cIW0zgGPYlaZEKCgjs16qWTH71nzG2h0+ldHZr6UbDof8Kj080/Y5X6wpGlOJ0xHtp9JWGHEfUS03nxqqfBdnvb/5I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=g6KZa67x; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="g6KZa67x" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 964A71F00A3E; Wed, 9 Sep 2026 11:00:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1788951643; bh=kgmdCuHfZE1AGr0cpGpTbYPElfUBkIKIFgm5e7Feshk=; h=Subject:To:Cc:From:Date; b=g6KZa67xmvyvMHG+difXTrIJuIMrp3Te5xWY/G+xKy1/YL2EC3ZmONdSa4WiIZGMN 7vmVNvg0gR37nxyBztWjek4ZuE2c7Wjxkm1gDNyh4epOyrFgDdrUlAZCeF+wiDVnOP RPfVWlvf3Nirv5wEAxUBdhrB8svF2KRinjBaIlzQ= Subject: FAILED: patch "[PATCH] media: saa7164: fix cleanup on resource allocation failure" failed to apply to 5.15-stable tree To: lgs201920130244@gmail.com,hverkuil+cisco@kernel.org Cc: From: Date: Wed, 09 Sep 2026 12:50:52 +0200 Message-ID: <2026090952-april-junkie-ed48@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.15-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.15.y git checkout FETCH_HEAD git cherry-pick -x 28e84c6e2e6753ed238ea097b2842a32a6a6879b # git commit -s git send-email --to '' --in-reply-to '2026090952-april-junkie-ed48@gregkh' --subject-prefix 'PATCH 5.15.y' 'HEAD^..' Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 28e84c6e2e6753ed238ea097b2842a32a6a6879b Mon Sep 17 00:00:00 2001 From: Guangshuo Li Date: Sat, 18 Jul 2026 14:10:11 +0800 Subject: [PATCH] media: saa7164: fix cleanup on resource allocation failure saa7164_dev_setup() adds the device to the global saa7164_devlist before requesting the PCI BAR memory regions. If get_resources() fails, saa7164_dev_setup() decrements the device count and returns an error, but leaves the device on saa7164_devlist. The probe error path then frees the device, leaving a dangling entry on the global list. Reuse the existing MMIO mapping error path to remove the device from saa7164_devlist and decrement the device count before returning. Also release BAR0 if it was successfully requested but the BAR2 request fails. Fixes: 443c1228d505 ("V4L/DVB (12923): SAA7164: Add support for the NXP SAA7164 silicon") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li Signed-off-by: Hans Verkuil diff --git a/drivers/media/pci/saa7164/saa7164-core.c b/drivers/media/pci/saa7164/saa7164-core.c index 683bd78288b3..ac5eb6b923e2 100644 --- a/drivers/media/pci/saa7164/saa7164-core.c +++ b/drivers/media/pci/saa7164/saa7164-core.c @@ -878,6 +878,9 @@ static int get_resources(struct saa7164_dev *dev) if (request_mem_region(pci_resource_start(dev->pci, 2), pci_resource_len(dev->pci, 2), dev->name)) return 0; + + release_mem_region(pci_resource_start(dev->pci, 0), + pci_resource_len(dev->pci, 0)); } printk(KERN_ERR "%s: can't get MMIO memory @ 0x%llx or 0x%llx\n", @@ -1000,8 +1003,7 @@ static int saa7164_dev_setup(struct saa7164_dev *dev) dev->name, dev->pci->subsystem_vendor, dev->pci->subsystem_device); - saa7164_devcount--; - return -ENODEV; + goto err_devlist; } /* PCI/e allocations */ @@ -1039,7 +1041,7 @@ static int saa7164_dev_setup(struct saa7164_dev *dev) iounmap(dev->lmmio); err_ioremap_bar0: release_resources(dev); - +err_devlist: scoped_guard(mutex, &devlist) { list_del(&dev->devlist); }