From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 001D249E14F for ; Fri, 11 Sep 2026 01:13:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789089205; cv=none; b=kesnQ/9s1CUMsZb6RaDKntCrP7sIjToMr9lw3yt0ngr0Oa8f7hs+cfx3+ccT43HQKBa6zmQJvnYWoDGMLGhlfbvwpHFFm7FA7HeTOUDfVME+ULp4nbVEJgf3Q5K+2uKVdOe3oBXRyvw+yANGN9zpiovpuByM73C7lEKe8XmSXsQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789089205; c=relaxed/simple; bh=sj+5U2JeLRM09uIUoPDdBLqFDV8zdMfKQX//N7rUGeg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CleDP2xhWgiWr/2bDWE/K/QTPNe8CSMwqH5xeIoYN04+XPfTgEobjnx1oIvWp9ijJA9caG9fpyBvEHAfh7ApAk8Hg4tkJs92phqlmcoISzVDFvXbFgMwDouFejZ3i/V4kg9xzldjzc27x+ngTaPJBv/ESdwIBwI1ByZLP72DAs8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aTHXaxLh; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aTHXaxLh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EEB741F00898; Fri, 11 Sep 2026 01:13:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789089203; bh=5MN6cbjlcTcfTlCHpQ9v+W6X3B27GX/inDWVhJzju+s=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=aTHXaxLhNDqxG8/NmyE9EB4o0QufKoCgT6+PLO6fmNj4mRDOaedDBMhfzmI58pwGR 9j5xU4sji8M33tFJH5TjUQw1/DW6roc/cZnbA9M34HzyZK4yXO7lZiUH8Y571TzNe4 Td+PmsLQtPK7wOgpf2AJesw11FEyJLGkg1s89dWN96w9CKAnflOkHhZbaj2TqAFtIy ijhXBSbGcYx9iAbz2CfPyXUraVm0lNSUvXSYiw7S02oacioibFGmphG2xm/5ZjOKIo Qbxaq+nxZvqMhwatQffxNJV1YM70Q1IHq35nWKq4LdDeK3J7+/ZOqgg1W8ieRAQYCA 9/OO+55PmSjig== From: Sasha Levin To: stable@vger.kernel.org Cc: "Miquel Raynal (DAVE)" , Andrea Scian , Michal Simek , Sasha Levin Subject: [PATCH 6.12.y 2/2] mtd: rawnand: pl353: Make sure we use the monolithic helpers for raw accesses Date: Thu, 10 Sep 2026 21:13:20 -0400 Message-ID: <20260911011320.4035300-2-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260911011320.4035300-1-sashal@kernel.org> References: <2026090927-ocelot-praising-df87@gregkh> <20260911011320.4035300-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: "Miquel Raynal (DAVE)" [ Upstream commit 80ecacd054ffeb60cd28e46ed5cd6bd0d2de318b ] Any access not using the hardware ECC engine should be monolithic because the controller has its very own way of handling the end of a transaction during operation configuration, so we cannot easily make repeated reads. This has the side effect of fixing support for software ECC engines. Suggested-by: Andrea Scian Cc: stable@vger.kernel.org Fixes: 08d8c62164a3 ("mtd: rawnand: pl353: Add support for the ARM PL353 SMC NAND controller") Signed-off-by: Miquel Raynal (DAVE) Acked-by: Michal Simek Signed-off-by: Miquel Raynal Signed-off-by: Sasha Levin --- drivers/mtd/nand/raw/pl35x-nand-controller.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/nand/raw/pl35x-nand-controller.c b/drivers/mtd/nand/raw/pl35x-nand-controller.c index c7407e9bda85a..d41b992c6d516 100644 --- a/drivers/mtd/nand/raw/pl35x-nand-controller.c +++ b/drivers/mtd/nand/raw/pl35x-nand-controller.c @@ -914,7 +914,6 @@ static int pl35x_nand_init_hw_ecc_controller(struct pl35x_nandc *nfc, chip->ecc.steps = mtd->writesize / chip->ecc.size; chip->ecc.read_page = pl35x_nand_read_page_hwecc; chip->ecc.write_page = pl35x_nand_write_page_hwecc; - chip->ecc.write_page_raw = nand_monolithic_write_page_raw; pl35x_smc_set_ecc_pg_size(nfc, chip, mtd->writesize); nfc->ecc_buf = devm_kmalloc(nfc->dev, chip->ecc.bytes * chip->ecc.steps, @@ -981,7 +980,6 @@ static int pl35x_nand_attach_chip(struct nand_chip *chip) case NAND_ECC_ENGINE_TYPE_NONE: case NAND_ECC_ENGINE_TYPE_SOFT: dev_dbg(nfc->dev, "Using software ECC (Hamming 1-bit/512B)\n"); - chip->ecc.write_page_raw = nand_monolithic_write_page_raw; break; case NAND_ECC_ENGINE_TYPE_ON_HOST: dev_dbg(nfc->dev, "Using hardware ECC\n"); @@ -995,6 +993,9 @@ static int pl35x_nand_attach_chip(struct nand_chip *chip) return -EINVAL; } + chip->ecc.read_page_raw = nand_monolithic_read_page_raw; + chip->ecc.write_page_raw = nand_monolithic_write_page_raw; + return 0; } -- 2.53.0