From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C0DC383325 for ; Fri, 11 Sep 2026 14:51:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789138266; cv=none; b=EVno9/0PxZ5tN0J09GXD9+7qJif7rbQiTEdMCftTGX9kwiWHNNnVTYd5wJjUt7rBfo8qV+1M0uJMnkhuj4h41IQPrZliVQYi/alQYaLC1cVH0kbKbYFA/SYdaD86AqsQHn8asmGXpKxl9NSHg+HwsD8BRoLuGZKEtDuHgzIYXO4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789138266; c=relaxed/simple; bh=cuSD4Q/iuamdb7yYOcdgvJyT0ljH8WYdhuCIa5ptJ3Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=f3hD57RZU9ypzgyXRvmd84BYGP2/OZ5y+Z51KHAYEpeeIakezI025RABa7ora6v8ohKF0JahoPDSvISEco5TTLkIUlT0eO7EwfD94HQCrGzkDQcSvE4J+JSFNuxm9ZKLmp5kwGP8ttnoyFO6ioSSRh80EkTkmFHjw+tw8WX6rKU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YbS6uMp5; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YbS6uMp5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C068D1F0089A; Fri, 11 Sep 2026 14:51:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789138265; bh=yIsKA5mSg8Ctl6AHHXY3YSqOC1ccRtAegXe9Fdipzac=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=YbS6uMp55FZVuhnZGl7xXscn98s+QRRrOKA/RMtNM/uHwHUAAm71Sa7HIkia0omX8 GirSbn6QpNPOYCf7JBwnD4jVD1hN8WDWdfTyS9UbTq0EYhCCPokp3lEa5ipk3jGHdl bWstBNFCyjybvUl3C5jFatU+Qm3TAgj28wBY/PanULPLJhzv4NBhrHActUrXgOm/M5 4q0pmTCzbILs2OSa7RNuFt7OYzm6aqIxxieSm06SAx0dlFps/J5FAOGi1fH6hUs1JQ hJqmxUagaezeNPbtvdMZOfTV2m5KDXONTe0ndOo7ZgFLzjVuIG0fPDUEEpQlMq20aM iSWPsh7VqaQAA== From: Sasha Levin To: stable@vger.kernel.org Cc: Nilesh Javali , Sashiko , "Martin K. Petersen (Oracle)" , Sasha Levin Subject: [PATCH 7.2.y 2/2] scsi: qla2xxx: Use memset_io() to clear QLAFX00 request ring slot Date: Fri, 11 Sep 2026 10:51:02 -0400 Message-ID: <20260911145102.985443-2-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260911145102.985443-1-sashal@kernel.org> References: <2026090948-repeater-dealing-222e@gregkh> <20260911145102.985443-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Nilesh Javali [ Upstream commit 626e44f3d8a924a97a3848a9fd45833947e081e9 ] For QLAFX00 the request ring is ioremapped device I/O memory (ha->iobase + req_que_off), not DMA-coherent RAM, which is why the rest of the FX00 path accesses it through memcpy_toio() and the wrt_reg_* helpers. __qla2x00_alloc_iocbs() however zeroed the producer slot with a plain memset(). On architectures such as ARM64 a regular memset() may emit unaligned or block-zeroing instructions (e.g. DC ZVA) that are invalid on Device memory, leading to a synchronous external abort. Use memset_io() to clear the slot for QLAFX00, matching the I/O accessors used elsewhere on this ring. Other adapters keep the plain memset() on their DMA-coherent rings. The zero-fill is retained for FX00 because its IOCB builders (e.g. qlafx00_fxdisc_iocb()) copy only part of the entry and rely on the unused tail being pre-zeroed. Fixes: 8ae6d9c7eb10 ("[SCSI] qla2xxx: Enhancements to support ISPFx00.") Cc: stable@vger.kernel.org Reported-by: Sashiko Signed-off-by: Nilesh Javali Link: https://patch.msgid.link/20260730155838.2119230-12-njavali@marvell.com Signed-off-by: Martin K. Petersen (Oracle) Signed-off-by: Sasha Levin --- drivers/scsi/qla2xxx/qla_iocb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_iocb.c b/drivers/scsi/qla2xxx/qla_iocb.c index 3e2b632002a54..25ce384c30e91 100644 --- a/drivers/scsi/qla2xxx/qla_iocb.c +++ b/drivers/scsi/qla2xxx/qla_iocb.c @@ -2351,11 +2351,13 @@ __qla2x00_alloc_iocbs(struct qla_qpair *qpair, srb_t *sp) */ req->cnt -= req_cnt; pkt = qla_req_ring_slot(ha, req); - memset(pkt, 0, qla_req_entry_size(ha)); if (IS_QLAFX00(ha)) { + memset_io((void __iomem __force *)pkt, 0, + qla_req_entry_size(ha)); wrt_reg_byte((u8 __force __iomem *)&pkt->entry_count, req_cnt); wrt_reg_dword((__le32 __force __iomem *)&pkt->handle, handle); } else { + memset(pkt, 0, qla_req_entry_size(ha)); pkt->entry_count = req_cnt; pkt->handle = handle; } -- 2.53.0