From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F9C133993 for ; Fri, 11 Sep 2026 17:19:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789147167; cv=none; b=uxLFTVds/QjYpRdhCUzjkDrR2ObHgjwQWm2mWNpicHWJUI0q8AkyD3wdd8DAXESPeIHJOirdJ7Wn5hDZICyOVm1VM5kYZH3LR1CCDR4E8WR3BwxiyzFY4rstMxC175/36rZTDL/lq7+U8VB0mqwCCIi+srbNuQ1WdLR+QdiBOzA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789147167; c=relaxed/simple; bh=jUZVvVp1M2rmYXcg5nfAvXPvIiLtG7qvm6YVU93PCY0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LNKED0il1R/wA7YUQ+6s8YfS5PAKMezx3/SxsA9T+syfDQKw4NHoOFnmHb3VgKL8N84Nc40mNOTzlKiTCAMV7DQeinkRM4VPQaI5b8wwn25gbyJxc6+1CXnrPSZcSYO8eo/HQLO69dmT7Ry3sKOxJgAtALwFzyh0OMPdHBXxZ3w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ENUOIqhM; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ENUOIqhM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9481F1F000FF; Fri, 11 Sep 2026 17:19:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789147166; bh=KLaV3PWn362iVTkqhCbHXOVMuOJTyBs2EftpfHsYzAo=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=ENUOIqhM90Gs3YtOhs+WideFnglWaio4iXb+lKnRfRH2McGcB+GyVNr/+IM/ZIX95 GL3fasBb6ufCl0ylw/fHCh06n6ZVHsmHdpPWEJUuqhnDGq1fod4QYbQ3pADFRj9z7T EqlYDiRfDaiFjabdIjHn4AfglIk1uWU+4fr8cbG6yd/GgcJbByuzdWqm4VqZekdGvk qscWq8yyR0eMhjo2gt0LpdkIJhkald9cUw5w4YzFv95pZ/xZKdnZ/yW5a1wvLkOxgB aX+bhsR/dx1EMKhtu0bvtf3GUt7tmUHHaEh3qegeLo3jIStB5nviG9cdKhce25Hf9U peCGBuvse91FQ== From: Sasha Levin To: stable@vger.kernel.org Cc: Nilesh Javali , Sashiko , "Martin K. Petersen (Oracle)" , Sasha Levin Subject: [PATCH 5.15.y] scsi: qla2xxx: Null out freed pointers in qla2x00_mem_alloc() error path Date: Fri, 11 Sep 2026 13:19:24 -0400 Message-ID: <20260911171924.1256365-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026090900-plot-uninvited-75a9@gregkh> References: <2026090900-plot-uninvited-75a9@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Nilesh Javali [ Upstream commit 6d90f0feb929f6c0f3010f9af4747c7230b75993 ] When qla2x00_mem_alloc() fails, qla2x00_probe_one() jumps to probe_hw_failed and calls qla2x00_mem_free(). Several error labels in qla2x00_mem_alloc() freed adapter members (elsrej.c, purex_dma_pool, flt, sfp_data, loop_id_map, async_pd, sf_init_cb, ex_init_cb, npiv_info) but left the pointers dangling. qla2x00_mem_free() then freed them a second time. Worse, for the dma_pool members it issued dma_pool_free(ha->s_dma_pool, ...) after s_dma_pool had already been destroyed and set to NULL at fail_s_dma_pool, dereferencing a NULL pool. Clear each freed pointer (and its DMA handle) in the error labels so the subsequent qla2x00_mem_free() skips them. Cc: stable@vger.kernel.org Reported-by: Sashiko Signed-off-by: Nilesh Javali Link: https://patch.msgid.link/20260730155838.2119230-13-njavali@marvell.com Signed-off-by: Martin K. Petersen (Oracle) [ adapted cleanup changes for missing fail_lsrjt and fail_flt_data blocks. ] Signed-off-by: Sasha Levin --- drivers/scsi/qla2xxx/qla_os.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index fe53cb84c97ea..aca0ba5f4a5c5 100644 --- a/drivers/scsi/qla2xxx/qla_os.c +++ b/drivers/scsi/qla2xxx/qla_os.c @@ -4431,23 +4431,36 @@ qla2x00_mem_alloc(struct qla_hw_data *ha, uint16_t req_len, uint16_t rsp_len, fail_elsrej: dma_pool_destroy(ha->purex_dma_pool); + ha->purex_dma_pool = NULL; fail_flt: dma_free_coherent(&ha->pdev->dev, sizeof(struct qla_flt_header) + FLT_REGIONS_SIZE, ha->flt, ha->flt_dma); + ha->flt = NULL; + ha->flt_dma = 0; fail_flt_buffer: dma_free_coherent(&ha->pdev->dev, SFP_DEV_SIZE, ha->sfp_data, ha->sfp_data_dma); + ha->sfp_data = NULL; + ha->sfp_data_dma = 0; fail_sfp_data: kfree(ha->loop_id_map); + ha->loop_id_map = NULL; fail_loop_id_map: dma_pool_free(ha->s_dma_pool, ha->async_pd, ha->async_pd_dma); + ha->async_pd = NULL; + ha->async_pd_dma = 0; fail_async_pd: dma_pool_free(ha->s_dma_pool, ha->sf_init_cb, ha->sf_init_cb_dma); + ha->sf_init_cb = NULL; + ha->sf_init_cb_dma = 0; fail_sf_init_cb: dma_pool_free(ha->s_dma_pool, ha->ex_init_cb, ha->ex_init_cb_dma); + ha->ex_init_cb = NULL; + ha->ex_init_cb_dma = 0; fail_ex_init_cb: kfree(ha->npiv_info); + ha->npiv_info = NULL; fail_npiv_info: dma_free_coherent(&ha->pdev->dev, ((*rsp)->length + 1) * sizeof(response_t), (*rsp)->ring, (*rsp)->dma); -- 2.53.0