From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C31BA32B126; Sat, 12 Sep 2026 18:50:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789239027; cv=none; b=NWcHsypx5FvMTcGCUeSuwtKO8agF9Nt+gkR1jgEMjqEI5xJuYUHY44Wfxg6GcGGZf+mzABYnJjv5yynNsPOlP6+uabGCHtLw+D8BPJoXHxYY8FkRTG7jmEkHMJzHdTe4egdWCDXPUAT6+ZATYfX4FldaDYfsktCFGN6GPbGYXPE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789239027; c=relaxed/simple; bh=Dt3OmTpfIWb6hIpyKWkDpC3UeZHVOHzW+xNj6JW+O/w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Y71pUIXjWRTuXoc3Lhw+aIy9+Y6d5eA0QrNIENI4eTTmK4SGpyHYUYbCQ25LlU2mi05eqybh6UxNSjzWPdO72UTDr2a9OMYzO5NKeK87KNl+1S4HpS9whIO29Mmvl0FPAQoU4aQ56ZxPb6b5Fnqt74x+jkHQrWIGlI/lPzF9K7g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=M5RFCKt5; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="M5RFCKt5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8A2721F000FF; Sat, 12 Sep 2026 18:50:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789239026; bh=RvRep/GURU6FLHA/vRIvhJurM6/SWIyQb4Gv4W227xY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=M5RFCKt5wdDH/wIDGNoUSXsjvmoeHxKCOA9snWbm19Km54kdkWG7EvqueFz/2E2ZJ mW5NXeoT2zIRSAYVCzObxMwf7XIBkic5O3QHDWg+8OW7H+rXMevjVXOc0pcvNkAiH5 YNK9O7lisbHqAe3R5RPRpAuIDG6tVkdjfRDtiT/U= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Konrad Dybcio , Mukesh Ojha , Will Deacon , Sasha Levin Subject: [PATCH 5.15 579/935] iommu/qcom: Fix inverted fault report check in qcom_iommu_fault() Date: Sat, 12 Sep 2026 09:00:09 +0200 Message-ID: <20260912065540.118280063@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065526.833703348@linuxfoundation.org> References: <20260912065526.833703348@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Mukesh Ojha [ Upstream commit 1f33b8208a1978b0c0d6ad60a47fe4bb7a235e58 ] report_iommu_fault() returns 0 when a fault handler successfully handles the fault, and -ENOSYS when no handler is installed. The condition '!report_iommu_fault()' evaluates to true (printing "Unhandled context fault") precisely when the fault *was* handled, and stays silent when no handler is present — the opposite of what is intended. Remove the '!' so the driver logs unhandled faults correctly. Fixes: 049541e178d5 ("iommu: qcom: wire up fault handler") Reviewed-by: Konrad Dybcio Signed-off-by: Mukesh Ojha Signed-off-by: Will Deacon Signed-off-by: Sasha Levin --- drivers/iommu/arm/arm-smmu/qcom_iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/arm/arm-smmu/qcom_iommu.c b/drivers/iommu/arm/arm-smmu/qcom_iommu.c index 55a2440cb44fe..cf1408a1b781e 100644 --- a/drivers/iommu/arm/arm-smmu/qcom_iommu.c +++ b/drivers/iommu/arm/arm-smmu/qcom_iommu.c @@ -210,7 +210,7 @@ static irqreturn_t qcom_iommu_fault(int irq, void *dev) fsynr = iommu_readl(ctx, ARM_SMMU_CB_FSYNR0); iova = iommu_readq(ctx, ARM_SMMU_CB_FAR); - if (!report_iommu_fault(ctx->domain, ctx->dev, iova, 0)) { + if (report_iommu_fault(ctx->domain, ctx->dev, iova, 0)) { dev_err_ratelimited(ctx->dev, "Unhandled context fault: fsr=0x%x, " "iova=0x%016llx, fsynr=0x%x, cb=%d\n", -- 2.53.0