From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C1363C583B; Sat, 12 Sep 2026 15:59:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789228741; cv=none; b=UxFU9Uevk2zYUFZzTtPQDlC+/0eTfdORIfR9QyF3Cpufj+Kui7Cjk2gBt/nOogfMJlkE8WAtsI0Uns5nypd5dHZTBFCqnGR7oyI87S8rNiEnGN/FAXB1vo0VTZER0GGN/53MGX3bzm3/CXluKfbFnMJYrQ8W9EInD8bykxNpGg8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789228741; c=relaxed/simple; bh=2sd1lwxYSpUreMIenpWV6OpAdBLUfVXL5YMW0o1XKII=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FR4jkeQJJeKO2sXtK8X92wb03v9ZUN5bikNUhx7uD3Mgk941sLFFbFfp63ZCMnHeAA3OKAGYbMEYnSCLPU/obC9b2Q9mTQkdnZBPjt/LiJ/vYYiBX0fsrfK3ohrDxLtmMcV+SoGTMipFQqg4Y64qbmgNXve9BTdNYS0Z6HDKkSY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ylneCbRt; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ylneCbRt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 827021F000FF; Sat, 12 Sep 2026 15:58:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789228740; bh=NTpjiUgnN/MMHFfZg42uV2FqJ16JIfTSI6G3wMZhxfs=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=ylneCbRthYhnNG1SHo1qKbY4ATZs6nXq8e2vCZv3Qr9Wt4Tle1cVmlNZzPNyTFGjh XKrbdkr2aWqC9eEaCKDge5x8FkZjYWGRHUfbLsZ0h1dY1DRKc6ObgTmfCpKU8/yZUg eA30psH4lOoEmFYLyrEdjHG/3lkCjtJeeIIywR3E= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Baochen Qiang , Manivannan Sadhasivam , Jeff Johnson , Sasha Levin Subject: [PATCH 6.1 0446/1191] wifi: ath11k: Clear affinity hint before calling ath11k_pcic_free_irq() in error path Date: Sat, 12 Sep 2026 08:52:54 +0200 Message-ID: <20260912065558.249417280@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065548.086904252@linuxfoundation.org> References: <20260912065548.086904252@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Manivannan Sadhasivam [ Upstream commit 68410c5bd381a81bcc92b808e7dc4e6b9ed25d11 ] If a shared IRQ is used by the driver due to platform limitation, then the IRQ affinity hint is set right after the allocation of IRQ vectors in ath11k_pci_alloc_msi(). This does no harm unless one of the functions requesting the IRQ fails and attempt to free the IRQ. This results in the below warning: WARNING: CPU: 7 PID: 349 at kernel/irq/manage.c:1929 free_irq+0x278/0x29c Call trace: free_irq+0x278/0x29c ath11k_pcic_free_irq+0x70/0x10c [ath11k] ath11k_pci_probe+0x800/0x820 [ath11k_pci] local_pci_probe+0x40/0xbc The warning is due to not clearing the affinity hint before freeing the IRQs. So to fix this issue, clear the IRQ affinity hint before calling ath11k_pcic_free_irq() in the error path. The affinity will be cleared once again further down the error path due to code organization, but that does no harm. Tested-on: QCA6390 hw2.0 PCI WLAN.HST.1.0.1-05266-QCAHSTSWPLZ_V2_TO_X86-1 Cc: Baochen Qiang Fixes: 39564b475ac5 ("wifi: ath11k: fix boot failure with one MSI vector") Signed-off-by: Manivannan Sadhasivam Reviewed-by: Baochen Qiang Link: https://patch.msgid.link/20250225053447.16824-2-manivannan.sadhasivam@linaro.org Signed-off-by: Jeff Johnson Signed-off-by: Sasha Levin --- drivers/net/wireless/ath/ath11k/pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/ath/ath11k/pci.c b/drivers/net/wireless/ath/ath11k/pci.c index 9f00245f73cd7..b50361490b9b2 100644 --- a/drivers/net/wireless/ath/ath11k/pci.c +++ b/drivers/net/wireless/ath/ath11k/pci.c @@ -908,6 +908,8 @@ static int ath11k_pci_probe(struct pci_dev *pdev, return 0; err_free_irq: + /* __free_irq() expects the caller to have cleared the affinity hint */ + ath11k_pci_set_irq_affinity_hint(ab_pci, NULL); ath11k_pcic_free_irq(ab); err_ce_free: -- 2.53.0