From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA10C2E06E4; Sat, 12 Sep 2026 12:38:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789216698; cv=none; b=UZ6IBx3FrfELXI6HaLNz8TzL4fqM+xRKhzb7dKCcWLT8fH64ZhtvKXJ/NGNtYMBzh8XB59zGFjphNgsqGLtBn2w8X3Ieo1gcw/kPMoov8hdKHXRI2f2Z/v8G1SO1P+i/uVmqmQ+V+2lBHEfuq0avKdTmWnOWWvC6toOV4QKMQoE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789216698; c=relaxed/simple; bh=iwaahnmnKgYsp17jTOHRPh1njUhzcORlp0VBrKopjM4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mfVb6LQIoi7LLg+5TandyQVMs59SwU6R0grJk61P6BT0fyT3xkkC7sZc1YPPT37WtATzrhhQordFR6U+8C6fZXUcVj79+D+Af/mAdGNF2X5gWesQBq1MZOc5TMJza11XX2jLHco+7bzixdqro9ld2r5WVG46oQA25fdzSp0LAG8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=uSyB3WeX; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="uSyB3WeX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9511D1F000FF; Sat, 12 Sep 2026 12:38:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789216697; bh=No2r/C3Tjyimo8RRtQRoACEPG5BfXyl1CqgCcE5NeFo=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=uSyB3WeXfiXToXnZf7XQIY/S+U21Ori9XnEVKY395lwgcjKI9dbjYW1hjKDeL2RFK 06rZNYCY8se5YKTt7iztcwS9bwtikYtnM1ARc+O1QbhRvZ5Ly7crxQQEziPIdTaPpE kmt8AE8pIYzbz2ATrX0oaMZYqKqZHY1Qrbf5CPc0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Cheng-Han Wu , Shuah Khan , Sasha Levin Subject: [PATCH 6.12 0747/1376] selftests/zram: fix kernel_gte() for POSIX sh Date: Sat, 12 Sep 2026 08:52:53 +0200 Message-ID: <20260912065624.192297268@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065607.535295758@linuxfoundation.org> References: <20260912065607.535295758@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Cheng-Han Wu [ Upstream commit 649ba27dfac784427a01f9c95c09ecbcb88900d8 ] Commit fc4eb486a59d ("selftests/zram: Skip max_comp_streams interface on newer kernel") added kernel_gte() to zram_lib.sh. The function uses the bash-specific [[ ... ]] conditional, but zram selftests source this file while running under /bin/sh. On systems where /bin/sh is dash, such as Debian, the following test fails: dash -c ' kernel_major=6; kernel_minor=1; major=6; minor=0 if [ $kernel_major -gt $major ]; then echo ok elif [[ $kernel_major -eq $major && $kernel_minor -ge $minor ]]; then echo ok fi' with: dash: 5: [[: not found Use separate POSIX test expressions joined by && instead. Fixes: fc4eb486a59d ("selftests/zram: Skip max_comp_streams interface on newer kernel") Signed-off-by: Cheng-Han Wu Signed-off-by: Shuah Khan Signed-off-by: Sasha Levin --- tools/testing/selftests/zram/zram_lib.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/zram/zram_lib.sh b/tools/testing/selftests/zram/zram_lib.sh index 21ec1966de76c..0d44d83888f9d 100755 --- a/tools/testing/selftests/zram/zram_lib.sh +++ b/tools/testing/selftests/zram/zram_lib.sh @@ -37,7 +37,7 @@ kernel_gte() if [ $kernel_major -gt $major ]; then return 0 - elif [[ $kernel_major -eq $major && $kernel_minor -ge $minor ]]; then + elif [ $kernel_major -eq $major ] && [ $kernel_minor -ge $minor ]; then return 0 fi -- 2.53.0