From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34C5733D505; Sat, 12 Sep 2026 07:30:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789198209; cv=none; b=deIPU0nbs51KYJyXM4Ugaufzq3dsvMFNL16nMzrNiaoKQE2U/DnkaHhUUDu1Re3hg/sAk0gC5oFCCwu8xNdt63XDLHH6LbAPNiswMTx5nrH97CEybsc0eLicbkXCXZvtR/8QV5FYuurFO9yW8aV0qGfKMnXoxl+x1aUg1oPcW94= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789198209; c=relaxed/simple; bh=EoiqxuDnVKxwhfxNq72BKUhnRr6lKPARMZu4VtM5B2M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SyvJRAu50TAeYjC+ZMLhRAT40ubqDGBtJBqJSXmWmpUPkDuC1APXprvdpMF1KOSkJ09ntCk7OFjNHLiQoKunNCN+FChQv8pCoF7dcNn3xUF3vlLmA80GQXwBfOj2AqlvhClpS744QM+yimJ7FcChvwKEtDj/bp3TgEmWOr2JEr4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=VV4tGnt5; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="VV4tGnt5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B54421F000FF; Sat, 12 Sep 2026 07:30:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789198207; bh=4Ug04afzapcrRdBaS8Gc6eAPGjGUoJKtJpRlU5imMgU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=VV4tGnt5VaKJBfP7OEdN13K8Wvzsf7VJa2uMwxMBkQSu+vmtceLV+l+c80M+6RFZC eTer2xFNAvXtC7CAm+j+OzNGg2m1tbWVhRNKVLkrdiiiakw9drzs1vNVQfGN47H0w8 v/rCc/tW73bR6HqtMZjKqwwfaVLV9fRny3sTNmBM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Laxman Acharya Padhya , Linus Walleij , Sasha Levin Subject: [PATCH 7.2 0334/1815] drm/panel: samsung-s6d16d0: Power off on prepare failure Date: Sat, 12 Sep 2026 08:34:44 +0200 Message-ID: <20260912065656.764247373@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065648.999753832@linuxfoundation.org> References: <20260912065648.999753832@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.2-stable review patch. If anyone has any objections, please let me know. ------------------ From: Laxman Acharya Padhya [ Upstream commit a9f950adfe2147318d75e7a6eab5e814851802ac ] If enabling tearing mode or exiting sleep mode fails after the regulator is enabled, s6d16d0_prepare() returns without asserting reset or disabling the supply. Since the DRM panel core leaves the panel unprepared, a later unprepare call skips the driver callback and the supply remains enabled. Assert reset and disable the supply before returning the DSI command error. Fixes: ac1d6d74884e ("drm/panel: Add driver for Samsung S6D16D0 panel") Assisted-by: Codex:gpt-5 Signed-off-by: Laxman Acharya Padhya Signed-off-by: Linus Walleij Link: https://patch.msgid.link/20260704070648.35249-1-acharyalaxman8848@gmail.com Signed-off-by: Sasha Levin --- drivers/gpu/drm/panel/panel-samsung-s6d16d0.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-samsung-s6d16d0.c b/drivers/gpu/drm/panel/panel-samsung-s6d16d0.c index 1b14aa4efe359..54a65abf7e890 100644 --- a/drivers/gpu/drm/panel/panel-samsung-s6d16d0.c +++ b/drivers/gpu/drm/panel/panel-samsung-s6d16d0.c @@ -88,16 +88,22 @@ static int s6d16d0_prepare(struct drm_panel *panel) MIPI_DSI_DCS_TEAR_MODE_VBLANK); if (ret) { dev_err(s6->dev, "failed to enable vblank TE (%d)\n", ret); - return ret; + goto err_power_off; } /* Exit sleep mode and power on */ ret = mipi_dsi_dcs_exit_sleep_mode(dsi); if (ret) { dev_err(s6->dev, "failed to exit sleep mode (%d)\n", ret); - return ret; + goto err_power_off; } return 0; + +err_power_off: + gpiod_set_value_cansleep(s6->reset_gpio, 1); + regulator_disable(s6->supply); + + return ret; } static int s6d16d0_enable(struct drm_panel *panel) -- 2.53.0