From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DF2A472777 for ; Sat, 12 Sep 2026 11:17:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789211835; cv=none; b=hIkemaeqRi8WXOQcHEdTQ0IBXYG0ny+JUp0Zh7eHYjrMWcDwPHPaJjYqlsOCnMHXjPkvrHkDNshBwRaiqefaDTtabaLrR+ZiXNXnOPgPTOKNGm2BvEvQGPDVxk/WMurx8YgbHyGC6YkAXKW/GhKLFceswGQbkNpG1vv5nuWVDDU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789211835; c=relaxed/simple; bh=2WENdPgB7lpLNjZRMAuj/V4QE7tNMiPN/kdZ1Yd6hZo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=G41ZfT/rkxeRUxmzMyhoe0CA2EbS/G/cNv8O29jINUOMr9bYceCVCw0VhkElFWJi/qnoPZ4HT551NNO+IbqsjWwVVtHrbFs8FQ6oYq3o82MJcluPRThfBf/zaIybAenO2KvH60QWnSsioCe2Tb9Cy51qPRgBL0HUmo2XJ598dHI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IuslKP7H; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IuslKP7H" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 592E21F00893; Sat, 12 Sep 2026 11:17:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789211834; bh=U3UfwldC0nTbqLbZrDm29Iory+9qNJwQK+E02g1nzgc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=IuslKP7HcYfFje3yfbj+0Pw11PH0anIMb4ZEsw7rk4qsN/eSr0yZ6U1iDyNaxmobR yyNEZ2nnccrgweDyZUVnQdNjPfGjYhs+fOBVAnqLDQBA+WarOrYXsxHFySY+w6Gi06 spvJPOZIj1XHmC9qKgdUvcXOwccDyZfW64h57vu3+kG5d/ckO9BDUXQRbvAHI+ef8c bOWujMuEQKRNuPf2CT1YUKIb43LXpALJtkCyy0BOFKv20FDSk//PUvhxKAaKIs/i8N /0BFbzqiB/3btWwNNfRq8ww7UBKAMK+2+0REGHTN653MsHYanT+vVyfqwLBsyjEDeK EOKT0PsHnjy3Q== From: Sasha Levin To: stable@vger.kernel.org Cc: Srinivasan Shanmugam , Dan Carpenter , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , Sasha Levin Subject: [PATCH 6.18.y 1/6] drm/amdgpu: Fix missing unwind in amdgpu_ib_schedule() error path Date: Sat, 12 Sep 2026 07:17:06 -0400 Message-ID: <20260912111711.2285466-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026090943-snugness-plexiglas-e964@gregkh> References: <2026090943-snugness-plexiglas-e964@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Srinivasan Shanmugam [ Upstream commit ba038065655c45728be346d0b174a6da08d8a5c5 ] amdgpu_ib_schedule() returns early after calling amdgpu_ring_undo(). This skips the common free_fence cleanup path. Other error paths were already changed to use goto free_fence, but this one was missed. Change the early return to goto free_fence so all error paths clean up the same way. Fixes the below: drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c:232 amdgpu_ib_schedule() warn: missing unwind goto? drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c 124 int amdgpu_ib_schedule(struct amdgpu_ring *ring, unsigned int num_ibs, 125 struct amdgpu_ib *ibs, struct amdgpu_job *job, 126 struct dma_fence **f) 127 { ... 224 225 if (ring->funcs->insert_start) 226 ring->funcs->insert_start(ring); 227 228 if (job) { 229 r = amdgpu_vm_flush(ring, job, need_pipe_sync); 230 if (r) { 231 amdgpu_ring_undo(ring); --> 232 return r; The patch changed the other error paths to goto free_fence but this one was accidentally skipped. 233 } 234 } 235 236 amdgpu_ring_ib_begin(ring); ... 338 339 free_fence: 340 if (!job) 341 kfree(af); 342 return r; 343 } Fixes: f903b85ed0f1 ("drm/amdgpu: fix possible fence leaks from job structure") Reported-by: Dan Carpenter Cc: Alex Deucher Cc: Christian König Signed-off-by: Srinivasan Shanmugam Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher Stable-dep-of: 6760f5cb12d2 ("drm/amdgpu: avoid force-completing uninitialized UVD rings") Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c index 9581643dbb726..f0ba6ac431632 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c @@ -222,7 +222,7 @@ int amdgpu_ib_schedule(struct amdgpu_ring *ring, unsigned int num_ibs, r = amdgpu_vm_flush(ring, job, need_pipe_sync); if (r) { amdgpu_ring_undo(ring); - return r; + goto free_fence; } } -- 2.53.0