From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B62D47ECE8 for ; Mon, 14 Sep 2026 14:15:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789395355; cv=none; b=r/bQrRntDTw0mvTR4Nkti/8zslFKuzcU1dojulSt0sqW3j8j0uux2QuFaBUWf2AhTdUDLe4ICpr1o61AHYo4ZqVjbnI/j35Ajv/rs8XXUlCJVwNBh8VHg8R/gpD2u/XNGqokzoRKsbJ7qzL6BZcJD9ZDjURCPcgbfczwsMcV+Ko= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789395355; c=relaxed/simple; bh=QG8rnCxwHhJuZjK998VmwRum0sXvcvu6gauLzaznHIY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pzQtdqiuOreELdQa/1K5sWlbWfTUu45paOPKl3WVWOhnojw+cAjjQ47n6OXaxzfqBAzLQhBDl0m4cmavuTHt2PscMrAd2ebmxiQd90wd+NB6UC2eUn3tRdv8SuBYf4OKegVsYYI0leTiE1ck6IJGozrq4Xzve/T21aw4O05APiU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LB2dJ+9F; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LB2dJ+9F" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 820141F00899; Mon, 14 Sep 2026 14:15:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789395354; bh=vEYki6wT4itPdzc6uwqwhlTxXeVXIB7g44C6sadJE0k=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=LB2dJ+9Fyk2GZ+DCvqMEqEZtIP6eagkbWN7qF8tC1iXhHi/jIq1ljiwjtxgGy8aRL QlgccGYosUjo1Rc3g1tBdH0BX6P2YhKn6Bvc1G40NBaVBcKzaDBPGiIpNxehul6d0N /dn/jP1EwBMN13uDygQBhowzgNx1iNK+yznQN9QeJHR77HXL7joIvCmIozKvLeE8Vo B6xNtPLba+X5uGpeJBoek6N2EfneeLId2xoKev2UB57u1A4oiboa84KGzfJ5IB4Moh Uyy062rMBlS9zTURmVdAvreLm1lr9SNoNYsPtF4OunugME62FGa6MZwFWUzcdp7zzc SBVECijIOtt+A== From: Sasha Levin To: stable@vger.kernel.org Cc: Namjae Jeon , Kanishka De Silva , Farhad Alemi , Sasha Levin Subject: [PATCH 6.12.y 2/2] ksmbd: prevent out-of-bounds reads in share config responses Date: Mon, 14 Sep 2026 10:15:51 -0400 Message-ID: <20260914141551.61407-2-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260914141551.61407-1-sashal@kernel.org> References: <2026091411-perish-luster-7e07@gregkh> <20260914141551.61407-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Namjae Jeon [ Upstream commit f25e93768fcc5d8287e50b1ec52a42e4c276df34 ] Validate IPC share configuration payload sizes before consuming variable-length fields. Bound veto list parsing and account for the separator byte when deriving the path length. Fixes: a677ebd8ca2f ("ksmbd: validate payload size in ipc response") Reported-by: Kanishka De Silva Reported-by: Farhad Alemi Signed-off-by: Namjae Jeon Signed-off-by: Sasha Levin --- fs/smb/server/mgmt/share_config.c | 40 +++++++++++++++++++++---------- fs/smb/server/transport_ipc.c | 21 ++++++++++------ 2 files changed, 41 insertions(+), 20 deletions(-) diff --git a/fs/smb/server/mgmt/share_config.c b/fs/smb/server/mgmt/share_config.c index 97b0bbd619979..e34e86cce0fc3 100644 --- a/fs/smb/server/mgmt/share_config.c +++ b/fs/smb/server/mgmt/share_config.c @@ -88,9 +88,9 @@ static struct ksmbd_share_config *__share_lookup(const char *name) static int parse_veto_list(struct ksmbd_share_config *share, char *veto_list, - int veto_list_sz) + size_t veto_list_sz) { - int sz = 0; + size_t sz; if (!veto_list_sz) return 0; @@ -98,7 +98,7 @@ static int parse_veto_list(struct ksmbd_share_config *share, while (veto_list_sz > 0) { struct ksmbd_veto_pattern *p; - sz = strlen(veto_list); + sz = strnlen(veto_list, veto_list_sz); if (!sz) break; @@ -106,7 +106,7 @@ static int parse_veto_list(struct ksmbd_share_config *share, if (!p) return -ENOMEM; - p->pattern = kstrdup(veto_list, KSMBD_DEFAULT_GFP); + p->pattern = kstrndup(veto_list, sz, KSMBD_DEFAULT_GFP); if (!p->pattern) { kfree(p); return -ENOMEM; @@ -114,6 +114,9 @@ static int parse_veto_list(struct ksmbd_share_config *share, list_add(&p->list, &share->veto_list); + if (sz == veto_list_sz) + break; + veto_list += sz + 1; veto_list_sz -= (sz + 1); } @@ -165,17 +168,28 @@ static struct ksmbd_share_config *share_config_request(struct ksmbd_work *work, } if (!test_share_config_flag(share, KSMBD_SHARE_FLAG_PIPE)) { - int path_len = PATH_MAX; - - if (resp->payload_sz) - path_len = resp->payload_sz - resp->veto_list_sz; + size_t path_len; - share->path = kstrndup(ksmbd_share_config_path(resp), path_len, - KSMBD_DEFAULT_GFP); - if (!share->path) { - ret = -ENOMEM; + if (resp->payload_sz <= resp->veto_list_sz) { + ret = -EINVAL; } else { - ret = 0; + path_len = resp->payload_sz - resp->veto_list_sz; + if (resp->veto_list_sz) + path_len--; + + if (!path_len) { + ret = -EINVAL; + } else { + share->path = kstrndup( + ksmbd_share_config_path(resp), + path_len, KSMBD_DEFAULT_GFP); + if (!share->path) + ret = -ENOMEM; + else + ret = 0; + } + } + if (share->path) { share->path_sz = strlen(share->path); while (share->path_sz > 1 && share->path[share->path_sz - 1] == '/') diff --git a/fs/smb/server/transport_ipc.c b/fs/smb/server/transport_ipc.c index a0b9b3def3346..10847d1cda4ac 100644 --- a/fs/smb/server/transport_ipc.c +++ b/fs/smb/server/transport_ipc.c @@ -524,14 +524,21 @@ static int ipc_validate_msg(struct ipc_msg_table_entry *entry) if (entry->msg_sz < sizeof(struct ksmbd_share_config_response)) return -EINVAL; - if (resp->payload_sz) { - if (resp->payload_sz < resp->veto_list_sz) - return -EINVAL; + if (strnlen(resp->share_name, sizeof(resp->share_name)) == + sizeof(resp->share_name)) + return -EINVAL; - if (check_add_overflow(sizeof(struct ksmbd_share_config_response), - resp->payload_sz, &msg_sz)) - return -EINVAL; - } + if (resp->veto_list_sz > resp->payload_sz) + return -EINVAL; + + if (resp->flags != KSMBD_SHARE_FLAG_INVALID && + !(resp->flags & KSMBD_SHARE_FLAG_PIPE) && + resp->payload_sz <= resp->veto_list_sz) + return -EINVAL; + + if (check_add_overflow(sizeof(struct ksmbd_share_config_response), + resp->payload_sz, &msg_sz)) + return -EINVAL; break; } case KSMBD_EVENT_LOGIN_REQUEST_EXT: -- 2.53.0