From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pz2-f12.google.com (mail-pz2-f12.google.com [74.125.228.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A25F2481AB7 for ; Mon, 14 Sep 2026 14:55:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789397715; cv=none; b=H1DC+xm6G7qhcHztybU5FZEatn67tGeyvQm4bUW4IzgoeF9DU8cXHEkb6eQmsTUo5FsZyoTftHbRZ1za/0trTBq381vdJk4LUghnsAgvKs+hb/rAa+1XXw3Qr4yyw9azFnDGfkU6r4Ecveef+iWIXlLgeqW/2wWALoFGXj4ihzI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789397715; c=relaxed/simple; bh=7RPJv7BhuOaAk+Mo0IOhmSNSIZQ5l94dLDpG1fs2pa0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=l8QFzxTjatb6SbfdceSfEpn28F34Lod/Pqr1qWGsbUnA/swnjODoXSpgfboI3LjAGl2rhzyHnO3Urf+sgUvh5hNQYgcn7LsRE05LFJWAIoMkk2KjGLID1W2LGTtXxU1U2tAu4cao9O2i18Nb56Z53FGO+Ijr52QRgITjZfIM7EQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=V5k7ZkI1; arc=none smtp.client-ip=74.125.228.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="V5k7ZkI1" Received: by mail-pz2-f12.google.com with SMTP id d2e1a72fcca58-85469b2e1d7so1720539b3a.0 for ; Mon, 14 Sep 2026 07:55:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789397713; x=1790002513; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=mmvklgvi0ef/+u5dzaWwSRR1qwVq3sDKvk1AzDRlDKI=; b=V5k7ZkI1exdUJwB0QQ1Mamh3QBtnjzpKGTJWi1tE8mRHrgf/KWYsJLBixMnJrWNjZT Ewa3m5PzP4hbPv06vOMq8W40FPR7j79Dy5gZS1VBshz7PLzuGIn+OgEGVwRHeO3G6SDe edAYhvqxbrsQXK5huw9QNASL/kmuYBRovLFoeEDVG4fjwtpYV+jtnJUExz8uFWT6RM3/ B3BC3R5WH1jlDteHRv4l8lOT97RQ4xopf4OJD2zOWNBEkn2UR2jnH9X3K0Z3QnJnEsz9 4pKCFbyWx9EaNaKgXdguJHVYLFjJVAMihpJodGgHipRp+tC6NGuYSfpNGofuDT6XSuIe Z0Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789397713; x=1790002513; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=mmvklgvi0ef/+u5dzaWwSRR1qwVq3sDKvk1AzDRlDKI=; b=fVJuGyghlapklEx/MorclGlmG4QdAz/RRQm1OQSimW0+lHBLRuv7YwE388QlgSh7uf skCQOz7KUiBAnC2GoEI0AtNDgeA/193Rckz4M0u4D7e+EnwnbF6fb8t82RAXrPVemIai t4BKi7AnRelQdvKyoto5/S7jvrtlwDHTlPlFwZnfmDqZqP68aP/tXZBui0P9+0cXh1ID 7LDpZND9LL3cBXiURK6yzP4iqpk/PI/3RFwUkS6EeWw48FB95zv7qWshNWdLvmTO5TQy 0Wu8OIQRSygagmXz8rAKOoW6g6QdswdS6aR4MU89Y73xsEzhXcyAcGIhxXyi+OmhE15/ n1YQ== X-Forwarded-Encrypted: i=1; AKwUvBwrYhpX7LENuqu35XflD9GjziJOns2xXg6UQekhmZ1PXmxDq7OuQX9G59bfKQhav3C9N0mkXm8=@vger.kernel.org X-Gm-Message-State: AFuF++ldQ1VQBxuRJzd+0pYP1ZJD5/LPT9Bdq4+aJzz1GEVTH5OH+olZ dt4QDH8gnS4oY8CsENLN8T7IE4/hDFGTbt4MY3x6B1JdBm1gX1qhHKxe X-Gm-Gg: AYBFou3L/AdO8LP7zy7LgC3aYBeaWvb74vslISQVc55Shwi66piFCUZHU6QYavagylI lVHQGalqyb0L+EqGzNoM90GU6Ust17aP/jRALhAgJY3SAtjI+4P6Z+taqLfrVppFACUfBrplntC oR6r+TG54UB2iOg3Ifzj8uXM2ckzPTUYjbP/5pvtqd9UNtiFVw3Dxlwb1gBU+ULgklgogCR/qmE JhfzLqmpmjU257QaUALWnvJxej+xnyoASkIBgUUNy44vk+Ys2t6lZI+emeLsV5DCitzwqvDnUy1 FN25Yae8ac/RDsbtimvkchT+nGZs0epFWAFr0jdrzV6B1iInoXljhi0ulZQc8BZ9D1CclJXu1eu dt+39375hVEvU5CUQFIl8YMFuh0WT9xV7aK8XuzzIvqa3lZkzi6xPPosKHzX+KaXzfr4nyrkvlt qRJ1QJcOB8q3INLFbqD0PDGpwRBNgI/2+IZpIaCIzOuvyf9z4yz7zcWKpuETjV/Y4J+2cVyp8uK qIhCn+yWd0JJjwrbKOAUQFFFqtM+it/5CP6raA= X-Received: by 2002:a05:6a20:a105:b0:3d0:ba81:79b9 with SMTP id adf61e73a8af0-3db4052bebcmr5751503637.12.1789397712639; Mon, 14 Sep 2026 07:55:12 -0700 (PDT) Received: from KRHW1CJW23.bytedance.net ([139.177.225.247]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cc4c615a65bsm5338805a12.3.2026.09.14.07.55.09 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 14 Sep 2026 07:55:12 -0700 (PDT) From: Zhao Li To: Miri Korenblit Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH 2/3] wifi: iwlwifi: mld: defer freeing PTK PN state on key failure Date: Mon, 14 Sep 2026 22:54:32 +0800 Message-ID: <20260914145433.42830-3-enderaoelyther@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260914145433.42830-1-enderaoelyther@gmail.com> References: <20260914145433.42830-1-enderaoelyther@gmail.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The PTK packet-number state is published to RCU readers before the key is installed in firmware. If firmware rejects the key, the error path clears the pointer and immediately frees the state while an RX reader may still hold it. Defer the free until after an RCU grace period, matching the normal key removal path. Fixes: d1e879ec600f ("wifi: iwlwifi: add iwlmld sub-driver") Cc: stable@vger.kernel.org Assisted-by: Codex:gpt-6-astra Signed-off-by: Zhao Li --- drivers/net/wireless/intel/iwlwifi/mld/mac80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mld/mac80211.c b/drivers/net/wireless/intel/iwlwifi/mld/mac80211.c index 3a4c8fda68d0..693f2092a781 100644 --- a/drivers/net/wireless/intel/iwlwifi/mld/mac80211.c +++ b/drivers/net/wireless/intel/iwlwifi/mld/mac80211.c @@ -2265,7 +2265,7 @@ static int iwl_mld_set_key_add(struct iwl_mld *mld, if (ret) { if (ptk_pn) { RCU_INIT_POINTER(mld_sta->ptk_pn[keyidx], NULL); - kfree(ptk_pn); + kfree_rcu(ptk_pn, rcu_head); } return -EOPNOTSUPP; -- 2.55.0