From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 822324CEE6D for ; Wed, 16 Sep 2026 15:49:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789573776; cv=none; b=eQlxAB8syxn0YtmqipysaB4LD1d3m0qdkqBO23f6y1O8Wxrk6lHXsQ4maxo/CsJzxSgj1TyfRTIGR/R8G0ntU2FGKA3tfO1NqP7wKXjNuGARpVxlIefYv4fG5aYmaAzS3W7QDYf+SfNwXq+Yhc+NCSt8jvKP29WAMJn5z30abHg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789573776; c=relaxed/simple; bh=OrSj4x9uEWMu4npb44d8CK0Ux7Gu699fAmtdS0ZU7I0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=obVhtUB4vlvlct0syIgiJQvlSC7Qsz9jBkJEVpwL/ySoIZtpgqYidehPi1N6KbYv4D/9UG5gu7IkSjaHhjx2Ju7Nmj/O4ifasKV5B+nuyayXloJ9ZSBOQJDz8b3Q96SI9aO7b7XOexsH/Lc/7jHuFoPjZanQ2GepWxGI8F1IYjQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=R85kPodr; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="R85kPodr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 983E81F00899; Wed, 16 Sep 2026 15:49:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789573769; bh=UbRASGlwqjAkv0Zo1YVWb1Yiv3zkfcbwnFRAUQAjZ5Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=R85kPodrTQQbImT+/olHCxfkGVfJ1Rq4moXEhPHTN886Zz8m3SuR28mZUYxG0EGom 8GWCzuY0j5tj8FXrx/eH11625bDemhv3kNxfB22NseGwGPCb2ahy+kUopTMb/pt/7k KhR7GHwc1HBMZJFJVv2O1jWXZDubTVO+agg60k5h5ZV/paNFEftaDnQe9LEW6HYaN5 INxfH4TwCmkdQb46CeZ+xhr3yLt46lJ49SjNGnboQGdW1+y6SXbd01wZkwuKzXMzLb m9LTCkx2Xmr9oVa9MovBAHLYr9kDsasRsM3vGO2WXwC6ssvIzMyDq3xVJiI0Qn2mRp fDNNLCr2t6uHw== From: Sasha Levin To: stable@vger.kernel.org Cc: Tristan Madani , Takashi Iwai , Sasha Levin Subject: [PATCH 6.6.y 3/3] ALSA: usbusx2y: validate URB actual_length in interrupt callback Date: Wed, 16 Sep 2026 11:49:25 -0400 Message-ID: <20260916154925.4171104-3-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260916154925.4171104-1-sashal@kernel.org> References: <2026091645-humorist-crown-6882@gregkh> <20260916154925.4171104-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Tristan Madani [ Upstream commit 8f5ef203abda9dd36b2af473c7b737d544f807bd ] i_usx2y_in04_int() processes the interrupt URB data without checking urb->actual_length. A short transfer from a malfunctioning device would cause the handler to process uninitialized heap data from the kmalloc-allocated in04_buf, which is then copied to the mmap-accessible ctl_snapshot[] array. Fix by using kzalloc() for in04_buf to zero-initialize the buffer, and adding an actual_length check to skip processing on short transfers while still resubmitting the URB. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable@vger.kernel.org Signed-off-by: Tristan Madani Link: https://patch.msgid.link/20260904205826.4071119-2-tristmd@gmail.com Signed-off-by: Takashi Iwai Signed-off-by: Sasha Levin --- sound/usb/usx2y/usbusx2y.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/sound/usb/usx2y/usbusx2y.c b/sound/usb/usx2y/usbusx2y.c index 5aa373d1edab1..d1e907dc773c1 100644 --- a/sound/usb/usx2y/usbusx2y.c +++ b/sound/usb/usx2y/usbusx2y.c @@ -189,6 +189,9 @@ static void i_usx2y_in04_int(struct urb *urb) return; } + if (urb->actual_length < USX2Y_IN04_SIZE) + goto resubmit; + if (us428ctls) { diff = -1; if (us428ctls->ctl_snapshot_last == -2) { @@ -246,6 +249,7 @@ static void i_usx2y_in04_int(struct urb *urb) if (err) dev_err(&urb->dev->dev, "in04_int() usb_submit_urb err=%i\n", err); +resubmit: urb->dev = usx2y->dev; usb_submit_urb(urb, GFP_ATOMIC); } @@ -298,7 +302,7 @@ int usx2y_in04_init(struct usx2ydev *usx2y) goto error; } - usx2y->in04_buf = kmalloc(USX2Y_IN04_SIZE, GFP_KERNEL); + usx2y->in04_buf = kzalloc(USX2Y_IN04_SIZE, GFP_KERNEL); if (!usx2y->in04_buf) { err = -ENOMEM; goto error; -- 2.53.0