From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2EB04CEE73 for ; Wed, 16 Sep 2026 15:56:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789574189; cv=none; b=R49TJghEoNoXi6IlwdE4wysF0fF5jX6O3PDe8QT1SW9lnT0csiPTAhVT4Qn9sQ7LTS7hpmoN7w5HsB3EP4pjQtPgM2tCzp3tiEJbFZZIZedkDcAqrlKl4NVq6dMt2bSn+7t0zkZWexx97CYN9gOD/K8MLeXCM4FO402+EWMlBxA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789574189; c=relaxed/simple; bh=dIIo7Tyuw+HEOraTjk/fVI83zjXs81HMEGtUun9HudY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=S7fFEEnOZ/3aEt+zRsPQZMalIzwGhgspZXws/X9Ga0drIhDtVAgx++ocKwlAzaGgfEca4WCuUs/+dKb8LrpBeskGZ35p5vGuZC1MgXVDTUSD/8UH71yS23/g5XqHJB16R64Fw6t2yXorTtNyxmeM0muqLfTUxULqeoQYuUzaSAE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JLH+z5cz; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JLH+z5cz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 45F4D1F0089C; Wed, 16 Sep 2026 15:56:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789574176; bh=0jMWKkgLXmDrOGL5hKmzbCAwoXgHHvrqRf9rR9D0JQQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=JLH+z5czX6H37eUnKeYTKaVc9U7UxcnVvSkY6/pXR3S4lBJG/wAss5t5wnPjREZhy H8CE3uyl4/LRAB2OuykkhB4vxVjJTdM5wyl3XvhhnTbDiAvgi48KqlkZv9mOcPpp2k 5jiiWSkOVnL1VF/Glmssq5hmODnLgixtCqI3ZBJUPMvzVag7u/2gcNicbnN5dGMXd5 uEIVOZfR1p6qIUUGFeFWw8EINGIiQxwuoQBZ6YjaNFfs95PKsh3tSFusdQMv6uQqha b9sD8Fe+z+y1Yf+GNeRB4Psj2otg0xL3iXQyxV6wDBpkQpBm5c1VPegWHuSauVtn7i sRUDARHk14ccw== From: Sasha Levin To: stable@vger.kernel.org Cc: Vasileios Almpanis , syzbot+6b16e3d085833cbf3e25@syzkaller.appspotmail.com, Breno Leitao , Sasha Levin Subject: [PATCH 6.1.y] configfs: unhash the dentry before dropping the item in rmdir Date: Wed, 16 Sep 2026 11:56:14 -0400 Message-ID: <20260916155614.10317-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026091658-data-urchin-e973@gregkh> References: <2026091658-data-urchin-e973@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Vasileios Almpanis [ Upstream commit f06c2d26d1999d37e93299db0ecead04ca7d0b9f ] configfs_get_config_item() treats a hashed dentry as proof that sd->s_element is a live config_item. configfs_rmdir() breaks that: simple_rmdir() leaves the dentry hashed, the last reference to the item is dropped right after, and the dentry is only unhashed by d_delete() once ->rmdir() has returned. configfs_symlink() resolves its target holding no lock on it, so get_target() can land in that window: BUG: KASAN: slab-use-after-free in config_item_get+0x26/0x90 get_target fs/configfs/symlink.c:128 [inline] configfs_symlink+0x4ab/0x1030 fs/configfs/symlink.c:185 Unhash in configfs_remove_dir(), while the item is still guaranteed to be there. A reference obtained just before that stays harmless, as create_link() rechecks CONFIGFS_USET_DROPPING, already set by configfs_detach_prep(). Both configfs_unregister_subsystem() paths d_drop() after detaching, so this only makes rmdir match them. Reported-by: syzbot+6b16e3d085833cbf3e25@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=6b16e3d085833cbf3e25 Fixes: 7063fbf22611 ("[PATCH] configfs: User-driven configuration filesystem") Cc: stable@vger.kernel.org Signed-off-by: Vasileios Almpanis Tested-by: Breno Leitao Reviewed-by: Breno Leitao Link: https://patch.msgid.link/20260730093435.195441-3-vasilisalmpanis@gmail.com Signed-off-by: Breno Leitao [ adapted the configfs_remove_dir() change to the older remove_dir() helper. ] Signed-off-by: Sasha Levin --- fs/configfs/dir.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/fs/configfs/dir.c b/fs/configfs/dir.c index 01c9d54833b30..6269085ba1748 100644 --- a/fs/configfs/dir.c +++ b/fs/configfs/dir.c @@ -395,8 +395,17 @@ static void remove_dir(struct dentry * d) configfs_remove_dirent(d); - if (d_really_is_positive(d)) - simple_rmdir(d_inode(parent),d); + if (d_really_is_positive(d)) { + if (!simple_rmdir(d_inode(parent), d)) + /* + * configfs_get_config_item() takes a hashed dentry as + * proof that ->s_element is still alive. Our caller + * is about to drop the last reference to the item and + * the VFS will not unhash until after we return, so + * unhash it here. + */ + d_drop(d); + } pr_debug(" o %pd removing done (%d)\n", d, d_count(d)); -- 2.53.0