From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 432F94D7976 for ; Wed, 16 Sep 2026 19:38:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789587538; cv=none; b=QkNJBwB3w2ZD1PJdcTlcvuRO2ybLqefl1t+dGu3OspWdoAfuD9XST/f/nZDbZI7nieTZViZTYWjQLkiQLyWg/dw/jGS59r9wqQJ+Hiu2kC8kGOS97JymHFbbmzXz6kkOHXqlWnDD7uLMDFii24LQm3Zuan3PuY9YWvaXTal6V7E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789587538; c=relaxed/simple; bh=ilw1SB6la13Ug3youe8i2CB50w62E/CBmKDv+j7CDhA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eO0B+PWhbMAX438fuVUol6tmkuEEODZCtIFmdeJa5FQrB9nPtBH9/bo/W20ob6a+bTK8JptYEdmBX7ftD8XLpBMHs2HExg5oeqbhEx1nPQFfHvCKileHFiiA2cVcqMRXZiBdr3InJhgOIm9r7UZ50WrWJ1h/XTvr7kx9M8YDWdc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aCBDgu0T; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aCBDgu0T" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB7F51F00898; Wed, 16 Sep 2026 19:38:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789587512; bh=wf4ouioXFJVicOtBIVKJjmi5ayrItmQ251SIiyh9b2E=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=aCBDgu0TgneDIKo9P/ItCCoESCJXAW22jXKzDjJPVivaM0P+jke9MPkb+4O9q22R+ HL+aRbXZbee0ZApDvp+SzbIti1lCF+fDRVF8yCCEgprniDZFIbNXXdx8EaG8KiYV9S BRGnEQGdkgbgu2VaKgDqO/PbNWiKxRw8D2u2GhQtYEcUphxA+OGtrEdxKmRb4ZV92f XytUsuX1xDoXshDEcOf/YLHEoyIVmns7jtqznS7MiVjDZg/LVkmcUonWnZFef4lIx1 GxVGKskj1ECUouA2HcOF7/AQQuoMwRZrK306zg1x8yIZwYKlRZFhewwv+lD08PhqpP HYYUt0IA8IJKA== From: Sasha Levin To: stable@vger.kernel.org Cc: Xu Rao , Bartosz Golaszewski , Dmitry Baryshkov , Luiz Augusto von Dentz , Sasha Levin Subject: [PATCH 5.15.y 2/2] Bluetooth: btqcomsmd: destroy RPMsg endpoints before freeing hci_dev Date: Wed, 16 Sep 2026 15:38:29 -0400 Message-ID: <20260916193829.2327507-2-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260916193829.2327507-1-sashal@kernel.org> References: <2026091652-sanding-chuck-ede3@gregkh> <20260916193829.2327507-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Xu Rao [ Upstream commit f5a427b16e45210dee656b0860728f3d496dee85 ] The command and ACL RPMsg endpoints store struct btqcomsmd as their callback private data. The receive callbacks dereference btq->hdev without taking an hci_dev reference. The current teardown order frees the hci_dev before destroying the RPMsg endpoints in both the hci_register_dev() error path and the driver remove path. If WCNSS delivers data in that window, the endpoint callback can run with an already freed hci_dev and pass it to the Bluetooth core. For qcom_smd endpoints, rpmsg_destroy_ept() closes the channel and clears the callback under the channel recv_lock. The receive path holds the same lock while invoking the callback, so destroying the endpoints first both prevents new callbacks and serializes with any callback already running. Destroy the command and ACL endpoints before hci_free_dev(). Keep hci_unregister_dev() first during remove so the HCI core stops issuing operations before the transport endpoints are shut down. In the full registration-error cleanup path, return directly after freeing the hci_dev to avoid falling through to the partial-construction labels and destroying the endpoints twice. Fixes: 5052de8deff5 ("soc: qcom: smd: Transition client drivers from smd to rpmsg") Fixes: 9a39a927be01 ("Bluetooth: btqcomsmd: Fix a resource leak in error handling paths in the probe function") Cc: stable@vger.kernel.org Acked-by: Bartosz Golaszewski Reviewed-by: Dmitry Baryshkov Signed-off-by: Xu Rao Signed-off-by: Luiz Augusto von Dentz Signed-off-by: Sasha Levin --- drivers/bluetooth/btqcomsmd.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/bluetooth/btqcomsmd.c b/drivers/bluetooth/btqcomsmd.c index 88dbb2f3fabf9..4ce8354ebb86b 100644 --- a/drivers/bluetooth/btqcomsmd.c +++ b/drivers/bluetooth/btqcomsmd.c @@ -188,7 +188,10 @@ static int btqcomsmd_probe(struct platform_device *pdev) return 0; hci_free_dev: + rpmsg_destroy_ept(btq->cmd_channel); + rpmsg_destroy_ept(btq->acl_channel); hci_free_dev(hdev); + return ret; destroy_cmd_channel: rpmsg_destroy_ept(btq->cmd_channel); destroy_acl_channel: @@ -202,10 +205,11 @@ static void btqcomsmd_remove(struct platform_device *pdev) struct btqcomsmd *btq = platform_get_drvdata(pdev); hci_unregister_dev(btq->hdev); - hci_free_dev(btq->hdev); rpmsg_destroy_ept(btq->cmd_channel); rpmsg_destroy_ept(btq->acl_channel); + + hci_free_dev(btq->hdev); } static const struct of_device_id btqcomsmd_of_match[] = { -- 2.53.0