From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE31B429013 for ; Wed, 16 Sep 2026 19:43:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789587834; cv=none; b=AGWFpbUBCYaWy0TITS7W0okLNHpolxxar76DPi6nKNTT9WpU4JLT4dTjsLSN8URVEkV/IuurUlAQz3TjVz3XzoWuQPrFRmIThCscFe/4QXznTx+iAuhdnegKsf4fexsN7B0pQrWoqfx7oQbRsYcFldDxa0x5pHyLcjXDiAqV/Cc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789587834; c=relaxed/simple; bh=ukKlixbK8i1oSsfy0rRA/GGvpCGLl8xI5iCNOOQ4BB8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JWoJYK6QZ1tocwuWJrGWFTnTcHm4XRGvS+uhunOj7yT22e56MNtudlbv+ek+2NMitNk6qP3Vjq44/SY6QI8499wrzLhW/FT6ZnrWbDRkDg6gmpeVTgFlta4rK10eILRAQU73Nn5hozPaqkVO1Hr21GLeVEBAp8j/bkLSdBS52xE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NpOMR36k; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NpOMR36k" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1D2661F00893; Wed, 16 Sep 2026 19:43:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789587818; bh=jDG7f1M9mBD8THKpIMep1g3spVu+xIuV5zrgmhr8M+k=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=NpOMR36kkRV6R+Y2XMhzTttb+Qa4xdqemLVK4ZIHjMzM2xsE8PH9IkCZuLq5Q3nAT CVOo54IQ3KcU74Bx21IUtI0YnMBwIt9jJWvAHjZ/RUlXtZL/C+9WxyTqHISiPv35kS UGX5h6veCQRGa7EJupeIbF2aaqdLceLvasuQeougmQrW8BmNVk9cSiKLYuBtyDavZg 7l9fIIv5TnhqKwcDN5s8hcbXAw1qhzkEQlYtoVjwS5jOkTA9gsNpfvX/lRdOgO3OMx /JALwyQlvVoxjeiyRL3JiS4Qehhrj89cQXGnnhAyj8VFqKcu7qNRJ8cERA2TJOAYuW 8/tP6CRdQcL1A== From: Sasha Levin To: stable@vger.kernel.org Cc: Dinh Nguyen , "Borislav Petkov (AMD)" , Sasha Levin Subject: [PATCH 6.6.y 2/2] EDAC/altera: Use parent device for devres in altr_portb_setup() Date: Wed, 16 Sep 2026 15:43:35 -0400 Message-ID: <20260916194335.2394560-2-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260916194335.2394560-1-sashal@kernel.org> References: <2026091620-hardwired-diffusive-ffa1@gregkh> <20260916194335.2394560-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Dinh Nguyen [ Upstream commit 9868f5c077dfe0b606331f2e782484f91a5789a5 ] Anchor the devres group and the devm-managed IRQ requests in altr_portb_setup() to the actual parent device (device->edac->dev) instead of the embedded struct device inside the copied per-port altr_edac_device_dev. This keeps devres_open_group(), devm_request_irq(), devres_remove_group() and devres_release_group() all referring to the same long-lived device so the group and the resources allocated inside it are torn down together. Fixes: 911049845d70 ("EDAC, altera: Add Arria10 SD-MMC EDAC support") Closes: https://sashiko.dev/#/patchset/20260503212558.2811480-1-dbgh9129%40gmail.com Assisted-by: LLM Signed-off-by: Dinh Nguyen Signed-off-by: Borislav Petkov (AMD) Cc: stable@vger.kernel.org Link: https://patch.msgid.link/20260617164303.585555-1-dinguyen@kernel.org Signed-off-by: Sasha Levin --- drivers/edac/altera_edac.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c index 9fe76f4fd0332..30a7e0110b762 100644 --- a/drivers/edac/altera_edac.c +++ b/drivers/edac/altera_edac.c @@ -1544,7 +1544,7 @@ static int altr_portb_setup(struct altr_edac_device_dev *device) altdev = dci->pvt_info; *altdev = *device; - if (!devres_open_group(&altdev->ddev, altr_portb_setup, GFP_KERNEL)) + if (!devres_open_group(device->edac->dev, altr_portb_setup, GFP_KERNEL)) return -ENOMEM; /* Update PortB specific values */ @@ -1572,7 +1572,7 @@ static int altr_portb_setup(struct altr_edac_device_dev *device) rc = -ENODEV; goto err_release_group_1; } - rc = devm_request_irq(&altdev->ddev, altdev->sb_irq, + rc = devm_request_irq(device->edac->dev, altdev->sb_irq, prv->ecc_irq_handler, IRQF_TRIGGER_HIGH, ecc_name, altdev); if (rc) { @@ -1594,7 +1594,7 @@ static int altr_portb_setup(struct altr_edac_device_dev *device) rc = -ENODEV; goto err_release_group_1; } - rc = devm_request_irq(&altdev->ddev, altdev->db_irq, + rc = devm_request_irq(device->edac->dev, altdev->db_irq, prv->ecc_irq_handler, IRQF_TRIGGER_HIGH, ecc_name, altdev); if (rc) { @@ -1614,13 +1614,13 @@ static int altr_portb_setup(struct altr_edac_device_dev *device) list_add(&altdev->next, &altdev->edac->a10_ecc_devices); - devres_remove_group(&altdev->ddev, altr_portb_setup); + devres_remove_group(device->edac->dev, altr_portb_setup); return 0; err_release_group_1: edac_device_free_ctl_info(dci); - devres_release_group(&altdev->ddev, altr_portb_setup); + devres_release_group(device->edac->dev, altr_portb_setup); edac_printk(KERN_ERR, EDAC_DEVICE, "%s:Error setting up EDAC device: %d\n", ecc_name, rc); return rc; -- 2.53.0