From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D2083A6B8F for ; Thu, 17 Sep 2026 03:16:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789615016; cv=none; b=mRqh3aFIHfFhgmMjqGJ8gKtTaB46oeZZjT0euuUT+qCkuQqRTgkT/CGstpyZIyEegtddy1hRZmDSRjNn8/RvRt+Hq+27CHnM/MSs0eSu2QVUQ5Mguz8AeAb19Hpx6wLCImBbXT/xxzlDYPWPnrv76AdoVgsHrgTMs10dynfwFWE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789615016; c=relaxed/simple; bh=A8ASdkpif5p6cT4ftVu7lFKhZaSAeBi2InR6BLNiDcQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=as/gs4+mbRxRa/TzQHYbw3gnc513tyOfrSrA5wfGgFNawFK3g1DRFrsC0kpcAqRKo2oKLx8On8sMK+p7pZQwV6/86ATPLg9cVS0CZL6GcnPWaJ8jGP603SolUggeerS+qjxLm0XQ+ZfIO1g7jDog3q/SyXnpIxENDJTWSLCUj6w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bZKaiD6i; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bZKaiD6i" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F41D11F00899; Thu, 17 Sep 2026 03:16:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789615005; bh=VSPdynL/x64XD+j9/oh8/V0go/iiggIekZGgpYpjKHg=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=bZKaiD6in0Lp0QJnex9tmpX62zOOldymjSohtOZj/g9QzGuJPBf+dmJOq97jNyp52 3edRkknwBPal+P/uhbTW2LIyltx6xQ6LLMwSb8plUrg7WdGqAUzMXrzZgx/pvz64Aw 588wc47RT5RXMJFhEq5yd5PlMnPhMqCnPOJG7RBVRVMPW8bsARS1hMXt7oP79SIK0E L9faErgXR9tz77KKEq6RzZGdaUnpp8atGNCuJytLI9l8NYnO/imjxiahbJJFbeIL4L GMC/Ju4c5BjePtoaTCupkC5IykBWUK5c71jtCP+M2WsX2OIrU95AIQxFkf3lNVVdmE qfXYAXvwqlGew== From: Sasha Levin To: stable@vger.kernel.org Cc: Kalpan Jani , syzbot+55c2a5c871441261ed14@syzkaller.appspotmail.com, Tao Cui , "Matthieu Baerts (NGI0)" , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.12.y 3/3] mptcp: pm: kernel: drop pending ADD_ADDR when removing ID0 Date: Wed, 16 Sep 2026 23:16:42 -0400 Message-ID: <20260917031642.3978029-3-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260917031642.3978029-1-sashal@kernel.org> References: <2026091602-garbage-gumdrop-1752@gregkh> <20260917031642.3978029-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Kalpan Jani [ Upstream commit 2ac7d6e620764f1fc79eb4edd3610a7a661981ca ] The in-kernel MPTCP path manager can leave a stale ADD_ADDR announcement entry alive when removing the id 0 endpoint. This happens because the id 0 removal path does not tear down pending announcements, unlike the non-zero id path. When the PM later reselects id 0 after adding another signal endpoint, it finds the stale anno_list entry and hits WARN_ON_ONCE(mptcp_pm_is_kernel()) in mptcp_pm_announced_alloc(). Root cause: asymmetry between removal paths. - Non-zero id path: mptcp_nl_remove_subflow_and_signal_addr() calls mptcp_pm_remove_announced() to clean up. - Id 0 path: mptcp_nl_remove_id_zero_address() skips cleanup entirely. Fix by making the id 0 path symmetric: call mptcp_pm_announced_remove() and decrement add_addr_signaled before queuing the RM_ADDR. Subtle detail: signal endpoints are stored in anno_list with port 0, but msk_local carries the connection's local port. In other words, entries linked to ID0 paths should have port == 0. A follow-up patch will ensure that. mptcp_pm_announced_remove() uses use_port=true for comparison. So clear the port before the lookup. Fixes: 740d798e8767 ("mptcp: remove id 0 address") Cc: stable@vger.kernel.org Reported-by: syzbot+55c2a5c871441261ed14@syzkaller.appspotmail.com Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/620 Suggested-by: Tao Cui Signed-off-by: Kalpan Jani Reviewed-by: Matthieu Baerts (NGI0) Signed-off-by: Matthieu Baerts (NGI0) Link: https://patch.msgid.link/20260908-net-mptcp-misc-fixes-7-3-rc1-v2-4-df1de70348b6@kernel.org Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/mptcp/pm_kernel.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/net/mptcp/pm_kernel.c b/net/mptcp/pm_kernel.c index f8190fb5166ee..967f53781b9fc 100644 --- a/net/mptcp/pm_kernel.c +++ b/net/mptcp/pm_kernel.c @@ -1677,6 +1677,8 @@ static int mptcp_nl_remove_id_zero_address(struct net *net, while ((msk = mptcp_token_iter_next(net, &s_slot, &s_num)) != NULL) { struct sock *sk = (struct sock *)msk; struct mptcp_addr_info msk_local; + struct mptcp_addr_info anno_addr; + bool announced; if (list_empty(&msk->conn_list) || mptcp_pm_is_userspace(msk)) goto next; @@ -1686,7 +1688,13 @@ static int mptcp_nl_remove_id_zero_address(struct net *net, goto next; lock_sock(sk); + /* Drop a possibly pending ADD_ADDR for this address. */ + anno_addr = msk_local; + anno_addr.port = 0; + announced = mptcp_pm_announced_remove(msk, &anno_addr); spin_lock_bh(&msk->pm.lock); + if (announced) + msk->pm.add_addr_signaled--; mptcp_pm_remove_addr(msk, &list); mptcp_pm_rm_subflow(msk, &list); __mark_subflow_endp_available(msk, 0); -- 2.53.0