From: Greg KH <greg@kroah.com>
To: Sasha Levin <sashal@kernel.org>
Cc: stable@vger.kernel.org, Paulo Alcantara <pc@manguebit.org>,
Namjae Jeon <linkinjeon@kernel.org>,
Ronnie Sahlberg <ronniesahlberg@gmail.com>,
Shyam Prasad N <sprasad@microsoft.com>,
Tom Talpey <tom@talpey.com>, Bharath SM <bharathsm@microsoft.com>
Subject: Re: [PATCH 6.18.y 2/2] smb: client: fix WSL reparse point uid/gid override
Date: Thu, 17 Sep 2026 11:12:09 +0100 [thread overview]
Message-ID: <2026091705-rhyme-from-94da@gregkh> (raw)
In-Reply-To: <20260917041703.4190978-2-sashal@kernel.org>
On Thu, Sep 17, 2026 at 12:17:03AM -0400, Sasha Levin wrote:
> From: Paulo Alcantara <pc@manguebit.org>
>
> [ Upstream commit cd2b2b57921d4caa7875e83198bb2aa71254328b ]
>
> wsl_to_fattr() unconditionally overwrites cf_uid/cf_gid with values
> from WSL extended attributes ($LXUID/$LXGID), ignoring the forceuid
> and forcegid mount options.
>
> Fix this by initializing cf_uid/cf_gid to the mount defaults and
> gating the $LXUID/$LXGID EA parsing on forceuid/forcegid.
>
> Closes: https://sashiko.dev/#/patchset/20260906190803.667489-1-pc%40manguebit.org
> Reviewed-by: Namjae Jeon <linkinjeon@kernel.org>
> Signed-off-by: Paulo Alcantara <pc@manguebit.org>
> Cc: Ronnie Sahlberg <ronniesahlberg@gmail.com>
> Cc: Shyam Prasad N <sprasad@microsoft.com>
> Cc: Tom Talpey <tom@talpey.com>
> Cc: Bharath SM <bharathsm@microsoft.com>
> Cc: stable@vger.kernel.org
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---
> fs/smb/client/reparse.c | 16 +++++++++++-----
> 1 file changed, 11 insertions(+), 5 deletions(-)
>
> diff --git a/fs/smb/client/reparse.c b/fs/smb/client/reparse.c
> index 58bd67f32377f..383eb9bd45793 100644
> --- a/fs/smb/client/reparse.c
> +++ b/fs/smb/client/reparse.c
> @@ -1108,10 +1108,14 @@ static bool wsl_to_fattr(struct cifs_open_info_data *data,
> struct cifs_sb_info *cifs_sb,
> u32 tag, struct cifs_fattr *fattr)
> {
> + unsigned int sbflags = cifs_sb_flags(cifs_sb);
> struct smb2_file_full_ea_info *ea;
> bool have_xattr_dev = false;
> u32 next = 0;
>
> + fattr->cf_uid = cifs_sb->ctx->linux_uid;
> + fattr->cf_gid = cifs_sb->ctx->linux_gid;
> +
> switch (tag) {
> case IO_REPARSE_TAG_LX_SYMLINK:
> fattr->cf_mode |= S_IFLNK;
> @@ -1148,11 +1152,13 @@ static bool wsl_to_fattr(struct cifs_open_info_data *data,
> nlen = ea->ea_name_length;
> v = (void *)((u8 *)ea->ea_data + ea->ea_name_length + 1);
>
> - if (!strncmp(name, SMB2_WSL_XATTR_UID, nlen))
> - fattr->cf_uid = wsl_make_kuid(cifs_sb, v);
> - else if (!strncmp(name, SMB2_WSL_XATTR_GID, nlen))
> - fattr->cf_gid = wsl_make_kgid(cifs_sb, v);
> - else if (!strncmp(name, SMB2_WSL_XATTR_MODE, nlen)) {
> + if (!strncmp(name, SMB2_WSL_XATTR_UID, nlen)) {
> + if (!(sbflags & CIFS_MOUNT_OVERR_UID))
> + fattr->cf_uid = wsl_make_kuid(cifs_sb, v);
> + } else if (!strncmp(name, SMB2_WSL_XATTR_GID, nlen)) {
> + if (!(sbflags & CIFS_MOUNT_OVERR_GID))
> + fattr->cf_gid = wsl_make_kgid(cifs_sb, v);
> + } else if (!strncmp(name, SMB2_WSL_XATTR_MODE, nlen)) {
> /* File type in reparse point tag and in xattr mode must match. */
> if (S_DT(fattr->cf_mode) != S_DT(le32_to_cpu(*(__le32 *)v)))
> return false;
> --
> 2.53.0
>
>
Does not apply :(
prev parent reply other threads:[~2026-09-17 10:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 16:46 FAILED: patch "[PATCH] smb: client: fix WSL reparse point uid/gid override" failed to apply to 6.18-stable tree gregkh
2026-09-17 4:17 ` [PATCH 6.18.y 1/2] smb: client: use atomic_t for mnt_cifs_flags Sasha Levin
2026-09-17 4:17 ` [PATCH 6.18.y 2/2] smb: client: fix WSL reparse point uid/gid override Sasha Levin
2026-09-17 10:12 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026091705-rhyme-from-94da@gregkh \
--to=greg@kroah.com \
--cc=bharathsm@microsoft.com \
--cc=linkinjeon@kernel.org \
--cc=pc@manguebit.org \
--cc=ronniesahlberg@gmail.com \
--cc=sashal@kernel.org \
--cc=sprasad@microsoft.com \
--cc=stable@vger.kernel.org \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox