From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f43.google.com (mail-pj2-f43.google.com [74.125.227.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9607446853 for ; Tue, 22 Sep 2026 09:31:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790069493; cv=none; b=DOBdkzRrFO4QSuctt4L9UBvdORz8/VimgSeiR2ToLQ/hPJm22U0BjJU/jykb8H4RhGM+8Z193jIT04qtdLqCB0esWuRKy3+zDB9sIcFVw/TOVy+utsKOS0DhkFjMrgyH+VIPIsPLoRUVzCkONJPh4qTVjbZgzdzr8VYRAnM/DTg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790069493; c=relaxed/simple; bh=HsCTEwCejflIPGn6aDN5s1ankMoE3xb+l71/mPF9Rtk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=C8805OArXWeKkytbvpFWLpN/uK27nlqzv5kMW47dE7pv3RCmAGtHBUoW0kWfG20fOewBazS+qCCavlc4ze3nce5SwRUr9IhOOSJ/uU47ErJ0x6x/aSkREOsxgGVsPsgvXGgPUbV+2p6Smx5ZuOzead9BV3gW5pqFF6UolKx8ZzM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VFES/QKq; arc=none smtp.client-ip=74.125.227.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VFES/QKq" Received: by mail-pj2-f43.google.com with SMTP id d9443c01a7336-2d90ba1d807so47718255ad.3 for ; Tue, 22 Sep 2026 02:31:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790069489; x=1790674289; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=SSk/o6B7IWQ+VmqUZ/savpxYdtj5YDadYMQXYJCjXc8=; b=VFES/QKqFYMpjZFNWkcWcFi5dFQSjHZstd5TZflEVJwY76hQbTgE7ofQDLNCpM/Y8+ 6OJ0WgwxIVJTXSPS8zIdrABmQ6+BwtPj3hZIfv1HLIsZirihnuxmyAjcV85gff8qpqSB AO9AbLszt0Pyxids6NUgzAadi36hJhe3kspf1n1LIbpUe6gmudMP+A//W+oK/MiWa18r kaCTWCiWp1V3EVDFIUzy72CEO1fQHmAIbbDoWigjX1yQZxoiLwHQ89XuSxI77U+o59Ck vhd1jhZahCuMzwWMsImrdR6ZuCucFg1gVNaHJei9XSGI4S0+328KI4CRkejSDM20vdSk tZxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790069489; x=1790674289; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=SSk/o6B7IWQ+VmqUZ/savpxYdtj5YDadYMQXYJCjXc8=; b=bBigrtjCp7aBERBU/DtZd2fqp3IMvrqhvFwh6SuTL22Jh0dYQNw5864BCF+ixQkmuC IalVmvc/RrpP9l61r2KXfMU/7v6HZwCRAXSc1azCI/MCYyZb4HkKiNTTBqBoLQEgkSkG Z0ewpBkkDQkna1SMp5drt5LYOFldvYheqAHAbmWCAQ6jZT7Jk4xdapWvLXi0Juzlmgbc PD5bOxzjpC3hwEcrl4QeoCunqp/qhLjP8u9Vkn7hPLMRGZMCRXXD/AtkdgsOuHgz0lZl XXq0uVzQggM94LVe222fhGHkhGmPYj1KEDbHG2e6UWZYyRTddqIl47GwcMpYHjYunhwg kffg== X-Forwarded-Encrypted: i=1; AKwUvBw9LG2r/qQ0wx+yPSPqRsho4Tthkd3BwUs8blmMZii25aInPOul6SvCOT6qnpX/AJBdeioQKjI=@vger.kernel.org X-Gm-Message-State: AFuF++nQGs1Micw0rMS+1lzahorkVzUKuyHrEFJugBqgIhC3ldbETf10 t8jrwtJ34O2CwgHaOpA5JWQKY5sJCiOczJ39rO06try2AqJTBx2o20T9 X-Gm-Gg: AYBFou151d6PNsZrMJsk+d4tn6afAk/lXok7DI7545Sa27/9rmXbhiapZsuPiW1A9gK EauwFyK/EsoxzSnFMzPBNpgH5U0463xO4h/cBCldjgi1psbikBaix6fTS9RJHAkDF6A7/idxp12 47/f7DsPuADqqWCbMDF+uq5BKpDOYXd5GHGN/uHvp6CC5zrkVJBVARxrWMpobM5vDboIsbIb3Gr ieM80wjFWecUw17NnIAsVEuYMyXBsOwjXlVDABEalz8KlXdPWdW7xp7X+0vK0foWBDcFeE0sKnF nzMDdPFb7lMJH34BrrP2Mwf5nHBlyjVMq/On2JLdYmirvjBknGIHSfVECrrjyUDQJ2upN3O9g+Z odhfeCimjTIq9nLYYaQQ0gkjlcxmUDigirkUCd4SjY+ZpcajFRPenwo2gAQDX5nBkUzd7Nf178g 9N/2c3WzpJfhTuR5F9RoeU7w/tLgd9GC++Byj0ISMqM7IpAy9ULy4mFG/aR/Nv7hZOoi9QcLFwW RP5eANDDAtW0YAmJtjo2z9Ia4XwFAz1M3h9xbFPvw8HS7U/OgYUJitNswWTwKnorvec5P1v1FnD LMyN1KPgtlZmDMRzC8yI X-Received: by 2002:a17:903:3c4d:b0:2dd:88b4:6920 with SMTP id d9443c01a7336-2df609d2351mr6599915ad.22.1790069489351; Tue, 22 Sep 2026 02:31:29 -0700 (PDT) Received: from phui-2.c.googlers.com.com (78.123.83.34.bc.googleusercontent.com. [34.83.123.78]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2df63a22f54sm103915ad.61.2026.09.22.02.31.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Sep 2026 02:31:29 -0700 (PDT) From: Hui Peng To: Harry Morris , Alexander Aring , Miquel Raynal , Stefan Schmidt Cc: Hui Peng , David Laight , linux-wpan@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH net v3 3/3] ieee802154: ca8210: validate data_ind length upfront in ca8210_skb_rx() Date: Tue, 22 Sep 2026 09:30:25 +0000 Message-ID: <20260922093126.141969-4-benquike@gmail.com> X-Mailer: git-send-email 2.55.0.1082.g2b9226bbc0-goog In-Reply-To: <20260922093126.141969-1-benquike@gmail.com> References: <20260922093126.141969-1-benquike@gmail.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In ca8210_skb_rx(), data_ind is read at offsets 22 (msdulen), 23 (mpdulinkquality), 29 + msdulen (hdr.sec.level), 30..39 + msdulen (security header), and 29 .. 29 + msdulen (payload) without verifying that the received SPI frame length len covers those offsets, causing an out-of-bounds read when msdulen exceeds len - 30: BUG: KASAN: slab-out-of-bounds in ca8210_skb_rx.constprop.0.isra.0+0x137/0x160 Read of size 64 at addr ffff888006453ddd by task init/1 Call Trace: dump_stack_lvl+0x70/0xa0 print_report+0x153/0x4c6 kasan_report+0xf1/0x120 kasan_check_range+0x125/0x200 __asan_memcpy+0x23/0x60 ca8210_skb_rx.constprop.0.isra.0+0x137/0x160 ca8210_net_rx+0x96/0xc0 ... The buggy address belongs to the object at ffff888006453dc0 which belongs to the cache kmalloc-32 of size 32 The buggy address is located 29 bytes inside of allocated 32-byte region [ffff888006453dc0, ffff888006453de0) Consolidate all length and msdulen validations into a single upfront check at the beginning of ca8210_skb_rx() before allocating the skb. Tested in QEMU with KASAN enabled by passing a short data_ind buffer with msdulen = 64 and len = 30 into ca8210_skb_rx(). Fixes: ded845a781a5 ("ieee802154: Add CA8210 IEEE 802.15.4 device driver") Cc: stable@vger.kernel.org Assisted-by: LLM Signed-off-by: Hui Peng --- Changes in v3: - No changes. Changes in v2: - Split out as patch 3/3. - Consolidated all length checks in ca8210_skb_rx() into a single place at the beginning of the function before dev_alloc_skb() and dropped the unrelated hdr.seq assignment as requested by Miquel Raynal. drivers/net/ieee802154/ca8210.c | 32 ++++++++++++++++++++++---------- 1 file changed, 22 insertions(+), 10 deletions(-) diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c index 8aa7ffe..ab245ad 100644 --- a/drivers/net/ieee802154/ca8210.c +++ b/drivers/net/ieee802154/ca8210.c @@ -1758,19 +1758,15 @@ static int ca8210_skb_rx( u8 *data_ind ) { - struct ieee802154_hdr hdr; + struct ieee802154_hdr hdr = { }; int msdulen; int hlen; - u8 mpdulinkquality = data_ind[23]; + u8 mpdulinkquality; struct sk_buff *skb; struct ca8210_priv *priv = hw->priv; - /* Allocate mtu size buffer for every rx packet */ - skb = dev_alloc_skb(IEEE802154_MTU + sizeof(hdr)); - if (!skb) - return -ENOMEM; - - skb_reserve(skb, sizeof(hdr)); + if (len < 30) + return -EMSGSIZE; msdulen = data_ind[22]; /* msdu_length */ if (msdulen > IEEE802154_MTU) { @@ -1778,9 +1774,25 @@ static int ca8210_skb_rx( &priv->spi->dev, "received erroneously large msdu length!\n" ); - kfree_skb(skb); return -EMSGSIZE; } + + if (len < 30 + msdulen || + (!priv->promiscuous && data_ind[29 + msdulen] > 0 && + len < 29 + msdulen + sizeof(struct secspec))) { + dev_err(&priv->spi->dev, + "received truncated data indication!\n"); + return -EMSGSIZE; + } + + mpdulinkquality = data_ind[23]; + + /* Allocate mtu size buffer for every rx packet */ + skb = dev_alloc_skb(IEEE802154_MTU + sizeof(hdr)); + if (!skb) + return -ENOMEM; + + skb_reserve(skb, sizeof(hdr)); dev_dbg(&priv->spi->dev, "skb buffer length = %d\n", msdulen); if (priv->promiscuous) -- 2.49.0