From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f12.google.com (mail-pj2-f12.google.com [74.125.227.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D1293A1687 for ; Sun, 27 Sep 2026 04:11:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.140 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790482315; cv=none; b=AqkFVEli/e48byG67UvTkjQmHrYrGEtbFm/j48/sr+aU+pVSnfZFnBLOVQlI9kBdaD7zTH1VtcSYsoBadjQWq1iQs1yoIE/6+98bNNVZ/Lye2CJmoibFd0mbvAjmhVlmClsu5dd/woZqYjqFUZQ/KATRr/FnFyAQWpn3maWRiws= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790482315; c=relaxed/simple; bh=VLWeropCVNgal1tBk4IXkcnMMJw8jlVIylymhpt57Gw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rDDBjnYAafP9874sW59d8w4KtUspgl3VO++bI27Ym65e/jgXaTeJgi+gNTFQ9rS3qQ9mNaNt0QYDflTbyMH755hHK3ACSVwwmYM0/uvGNnYmYZaRXSMvvjhzldWMKuqohqtCLVAKiuvFFFlCgEGE1MP5Ni45ZpAVN3rN9LfjwaY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bcRWV2yV; arc=none smtp.client-ip=74.125.227.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bcRWV2yV" Received: by mail-pj2-f12.google.com with SMTP id d9443c01a7336-2db1ca06a25so8660485ad.2 for ; Sat, 26 Sep 2026 21:11:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790482313; x=1791087113; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qcS3RenUvubWv2f6ewrazrqpLWiguUUmu4bcjJFtKKA=; b=bcRWV2yVhc82pBpim2gBEX9WEQBVrZMIjH5Pe1X94z4hA/HHAoWmSmuZl6kG+ahps/ VUC6XStFQXntIVFNSB0z3ZVFHgnD4gHcbvKMkfctFMueWVfE6snD/Zn3jx/BQl+4pfkn L4A4zPsf0F2K7tbR0ajs/EAaiJnEn5zGFsCJ0Idlg4+JVqe38SzKfMket6JPNQCP2Gi/ FZZat6wkaDAGi2fcO+SDwl00dkxBjyRlMlrAN5ApEu1BXr4k61MpMpXJR2TOaZPWCY4m BXRA1ea6laob1uf2hAQzrMM8qRrziB8NBSTDNSmIC6V9IYpwKi7luTCdQhI6oBLzeZKS etdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790482313; x=1791087113; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=qcS3RenUvubWv2f6ewrazrqpLWiguUUmu4bcjJFtKKA=; b=B7TsFChu/BHlDLANY0KUf7fi3INdocZXVSsTEErLujpnAVh91KbXnWhWgbxs01XtsK v7eqHL4XmftU6AixDniZ3u9e6zXvXN4D6qKs2fCOWX11gpT9lqYli3O5JtwCu4eq5gP9 ICpjZ6TwsnaxMTAgjTQR/Qael0P140/e15QLYBhy209D1y3Mmc7MzWJCQcpZtObyUeD+ hf2yJc0gPTzYWwBaUxDD3wVrVLSjnPCa7D5xrwXU85gyjrWN5MASoHu5BQQqZ2u1bAA7 CBIyoWTMJ+i6LHkFNf0yl8404lkgfXc14hzFjDm5eW8zJe6unpcSJ+4DoTG7XfRdFmw4 PJNA== X-Forwarded-Encrypted: i=1; AKwUvBzryARiJxC1+9q8wLcUrtXtjvXiFHwCJ2/GT6wTPQKXfIeCChnKCisRlT0Wr4FLuZLUiffuefQ=@vger.kernel.org X-Gm-Message-State: AFq9FYJYyXHQodOL8aKo8+1mvzUdrrtR/xesJqWf3lCh+QP/Gu4bPrFQ XxHGRz2c25LZqqg5F0M2wUC2mF6no02EBw3CLNfSXSqK4LcMAKOY/Tpw X-Gm-Gg: AYBFou0vum+x0kfhtKVJNhP+EViRzCdnXwWuNm7syjTcgRUpsmw4c8eRPb1ZWCf+C/N OxtyRihSV0zHPFeZNBDvlCXkq4Tvrn8eX6/LEhzwiHXW+/mZLl2DDxFS3EojTFWEsH0Z4OV3LY2 do8iKvgzsAkr6JL8mqlqig9D8gA9FSZwldE29nqYsxg/oFUen3f6wMeOsIjonj8CXPkIAdin/8b 1NHF6zdZbGcJ8J+oMvAwCjC8J2JI3QEQUP/Bv07X4u8nuxRPP+y6QyeO9W3f2JBt/pgio3vlCAN i/7JF4xrhkMINWX2dq94Mn3/yZb1M4KfB4Q4UQUOo3ONGO1La6DlxJsybzTT66pb2IQGWKv6cJj pDTsw4VD4f4Az2DxqxGd2Z1XWckQhzR5iIFFQsy1GntdgaWtbHtbk/Rntvw8HTzQm5tf4loh//R WGQiCcLNmYXB6pSiv0Toq5DI7TgVZ3NE99TiS2OM5WqfYzSI0O4fLF+wZAyAtS6Myhaa/CDF1yi zkKiRB6/frFv8COWnTeIz92 X-Received: by 2002:a17:90b:53c3:b0:3a0:4668:4cb0 with SMTP id 98e67ed59e1d1-3a09896a5a5mr8482883a91.47.1790482313402; Sat, 26 Sep 2026 21:11:53 -0700 (PDT) Received: from jmoon ([118.220.156.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3a0b4f6345fsm5542732a91.1.2026.09.26.21.11.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Sep 2026 21:11:52 -0700 (PDT) From: Jinmo Yang To: ping.cheng@wacom.com, jason.gerecke@wacom.com, jikos@kernel.org, bentiss@kernel.org Cc: dmitry.torokhov@gmail.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Jinmo Yang , stable@vger.kernel.org Subject: [PATCH 3/5] HID: wacom: check the input device in wacom_intuos_pad() Date: Sun, 27 Sep 2026 13:11:36 +0900 Message-ID: <20260927041138.4112920-4-jinmo44.yang@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260927041138.4112920-1-jinmo44.yang@gmail.com> References: <579o8so3-09o3-o312-4sq0-0qp6n672q46p@xreary.bet> <20260927041138.4112920-1-jinmo44.yang@gmail.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit wacom_intuos_pad() takes wacom->pad_input without checking it. An interface that declares no pad leaves the pointer NULL on a fully successful probe, and wacom_intuos_irq() still calls this function for pad report ids. Reproduced on linux-next 20260925 (x86_64, KASAN) with vendor 0x056a product 0x032A and report id 12: BUG: KASAN: null-ptr-deref in input_event+0x44/0xb0 Read of size 8 at addr 0000000000000028 wacom_intuos_irq+0x1b46/0x3300 wacom_wac_irq+0x1b59/0xb3f0 wacom_raw_event+0x68f/0xb60 __hid_input_report+0x398/0x4d0 uhid_char_write+0xa99/0xfc0 The function only ever serves pad reports, so the check goes at entry. Fixes: 10059cdc0ad0 ("Input: wacom - split out the pad device for Intuos/Cintiq") Cc: stable@vger.kernel.org Signed-off-by: Jinmo Yang --- drivers/hid/wacom_wac.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c index 794c2865064a..48a58a6672c2 100644 --- a/drivers/hid/wacom_wac.c +++ b/drivers/hid/wacom_wac.c @@ -553,6 +553,9 @@ static int wacom_intuos_pad(struct wacom_wac *wacom) bool wrench = false, keyboard = false, mute_touch = false, menu = false, info = false; + if (!input) + return 0; + /* pad packets. Works as a second tool and is always in prox */ if (!(data[0] == WACOM_REPORT_INTUOSPAD || data[0] == WACOM_REPORT_INTUOS5PAD || data[0] == WACOM_REPORT_CINTIQPAD)) -- 2.53.0