From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f3.google.com (mail-pj2-f3.google.com [74.125.227.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A83F33F58D6 for ; Sun, 27 Sep 2026 14:24:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790519089; cv=none; b=rf4SXmBH5KvgzYohM6TVqzKgWCx0HXRccj4oEdwm30JFSgftj6MM9Jl0B1knAbRrIzMy4lWDA5XagWtv4sfbx6E0KYA3oQe3gwuy+XGl2WG2Zs5cdvAc+iHGpuHSus9YlrMOJg0q9K8bIaM1LbBXMTK6h3wmIoisBTgMdp935E0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790519089; c=relaxed/simple; bh=1B7kYapCZpPFtgUkVhWVPxakfdU8+qYYCL4ZQ9DMlQs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Vh9fWwWUbP8fKa0tvkVB+SpUJycUgh2DzQU+LtUIgcrl3RT6RRQ1KBt4PuTB6SCajYAvPTHt9oNtV+3JBOCiHRiY+s+iJgzpLqr7xEIOfMz76MgajNDBKWd6RHqhyUcTt0kzd+SS2SS3QQDeKuWTN3tNpu0UAfkafv2m9Eufvxk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LARR76NI; arc=none smtp.client-ip=74.125.227.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LARR76NI" Received: by mail-pj2-f3.google.com with SMTP id 98e67ed59e1d1-3a0cb6b922eso732665a91.1 for ; Sun, 27 Sep 2026 07:24:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790519086; x=1791123886; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=KoReSBu918TC7LfxH4R53EGW5VKxOHQwVKQfiuCg6QE=; b=LARR76NIMKliW+yUa2MyOaK8oRYVWAkZPm2i+R7j4X4LMZ4kFCxO6EY994tiaMQOkE p7flM/DSgQU4OqZ0nIoMd+IjrwxvajwzTeR56LKp0+/AUgOw/4Rs5/JA0dozTDYHply6 NbRl+G1iqio/lznxdP2zLBRf4uVWcY2blr7OI+IUw7R3GCsryblTDaQESFyEB4nE2Bis Xu+c7DkM2nOd6XK3eBk2VB5uCao4t1QFnpkbUKaaN0x9uvwb7/OSTantAavb8UMiVPEA S7hhdK9AoLVkMlUL9YluFN6CDUTNfNlqYBVkwGSw4FRW20NA4xySSLXlBbpRdNFOvwsc kOJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790519086; x=1791123886; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=KoReSBu918TC7LfxH4R53EGW5VKxOHQwVKQfiuCg6QE=; b=sNVFcguRLunGzACtxCAsKFl9pSm1AczroKLqK89AyRzK3aWxKdFuWPJWXqUpaFT2Hc e0H2l6tT1WxgnJIDcgBUFLaij/vdaK31GPrZakGEeMdGfK1QjpVIfA6pxKGTlQ2iYb3W QYfC2J+bJfAdl8qVgpa7TylPcqslfzB5+2xZHx9ibzWkltla/o6TmQm+PXWTXL1mgeKI ja4TpiJa09rMxeOQW10lx0fHBlnq2veqbqjipCxm8sGk1CM9hCrqRh6899EnVz5civXQ NIMabAkbgTM4mLUHZSNZrtyaTi+kmMOzgaoZTHBwPoC+bWBmDlVTLWvtTpUjjm61WE81 Vj4Q== X-Forwarded-Encrypted: i=1; AKwUvBzL0YBCt4y2Vbu0WsmEM9q0tOU/sAi+PhXEF05/2TxGt3RnJEP6Q5qK3bRGGWghQrrtP8A9img=@vger.kernel.org X-Gm-Message-State: AFq9FYIwdVZWYnSui8oY0MHN9DaBeBfYWa/ZDEYqzA/YTJNR7itUbI6J OnJPpPW4JM5/CcDrZuzNZF/WN77RzKTj9sbeBJniDaWnzd3q71Zh0euTwSscMkV04fE= X-Gm-Gg: AYBFou16P08WBRhfJJA5srRuqqBDL2T5RxP+rFTcqPpUQ4FDlFjZyew5C4WxKvQRhiG s7DzG3FMYmupLGwAJUV6qB071TKe9nOstecZRa3BU+f22a1nYOWmVcHjCbRizfD/FXeE5WYEVmR k5q8UwGoRxh6xr6dNuyOUp0ax0F4X3Wk8u/ApNSidA5stN5kOHg0PIdjOUyj8kEt+548iyZ8eIf oAR5LVM445Av9EvrD1Xc9VqDEVG9j7/Z3JopxEjB7JQQnaD8lPbvSKVPrdjeoUUgsTP85rKQ9zy E7lBmndwXm7UOPBUC49sk4YotdfOZV3JfWKsoBDgRqrKoLX3ELPkEAEwGg4AQu+vYnS9FHD9FRB sgR812ftxyQ02XnObju1tb7l5QM4oimUR8KwYFhMxoHfpFtX77M7HcmI4OpFfTLE6MUXt7xoauE cRl7BV31DegviHyyxC2OHqvvu8vpkEqBKnUUnEiPClkU0WaP7Rm/+aHbD1cO2qAiY2SsySiIYHV c9UmDC28g== X-Received: by 2002:a17:90b:2247:b0:3a0:ca03:3e1f with SMTP id 98e67ed59e1d1-3a0ca03447amr4203206a91.32.1790519085824; Sun, 27 Sep 2026 07:24:45 -0700 (PDT) Received: from LAPTOP-QJLDGQ2L.lan ([47.82.103.134]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3a0b9892dbfsm15424701a91.11.2026.09.27.07.24.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Sep 2026 07:24:45 -0700 (PDT) From: Boyan Liu To: Chuck Lever , Jeff Layton , NeilBrown , Olga Kornievskaia , Dai Ngo , Tom Talpey Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, co+7aebac19e62711ff@bugs.sh, Boyan Liu , stable@vger.kernel.org Subject: [PATCH] nfsd: Fix out-of-bounds read in clientstr_hashval() Date: Sun, 27 Sep 2026 22:23:19 +0800 Message-ID: <20260927142319.12054-1-yymhvert@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit clientstr_hashval() always hashes 8 bytes of the client name, but since commit 6b1891052a3f ("nfsd: make nfs4_client_reclaim use an xdr_netobj instead of a fixed char array") the name is a kmemdup()'d xdr_netobj of arbitrary length. A 1-7 byte ownerid is legal, so the hash reads past the allocation: BUG: KASAN: slab-out-of-bounds in nfsd4_find_reclaim_client Read of size 1 at addr ffff888010acf1a1 by task nfsd/141 Call Trace: kasan_report (mm/kasan/report.c:595) nfsd4_find_reclaim_client (fs/nfsd/nfs4state.c:1622) nfsd4_reclaim_complete (fs/nfsd/nfs4state.c:5286) nfsd4_proc_compound (fs/nfsd/nfs4proc.c:3313) nfsd_dispatch (fs/nfsd/nfssvc.c:1038) svc_process_common (net/sunrpc/svc.c:1527) svc_process (net/sunrpc/svc.c:1682) svc_recv (net/sunrpc/svc_xprt.c:886) nfsd (fs/nfsd/nfssvc.c:919) The hash only selects a bucket; compare_blob() does the real comparison. Hash the actual length, like ownerstr_hashval() does. Fixes: 6b1891052a3f ("nfsd: make nfs4_client_reclaim use an xdr_netobj instead of a fixed char array") Cc: stable@vger.kernel.org Reported-by: co+7aebac19e62711ff@bugs.sh Signed-off-by: Boyan Liu --- fs/nfsd/nfs4state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c index 18e17232c..6c50286fa 100644 --- a/fs/nfsd/nfs4state.c +++ b/fs/nfsd/nfs4state.c @@ -1619,7 +1619,7 @@ static unsigned int clientid_hashval(u32 id) static unsigned int clientstr_hashval(struct xdr_netobj name) { - return opaque_hashval(name.data, 8) & CLIENT_HASH_MASK; + return opaque_hashval(name.data, name.len) & CLIENT_HASH_MASK; } /* -- 2.43.0