From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CCEE519DEC for ; Tue, 29 Sep 2026 11:56:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790682964; cv=none; b=YYbjVTUgFeElCys4HXEgTxKEnb/CqqZKYO+ggg/vu5ITZ0NHPRxdmfXjuXydwz48NDleQZ64SHrVQUfOhq2IdJtlVxO5FMvjeAg6vfUnIJ+ptIWhta/p0STjXxMBcpSUIuIsO66W9JPMwb6PIHWIwL0w7Z0K5boyrTfn+0ETlCI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790682964; c=relaxed/simple; bh=cQBxUdP2ebutncm4Fl2TPhSsyo4QPYNbse6yqXH4zOs=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=UVVn3xF9mdGEuyejI7ojo1xmOz10RvhOYITqO7m1sMy7jekKoz8T3dynBL8sLf4FLS08pdsxIo2PGoqAAaGe+Bd2FXVI6kRE/N7PBrcvEB5q9GvCvFTgO30uv3Ejm9rt7TpzvhOmM4c+gIpjFvukGONo4nRrGquTqDV4glbYIoc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=zPuxBuX1; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="zPuxBuX1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1472D1F00893; Tue, 29 Sep 2026 11:56:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790682962; bh=RhvCZp1T0A1HuoEKEdDPtMqkeA0y7I2wuKy0oNTj3jM=; h=Subject:To:Cc:From:Date; b=zPuxBuX11peMhCxL9Fwe336Sd3XlCdf8QdBlIAnvdbAHZjI353x0lkLEUt7aQEUlh 1X/L6GDbwmLgw0QqkQVROnvqS+5+HnuC5Q0lfWWFIOGkn1wgnEmui1HnWGXymV3JNP qwtYe2dHj/hnhhLCVgnPyAnf93HgvNUfHpodp1oY= Subject: FAILED: patch "[PATCH] smb: client: delete compound mids on send failure before" failed to apply to 6.1-stable tree To: adarshdas950@gmail.com,pc@manguebit.org Cc: From: Date: Tue, 29 Sep 2026 13:53:27 +0200 Message-ID: <2026092927-unfold-magma-a87c@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit The patch below does not apply to the 6.1-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.1.y git checkout FETCH_HEAD git cherry-pick -x 8f6f8a48399f82f4a83f7b9f25b9707e0062a4f9 # git commit -s git send-email --to '' --in-reply-to '2026092927-unfold-magma-a87c@gregkh' --subject-prefix 'PATCH 6.1.y' 'HEAD^..' Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 8f6f8a48399f82f4a83f7b9f25b9707e0062a4f9 Mon Sep 17 00:00:00 2001 From: Adarsh Das Date: Sat, 19 Sep 2026 16:27:32 +0530 Subject: [PATCH] smb: client: delete compound mids on send failure before unlock When sending a compound request fails, smb_send_rqst() kicks off a reconnect. compound_send_recv() still has those mids on pending_mid_q, but it unlocks the server without removing them first. During reconnect, cifs_abort_connection() walks pending_mid_q and runs each mid callback. With no response yet, those callbacks return credits and drop in_flight. Then compound_send_recv()'s send-error path returns the same credits again. in_flight ends up decremented twice and smb2_add_credits() WARNs. syzbot hits this during SMB2_negotiate when the socket send fails. cifs_call_async() already calls delete_mid() before unlock on send failure. Do the same for compound chains and set cancelled_mid[] so the out: path does not delete them again. Fixes: ee258d79159a ("CIFS: Move credit processing to mid callbacks for SMB3") Reported-by: syzbot+eeb58d2197d88720a228@syzkaller.appspotmail.com Closes: https://lore.kernel.org/r/6a727d22.40259c87.584f4.04ce.GAE@google.com Tested-by: syzbot+eeb58d2197d88720a228@syzkaller.appspotmail.com Assisted-by: LLM Cc: stable@vger.kernel.org Signed-off-by: Adarsh Das Signed-off-by: Paulo Alcantara diff --git a/fs/smb/client/transport.c b/fs/smb/client/transport.c index e266859818a4..7df5b3447aea 100644 --- a/fs/smb/client/transport.c +++ b/fs/smb/client/transport.c @@ -965,6 +965,10 @@ compound_send_recv(const unsigned int xid, struct cifs_ses *ses, if (rc < 0) { revert_current_mid(server, num_rqst); server->sequence_number -= 2; + for (i = 0; i < num_rqst; i++) { + delete_mid(server, mid[i]); + cancelled_mid[i] = true; + } } cifs_server_unlock(server);