From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f42.google.com (mail-pj2-f42.google.com [74.125.227.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DC0743DEB0 for ; Wed, 30 Sep 2026 07:19:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790752760; cv=none; b=KDw801vxQX4UhHWywJKfPwQ+jhECCN0f3S/ltiI2qApGr7o0PQ83KuWiB5ZsifZryE/Mt/R3Ab9FK73FGNtnXsLwkMjKpcsLc5aPuZ1tOYxPXk40cPyPMosnSw6yAlUoD95DT5StwG652Twd2VKbnnuhcXMFWbZrOVbnbjObcNc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790752760; c=relaxed/simple; bh=8n4IhzxLjYl7HTSiJyo9dgWou+NdEFWkn0ApdKjkeKI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WhkHBR+ptokD0HZQfeQxJMAHfxcIF5Pthx7OTkudURTNy4KoP9prHMWD4wdQTfoYH1LXsL9lMF3TmjvaWhu9ByYXvQbg8vHujuXwgMzj3J7MJbmUIwva1HYlwEDyxy1TZA+CgnyCczcXhtbH2/d8k4J7JBqOx/bF//aKvx9cJts= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MTl9c0Ct; arc=none smtp.client-ip=74.125.227.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MTl9c0Ct" Received: by mail-pj2-f42.google.com with SMTP id 98e67ed59e1d1-396ccd5cf02so2589959a91.3 for ; Wed, 30 Sep 2026 00:19:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790752758; x=1791357558; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=QpjVkotq4ymVbBexed9Q2u7FUNUeANInboIGD5bfseA=; b=MTl9c0Ct6Nj8WsJ/Exp1NgyW+ldkvgJDTmoHtUmx8p4WXraIK8xtILYANtXxflHURa 5AATeE4sVA77b67uFcuXfw2LntehGTxsyp3YPyCZpneCwWPbwQG8fxSGQGXA9+Uq3317 BM5py7KTM8IvEkBLX1hxLoFSWaD5qBq71jkpJWC6Tx1rtp5dRkKe8BDsNG/yEqNhC7B7 hl2dBLep9fVyINILUSBhVhqSVw5i2eTowJN2L96dhEA9q/6n+yJAUneN2s7S/bW6WcwV qgcJgozira6Xs3VP7NSJNHHDTr1L/6Qg524lHJ6AyC0j+QZOrnBZ30YSuPhO6BLWZiS1 Ommg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790752758; x=1791357558; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=QpjVkotq4ymVbBexed9Q2u7FUNUeANInboIGD5bfseA=; b=lniumDAAAbohkUybVM+OD8S9HpcKoPP/7UM92IPU3unatqaJfGbgQ6yTmL+Swt1e3w DBw7j5kafL0ddCxj7CNFdElAc071qazo9KGACmW1/g8JlI+FtB0yOTcUqiCy2srbTesh 1IEzdUE0nMFUJcjBk0RMQlQQxue1QHCm2/N8IfNfPtwg71d6PCKhvcJyt4FUXubb4KaF Ddr/Xl1CI3TBkUjnh3qk9BApEVxfSdPCg9yBKchiKnEjCADgvZlFqD9k+2REENWDX7HD 8qLHZQWxwRVJv7XOZcHuTn3DKpnB9jJ63AZBK1gY8mdGypur7dhuh2lojryKdNI+WkEJ B1lQ== X-Forwarded-Encrypted: i=1; AKwUvBy+kSbvN0J+D8mlsdhyEAAII19DiemlH7HpxuJnDEaNa41gLiWpSbabKV05KDPa1kR2TpjzHGk=@vger.kernel.org X-Gm-Message-State: AFq9FYLKNvlU6Rd4xnaR4U+FVaxmQnXRP1YEhBVZA3F4ry6fu0lF1vwK ebGjIJLl5t0pEnNgWWEu8iLBa8XlMnXnFTnH5u4cHn+mG65ew7Wfh3pF X-Gm-Gg: AYBFou1GJv9BnfKuLF6dhrIdd2vzHmXaq7Vpqc/oBk+MrC5wTwaUnO6YtdQ+sM3Z066 zUbGVl/clcBQHjPy6/SXHa0DyBw3bW+OvsjKGHJ8RHI/X65ckOWSK9QwC+y9ts3ZfQ0qgm0P1pr MYJfMavzyF3c2Ogw0ol+6zXXCIStw8vK/Gp1m14Tpcgc9EAgnNSa2k7XHJafZet9QfRyncScHE7 e6eJM+NAEpe/z5WxNBJCTCaWZlMy6fUKbll8Q8sU6lPV+VMa8jaC1vqs7EO4qXIuKklT7fL3hhU qWBnIsg6yJYXxJz+FsPgqSGEuH5z74AmayKgMg8LWwe5+Eh3Hr9Yic3tlJoTiWnJXBTL84Aw691 8KDL72k1La5UFWISDYZoHJyh4xt3b7458eu/mNSHQdt+w/t0HAoMsyuBgrwg21uPPdb2PbpQLAi B6LFtjIGNBYLV78FZvewLjSuoPUNy0rZexjnTZA3ndlZWVWJfiof+7hpA8qD8m43ML/oW0MyCXN wsS6OBjaR+X3BjKRCpdeifKXklbk83mT2yBTuaFq6QfWtpDwpGcXchuxJjXnmPIFYW2zBhxoDO3 uQGRDJBhGw== X-Received: by 2002:a17:90b:4c4b:b0:3a0:b809:b9e7 with SMTP id 98e67ed59e1d1-3a4d0f0351fmr441328a91.4.1790752757725; Wed, 30 Sep 2026 00:19:17 -0700 (PDT) Received: from phui-2.c.googlers.com.com (25.187.82.34.bc.googleusercontent.com. [34.82.187.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3a4caec0f28sm2256687a91.17.2026.09.30.00.19.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Sep 2026 00:19:17 -0700 (PDT) From: Hui Peng To: Harry Morris , Alexander Aring , Miquel Raynal , Stefan Schmidt Cc: David Laight , linux-wpan@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Hui Peng Subject: [PATCH net v3 2/3] ieee802154: ca8210: prevent stack buffer overflow in hwme_get_request_sync() Date: Wed, 30 Sep 2026 07:19:13 +0000 Message-ID: <20260930071914.421586-3-benquike@gmail.com> X-Mailer: git-send-email 2.56.0.rc1.315.gc6ed9934b7-goog In-Reply-To: <20260930071914.421586-1-benquike@gmail.com> References: <20260930071914.421586-1-benquike@gmail.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In ca8210_get_ed(), an uninitialized u8 lenvar and a pointer to a 1-byte stack buffer (u8 *level) are passed to hwme_get_request_sync(), which unconditionally copies response.pdata.hwme_get_cnf.hw_attribute_length bytes into hw_attribute_value without checking the caller's destination buffer capacity, overflowing level on the stack when hw_attribute_length exceeds 1: BUG: KASAN: stack-out-of-bounds in hwme_get_request_sync.constprop.0.isra.0+0xf3/0x170 Write of size 16 at addr ffff888001907780 by task init/1 Call Trace: dump_stack_lvl+0x70/0xa0 print_report+0x153/0x4c6 kasan_report+0xf1/0x120 kasan_check_range+0x125/0x200 __asan_memcpy+0x3c/0x60 hwme_get_request_sync.constprop.0.isra.0+0xf3/0x170 ca8210_get_ed+0x9c/0xf0 ... The buggy address belongs to stack of task init/1 and is located at offset 48 in frame: ca8210_get_ed+0x0/0xf0 This frame has 2 objects: [48, 49) 'level' [64, 65) 'lenvar' Initialize lenvar = 1 in ca8210_get_ed() and return IEEE802154_SYSTEM_ERROR in hwme_get_request_sync() if response.pdata.hwme_get_cnf.hw_attribute_length exceeds *hw_attribute_length. Tested in QEMU with KASAN enabled by passing an oversized hw_attribute_length response into ca8210_get_ed(). Fixes: ded845a781a5 ("ieee802154: Add CA8210 IEEE 802.15.4 device driver") Cc: stable@vger.kernel.org Assisted-by: LLM Signed-off-by: Hui Peng --- Changes in v3: - No changes. Changes in v2: - Split out as patch 2/3. - Replaced the temporary stack buffer in ca8210_get_ed() with lenvar = 1 and an upper-bound check against *hw_attribute_length in hwme_get_request_sync() as requested by Miquel Raynal. drivers/net/ieee802154/ca8210.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c index a990a0f..8aa7ffe 100644 --- a/drivers/net/ieee802154/ca8210.c +++ b/drivers/net/ieee802154/ca8210.c @@ -1677,6 +1677,9 @@ static u8 hwme_get_request_sync( return IEEE802154_SYSTEM_ERROR; if (response.pdata.hwme_get_cnf.status == IEEE802154_SUCCESS) { + if (response.pdata.hwme_get_cnf.hw_attribute_length > + *hw_attribute_length) + return IEEE802154_SYSTEM_ERROR; *hw_attribute_length = response.pdata.hwme_get_cnf.hw_attribute_length; memcpy( @@ -2027,7 +2030,7 @@ static int ca8210_xmit_async(struct ieee802154_hw *hw, struct sk_buff *skb) */ static int ca8210_get_ed(struct ieee802154_hw *hw, u8 *level) { - u8 lenvar; + u8 lenvar = 1; struct ca8210_priv *priv = hw->priv; return link_to_linux_err(