From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77E824457DA for ; Wed, 30 Sep 2026 19:49:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790797751; cv=none; b=FBtMv8UGj1d6HpbeDdF/lLRbkaiQVefvrOBL8grFL1j0mb0SfR3NlQh3e1/s0ISX6TtTUFc4swP797qRT6Lkdg/0UmPAcUXzAM086g9oP2qhS1L3VCG04D8Y+5yVKbFWct3uZXoc0r1WSGLRApPiX7mPE3GQ6mBgcVCR5U2Fxt4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790797751; c=relaxed/simple; bh=stMSC2DBRJoiVhSnvbHkIa6Pi0znMqyG3KxYnGUNco0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NIPL8rXu9vtyFOv+D1yHppCIVXozGYVHZ1G0wqr81rHi85FD3YXjX4+sTdbEKNZJwa1CK9Shou3jyrOpio/wIw9KsNpCelI6cG+mZq3zton4KzemvaLA91Q8ngs4ZJhiH6IyAfnMlySOP4bSifTAFXIAfCniZsfN9gajYUnwvcI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=esA6Twm1; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="esA6Twm1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E774E1F000FF; Wed, 30 Sep 2026 19:49:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790797746; bh=EVnjGhWevsi0ZMhxAjTEj6xDPeixi8MkQJ9e43j8nHE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=esA6Twm1xWiMGp/cDMAzysKdYBBk8YpzlETd6Ez0663SiB6dvzuONXPzA6pVEojOU 5Peq7xYjCft+fYOjlnqumie+aLafSCIEZWPEIrm76LA/2naU6BZhlI9mFkvwuSswo8 g2H8TA//woTdlLIZFcEkSjaHu8V1ssRMFH869JkuT4CUV91O/m+IYZ2GrNrvVZcnAQ Hr8YH4B26dnN5kX3ntNgY5uSwooE349446UJO6+yghfZ8itYfNrK09gO7FLZJUugFS liUhI3VVCRZTNWd46lO/cLMnxH1CMQC5cUzClOaFSH9g9kOLIx2POkR1EzomSNW31w cmDkX3d5Mbilw== From: Sasha Levin To: stable@vger.kernel.org Cc: Adarsh Das , syzbot+eeb58d2197d88720a228@syzkaller.appspotmail.com, Paulo Alcantara , Sasha Levin Subject: [PATCH 6.1.y] smb: client: delete compound mids on send failure before unlock Date: Wed, 30 Sep 2026 15:49:03 -0400 Message-ID: <20260930194904.885712-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026092927-unfold-magma-a87c@gregkh> References: <2026092927-unfold-magma-a87c@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Adarsh Das [ Upstream commit 8f6f8a48399f82f4a83f7b9f25b9707e0062a4f9 ] When sending a compound request fails, smb_send_rqst() kicks off a reconnect. compound_send_recv() still has those mids on pending_mid_q, but it unlocks the server without removing them first. During reconnect, cifs_abort_connection() walks pending_mid_q and runs each mid callback. With no response yet, those callbacks return credits and drop in_flight. Then compound_send_recv()'s send-error path returns the same credits again. in_flight ends up decremented twice and smb2_add_credits() WARNs. syzbot hits this during SMB2_negotiate when the socket send fails. cifs_call_async() already calls delete_mid() before unlock on send failure. Do the same for compound chains and set cancelled_mid[] so the out: path does not delete them again. Fixes: ee258d79159a ("CIFS: Move credit processing to mid callbacks for SMB3") Reported-by: syzbot+eeb58d2197d88720a228@syzkaller.appspotmail.com Closes: https://lore.kernel.org/r/6a727d22.40259c87.584f4.04ce.GAE@google.com Tested-by: syzbot+eeb58d2197d88720a228@syzkaller.appspotmail.com Assisted-by: LLM Cc: stable@vger.kernel.org Signed-off-by: Adarsh Das Signed-off-by: Paulo Alcantara [ Changed delete_mid(server, mid[i]) to delete_mid(midQ[i]) for the older API and request array name. ] Signed-off-by: Sasha Levin --- fs/smb/client/transport.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/fs/smb/client/transport.c b/fs/smb/client/transport.c index b72d12a24056c..ab124a43eac48 100644 --- a/fs/smb/client/transport.c +++ b/fs/smb/client/transport.c @@ -1200,6 +1200,10 @@ compound_send_recv(const unsigned int xid, struct cifs_ses *ses, if (rc < 0) { revert_current_mid(server, num_rqst); server->sequence_number -= 2; + for (i = 0; i < num_rqst; i++) { + delete_mid(midQ[i]); + cancelled_mid[i] = true; + } } cifs_server_unlock(server); -- 2.53.0