From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04E363B47C4 for ; Wed, 30 Sep 2026 23:46:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790811999; cv=none; b=C8f8m4pD3U88P6Q/oOBufLLFwDT/dbubh04W18jRbZR75rpvSaEwGNrLCuzJtCwKnNk8/wbyF8MFVLlL2UQLUG8Qpr9q4FcbykOZxT30LSXCebB7X2VppPDDmRa2XZrSFm5Ss4FXpsRlGFgKyB3ws3Sf751mV+gnTnPtXSSM55Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790811999; c=relaxed/simple; bh=uAoiCZS/+/+3vHjgzyK+RzN2Zh8/AcD+RY98xwq2+cM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gYnk46gz9nrZN2puI3pW/nkHjTgXbbrsGT3PCNDh7HqhED9/avjJurxFv6PS//q/rthj2q8ejqQZZU4kaWfRhaoDAfhdsUuuV4pGxR3g2YH2AXG4sXOILXtl0SCj+yAwyFx8/Tp1QEXjWdQj4gsK2A+rQhaiFglXo776mamOrj0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cJP4DDXi; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cJP4DDXi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 52C081F00898; Wed, 30 Sep 2026 23:46:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790811997; bh=9d02wqkMjz831y/dOSxk8PB70zNEEkU+oBsVmMgMo3E=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=cJP4DDXim5qUPlDVudYnRaZpnCPXw0pzP54UVCdg01k96X3AIMhGIB4DIZQn57W/k mih/gkj2TmfbEqbBVrOhHX1sDlpmfKwDbVU2JgnF8CrLoQifVWMu12aAhY8a5nCbhH DJFwCNluLs9qxzUONQKHp+9NcYny9KNt9rsYpzy57pWi/3D31kx/YSxoWOex1t1WRG hZMxEuIF9RqE7zF8hgVn1Wj4dT1E+xo1Gqf+uXXmHdyUVWWqFz10lY5uCmnOkVlGMw PYoQD7uYHjjDZ+VpOWH2HIQnc/rZ4wVcJ4FUF53Bn2pSk6DOjSpi2GVOE4wuxDnKFb NCc5cD1KGheKg== From: Sasha Levin To: stable@vger.kernel.org Cc: Adarsh Das , syzbot+eeb58d2197d88720a228@syzkaller.appspotmail.com, Paulo Alcantara , Sasha Levin Subject: [PATCH 5.10.y 3/3] smb: client: delete compound mids on send failure before unlock Date: Wed, 30 Sep 2026 19:46:31 -0400 Message-ID: <20260930234631.1192065-3-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260930234631.1192065-1-sashal@kernel.org> References: <2026092901-extending-vineyard-ce48@gregkh> <20260930234631.1192065-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Adarsh Das [ Upstream commit 8f6f8a48399f82f4a83f7b9f25b9707e0062a4f9 ] When sending a compound request fails, smb_send_rqst() kicks off a reconnect. compound_send_recv() still has those mids on pending_mid_q, but it unlocks the server without removing them first. During reconnect, cifs_abort_connection() walks pending_mid_q and runs each mid callback. With no response yet, those callbacks return credits and drop in_flight. Then compound_send_recv()'s send-error path returns the same credits again. in_flight ends up decremented twice and smb2_add_credits() WARNs. syzbot hits this during SMB2_negotiate when the socket send fails. cifs_call_async() already calls delete_mid() before unlock on send failure. Do the same for compound chains and set cancelled_mid[] so the out: path does not delete them again. Fixes: ee258d79159a ("CIFS: Move credit processing to mid callbacks for SMB3") Reported-by: syzbot+eeb58d2197d88720a228@syzkaller.appspotmail.com Closes: https://lore.kernel.org/r/6a727d22.40259c87.584f4.04ce.GAE@google.com Tested-by: syzbot+eeb58d2197d88720a228@syzkaller.appspotmail.com Assisted-by: LLM Cc: stable@vger.kernel.org Signed-off-by: Adarsh Das Signed-off-by: Paulo Alcantara Signed-off-by: Sasha Levin --- fs/cifs/transport.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/fs/cifs/transport.c b/fs/cifs/transport.c index fc3f651762182..dffb1b66a1e22 100644 --- a/fs/cifs/transport.c +++ b/fs/cifs/transport.c @@ -1124,6 +1124,10 @@ compound_send_recv(const unsigned int xid, struct cifs_ses *ses, if (rc < 0) { revert_current_mid(server, num_rqst); server->sequence_number -= 2; + for (i = 0; i < num_rqst; i++) { + delete_mid(server, mid[i]); + cancelled_mid[i] = true; + } } mutex_unlock(&server->srv_mutex); -- 2.53.0