From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f172.google.com (mail-vk1-f172.google.com [209.85.221.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CF5254705E for ; Sat, 10 Oct 2026 14:27:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791642429; cv=none; b=FGQE0WwNHNC+L5U5+QOCUL29BXkfCHUrKUj13QKQkDLwf4CA5uh8druJG8sTZ5o8SySHCuyRri3RheMZHuu1aqmBb9iXsJHohHxFDV5JNnCIYlaCXxByTGrF8iXb7k22/k7etR8Nbv26BtlaG6x/jXj15qYTa5UdKnLiecvD4Dg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791642429; c=relaxed/simple; bh=bT8QZiVKXnYQ1wriTXXN1fbxkqu2uho/BMV65qvCwEk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BCbS3eCAVGl5xTeHUXhxqbumuitePWhsJ7jTPPBnNQhLRnqkWdQsiq52d1qQG6Xj6Inm1aWJg9Fk5dWVgLOlmjNqKSwtow50QhN5P3D9UcMXbkMOXHPcv139qZ2aVxVToXv0Hy3tO7UeSw18eLn7ug4kjTpWOxMpzazlwh6YoEw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gEoKpKIo; arc=none smtp.client-ip=209.85.221.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gEoKpKIo" Received: by mail-vk1-f172.google.com with SMTP id 71dfb90a1353d-5e519c39196so194699e0c.3 for ; Sat, 10 Oct 2026 07:27:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791642425; x=1792247225; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=bT8QZiVKXnYQ1wriTXXN1fbxkqu2uho/BMV65qvCwEk=; b=gEoKpKIoGGA3vHhqVW4cqXARBXA8+KfdFA4u8/d6JgqidrYeMtRJjmbHoOr8iMKDKw jDW9BC67krz5fBAkfp2H3tbwMwIEPI1aYe6QXUowOwWfFzanOVnyFgCI+eY7K7AURPuE dB9yrWP5ECUUlRq2vsmke06X5ixwPdkaXYb4dSQhUxBrh6aFEPEhXTWRTRqYl9q3fqOy m4xoVORcUAjCrF1TOmjYP9t6Z8D053sAMIbGjMUkreIMDoN08/6O+IkyN9UR/2rp9upH rO+Ga5E7Yut92CY85DpWL+L9BpfhQ9c8RnEsrsrmq/tW0FSnzySaqHpAiF63hInRyEPn aSbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791642425; x=1792247225; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=bT8QZiVKXnYQ1wriTXXN1fbxkqu2uho/BMV65qvCwEk=; b=xhXH61L+/HuLgE2m6Fn8z+HPJSZ/w1ejS7mrzPDANPr4o/iUDqagFzY5c6Rix6t6Bx FIrX4i75+3JRmbLrPIWt5ExQLWhe+7gs2MzOjOZSeZCw4lnmW3j2mIYTixwFBYoNNxhd Luz69N8D2IxPrDcpfd+rvc7Ju9KeDTMURdofTftv7eyc7zL4jwmI2JKcfXl2lYa4xZ2C 0QHd6uFH3BPT0f8oeRfmNI8fIGi6qroJ0apIMF3mHUroYqFfrvdCVDEk+HI+MQQywQk5 cHg4TBkFG3KRXotN+bXxjGNHbKapuaEsQRJf9sewwKqN+Sr25SESA0zXl9XYvCg+jAbD AU+A== X-Forwarded-Encrypted: i=1; AKwUvBx3br1dNajjIi9Ec/1Z47cxPiBI346L7Bs3jcCnhveohcETpJl/2FpL4tNzuPrNtpGA5FzS9GU=@vger.kernel.org X-Gm-Message-State: AFq9FYK86biFmRymfke1lkgnZxGT2w9MRSwSKzBdCkKfo+JSdm+Hm9ik UL1rC4g4+smr19jflaGjy3+CBxpGOobQBzRrkskrCkibwFEXu9r8anO9 X-Gm-Gg: AYBFou35P2FJ/n1SZSiM13xs6qDqGSSopWKiNVXgDx/hzojcPfOq8WR3BljsFOnFgNg gO39lvKPtN0t/3673q5uLaJCzrCDFGrdqYU1j3/f7McuXWjYmsUQf4VF1sUgZrBu52OPrd5tsbZ pEbNjSI0So1Id3b2eVvlqVontFL9bCinArzmp9nc5ZTt/0W1vrzsPbR09z1witZhuVKImsLbGre LmvQDjUoWYpVPUcevmql9hafjcpfczf5crPgbZT7HCNncQ38wGKQJem1FHe2zcFlcOqwionY/ox 7mrnFCBQL7r8dS41p6X1TVTAPWAsfCARa4S5NsUMRXUOza9268EjLf3KzBeMEjdkdSKbyhAdUdK DcBZazhggBn6wKtPbETBlOqO/GoIlMsKlHBptf6c2gkJUnv/a4WbchYdiMfUu9rrfXP6NfhSssn ItZAb89VR0CXdl12zIZfmioegT70OjWtxuLNd3Ex0ASQQgvsuHnSYF9WY2scmUfrbl7jBGJJRLI 54= X-Received: by 2002:a05:6122:4f84:b0:5c9:a60d:3278 with SMTP id 71dfb90a1353d-5e91f4d0880mr1648232e0c.12.1791642425058; Sat, 10 Oct 2026 07:27:05 -0700 (PDT) Received: from beelink.. ([187.13.210.57]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-5e91cb292a5sm3982216e0c.7.2026.10.10.07.27.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Oct 2026 07:27:04 -0700 (PDT) From: Aldo Ariel Panzardo To: Kuen-Han Tsai Cc: Aldo Ariel Panzardo , Greg Kroah-Hartman , Ivaylo Dimitrov , Faqiang Zhu , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 1/2] usb: gadget: u_ether: Fix NULL pointer deref in debug logging Date: Sat, 10 Oct 2026 11:26:29 -0300 Message-ID: <20261010142650.2664739-1-qwe.aldo@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260923-u-ether-gadget-npe-v1-1-ff466c55ecc0@google.com> References: <20260923-u-ether-gadget-npe-v1-1-ff466c55ecc0@google.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Wed, Sep 23, 2026 at 03:58:35PM +0800, Kuen-Han Tsai wrote: > Replace the composite.h logging macros in u_ether.c with the standard > netdev_*() helpers. Because dev->net remains valid for the entire > lifetime of struct eth_dev and netdev_printk() natively handles > unparented network devices [...] Confirmed against mainline. The DBG()/VDBG()/ERROR()/INFO() macros in expand to dev_*(&(d)->gadget->dev, ...), so each use in u_ether.c dereferences dev->gadget; once unbind clears it, logging on the surviving net_device faults, as in the eth_stop() path you show. The conversion is complete and safe. u_ether.c has 26 such macro uses (18 DBG, 3 VDBG, 1 ERROR, 4 INFO; no WARNING), and the patch converts all 26 one-to-one to the matching netdev_*(dev->net, ...). dev->net is the net_device whose private area holds the eth_dev (netdev_priv); it is set at creation and freed together with it via free_netdev(), so it is valid wherever dev is. The remaining &g->dev logging in the setup paths uses the local gadget argument, and the dev->gadget->dev access in eth_get_drvinfo() is not a logging macro and is outside this change's scope, so nothing is left logging through a stale dev->gadget. Reviewed-by: Aldo Ariel Panzardo