From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792595531; b=xjYq9DMe2FaduG6YkbWMQQhJY/+FdIu98kb6/vedn4bGnDvh2ye5Tahuhdis2Cn+GYv8 orskeOCTtNzGilrs3CRUMMxhyHKmNR3bEV9+FF/TK8nN6vKxhz9pMcmG4EWEPaFe6OJ/D L3LBhcRTQHJ8HKUqhF7eV07CBqMlrUYXsG+wDZ4sVSZ3T4WbPoICONltXMggAV3YE/k/3 f52ZqqUyU09Ss1YNzCwmi3X9RiqZIB/FPLU5baFLiqdjkCyzcAh8j55G3hrSEF9IKLhec 5DiCBi/XPJxNYtQ9m9l6akmAQ/qIZgiqhl46EKPn08Q01CDUvHt817B/VfMk8qOI91w== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792595531; h=Received:DKIM-Signature:Subject:To:Cc:From:Date:Message-ID: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=4sYUPXevWsZCZzlThKiLbfsQkz/DKIEwhYgGsRUAdD8=; b=KU13wo6T39OxCT1yyh7MaP8NNPjH0F6YqzIWLBmIlLAECmcHdNRon/KXvp+ZNCHe+vSX pQ13Sltr2c+NoS93COlJ2unLBVVuT5//7kFtbw1eKPNF9gpnalTmjEIIs4zjdkLuVpU54 OZJSlS6cYO9e435YQDMgvEpcCXfGRlUmbkoBQdgABVDLgeO7QJOFQNiAXrli3pcbIuiWn G65b3uTFIeXqL5iY+zYA4lIExU2SXQ8nGbhtj6ru0EfkU/uE0umX+Ta/3nSxTeMYztmId Z72BGoi9XFOOhpIpSxfo9UlGSwBca7v9cyvi+pzBzDtzKw9DEr51OW2OV+g6+Jd54rA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=pH780rVR; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CEA32606A31A for ; Wed, 21 Oct 2026 15:12:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=pH780rVR Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2DA271F000C1; Wed, 21 Oct 2026 15:12:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1792595530; bh=4sYUPXevWsZCZzlThKiLbfsQkz/DKIEwhYgGsRUAdD8=; h=Subject:To:Cc:From:Date; b=pH780rVRZEVFcPjt4Rl7StBJdXrBRE12O8XcFRVIFSeRizFzifwputeKyuVDZeTfX XkRHGDJpEkqxDkakQshA8ykiEywi7sLArF7TN3cPqLGkok+3zQRSQuFFiLHg+skkXl 7mm+rDyRd68gsPL6Bb1bIDAmj89SHBwOFijHnKqw= Subject: FAILED: patch "[PATCH] cifs: add revalidation on FSCTL failure in" failed to apply to 5.10-stable tree To: sorenson@redhat.com,pc@manguebit.org Cc: From: Date: Wed, 21 Oct 2026 17:06:16 +0200 Message-ID: <2026102116-grove-undercut-9b92@gregkh> X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y git checkout FETCH_HEAD git cherry-pick -x 53676a5e28231186c9f56d87b7998b640699bc15 # git commit -s git send-email --to '' --in-reply-to '2026102116-grove-undercut-9b92@gregkh' --subject-prefix 'PATCH 5.10.y' 'HEAD^..' Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 53676a5e28231186c9f56d87b7998b640699bc15 Mon Sep 17 00:00:00 2001 From: Frank Sorenson Date: Sun, 23 Aug 2026 18:26:46 -0500 Subject: [PATCH] cifs: add revalidation on FSCTL failure in smb2_duplicate_extents() smb2_duplicate_extents() has no handling for FSCTL_DUPLICATE_EXTENTS_TO_FILE failure: when the FSCTL fails, local inode metadata may be stale from the pre-extension or from concurrent remote writes, but is never refreshed. Force revalidation on FSCTL failure and use i_size_read() for the pre-extension check. Fixes: cfc63fc8126a ("smb3: fix cached file size problems in duplicate extents (reflink)") Cc: stable@vger.kernel.org Signed-off-by: Frank Sorenson Signed-off-by: Paulo Alcantara diff --git a/fs/smb/client/smb2ops.c b/fs/smb/client/smb2ops.c index 7d6738ffcb80..bea4876b58cb 100644 --- a/fs/smb/client/smb2ops.c +++ b/fs/smb/client/smb2ops.c @@ -2218,7 +2218,7 @@ smb2_duplicate_extents(const unsigned int xid, trgtfile->fid.volatile_fid, tcon->tid, tcon->ses->Suid, src_off, dest_off, len); inode = d_inode(trgtfile->dentry); - if (inode->i_size < dest_off + len) { + if (i_size_read(inode) < dest_off + len) { rc = smb2_set_file_size(xid, tcon, trgtfile, dest_off + len, false); if (rc) goto duplicate_extents_out; @@ -2235,7 +2235,10 @@ smb2_duplicate_extents(const unsigned int xid, if (ret_data_len > 0) cifs_dbg(FYI, "Non-zero response length in duplicate extents\n"); - if (rc == 0) { + if (rc) { + CIFS_I(inode)->time = 0; /* force reval */ + cifs_invalidate_cache(inode, 0); + } else { qrc = SMB2_query_info(xid, tcon, trgtfile->fid.persistent_fid, trgtfile->fid.volatile_fid, &file_inf); spin_lock(&inode->i_lock);