From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792594296; b=Zv2Z1Kx3l0EUJ+g143r7aGLX1qbvA+yXgng+bGlDove1KjJa8WStqKDOoe0txZNflNxc zxqBk7FxSyUcKxlTV3d8oBMBz5ylxcw8HiFjPMqhZ6UwYiO9SWSy12ZflU/Vc8vkmAYwQ +noAHuon5KgFksQH88GhSvKabzEdDMzmUY3SI/jDX5Y/y5oV4qOKQJY3h0tOOIzE/hRiY C9EGDJo30UjgZmQE25By91eDAyrRlp4beetZAMiStsVQ0xxKOfrKaSkMiUPoEN+dRNTwH vXkrlMToN0RMYHj2KzYta1uy6wEbBeHLLnrYO9tflGqGyjrS5WMQGWUKR0VgUYgbAhQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792594296; h=Received:DKIM-Signature:Subject:To:Cc:From:Date:Message-ID: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=w9N799To/IJWQ6tKg1td2Hldka1BRrQh5mgYeRKGPtg=; b=gobyl4v4z84JcGx7ipdQzZDK4ZQYAo9S7mwBDHxyrUJs8ku0sNH4Ut5CcpFwCz36hwCN tARx2suloFh0wndwvJ9GzESfm3a8TqKghqKUlL66UT7Gq71scBdgVeXGx2r2E0ggv2Q3u bXNIy0TDeOR6zhA3EYtzWbmU9107/hn3RNFDfK9VR9qdmxHV6nuWIFJ2KOlUU4XbAiLBx H7hsf6E7Bk7wj3nINJVk19RjbitSi9LDbflgrk1BPmd8JARnuuZSVFSRqIKzzhK9MkoU8 ZHVa0/DX7w2VtxitVxmuj0nzecF2KVbKBCNXJw5V/rd6JUBGfQId854DSBPbg0VF4uw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=InqlAz0A; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 745A4606A319 for ; Wed, 21 Oct 2026 14:51:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=InqlAz0A Received: by smtp.kernel.org (Postfix) with ESMTPSA id B54F71F000C1; Wed, 21 Oct 2026 14:51:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1792594296; bh=w9N799To/IJWQ6tKg1td2Hldka1BRrQh5mgYeRKGPtg=; h=Subject:To:Cc:From:Date; b=InqlAz0AIPk4V4I+L1Erpgb2AqPWH6JgpU9shJO7/5cQHWXuH5pRhWKRbaE7AyFsy 8jGwHw+yWl4NRQEYklxXqcra+NLudTNbNxtpkApz+vRQDo2VbPkTJRIQ8XYJ4iSxXG OCeHHtx2SUjq6ey6ZFrJHRxUnUPFGecvS0DupZ8s= Subject: FAILED: patch "[PATCH] drm/amdgpu: free the userptr ranges when a CS fails after" failed to apply to 6.18-stable tree To: Jesse.Zhang@amd.com,alexander.deucher@amd.com Cc: From: Date: Wed, 21 Oct 2026 16:46:29 +0200 Message-ID: <2026102129-upright-catatonic-cf8f@gregkh> X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit The patch below does not apply to the 6.18-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.18.y git checkout FETCH_HEAD git cherry-pick -x 1b4da805a0ba354a549ce07459c871c17dd94fe0 # git commit -s git send-email --to '' --in-reply-to '2026102129-upright-catatonic-cf8f@gregkh' --subject-prefix 'PATCH 6.18.y' 'HEAD^..' Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 1b4da805a0ba354a549ce07459c871c17dd94fe0 Mon Sep 17 00:00:00 2001 From: Jesse Zhang Date: Fri, 9 Oct 2026 16:05:05 +0800 Subject: [PATCH] drm/amdgpu: free the userptr ranges when a CS fails after parser_bos amdgpu_cs_parser_bos() allocates an HMM range for every userptr entry of the BO list and looks up the user pages. Those ranges are only freed when amdgpu_cs_parser_bos() itself fails or when amdgpu_cs_submit() checks them under the notifier lock. If amdgpu_cs_patch_jobs(), amdgpu_cs_vm_handling(), amdgpu_cs_sync_rings() or the early part of amdgpu_cs_submit() fails, nothing frees them: neither amdgpu_cs_parser_fini() nor amdgpu_bo_list_free() touch e->range. Each such CS then leaks the range, its hmm_pfns array (8 bytes per page of the userptr BO) and the BO reference the range holds. An IB on a ring that patches the CS in place (e.g. VCN) with an unmapped va_start fails in amdgpu_cs_patch_ibs() and takes this path. Free the ranges on those error paths. Ranges amdgpu_cs_submit() already dropped are NULL, so freeing them again is a no-op. Fixes: fec8fdb54e8f ("drm/amdgpu: fix userptr HMM range handling v2") Reviewed-by: Alex Deucher Signed-off-by: Jesse Zhang Signed-off-by: Alex Deucher (cherry picked from commit c52a9542ed7cfd527feb938bd0accada2ac8d267) Cc: stable@vger.kernel.org diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c index 03b41f803520..ef8a61ce4b1d 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c @@ -1431,6 +1431,7 @@ static void amdgpu_cs_parser_fini(struct amdgpu_cs_parser *parser) int amdgpu_cs_ioctl(struct drm_device *dev, void *data, struct drm_file *filp) { struct amdgpu_device *adev = drm_to_adev(dev); + struct amdgpu_bo_list_entry *e; struct amdgpu_cs_parser parser; int r; @@ -1465,25 +1466,31 @@ int amdgpu_cs_ioctl(struct drm_device *dev, void *data, struct drm_file *filp) r = amdgpu_cs_patch_jobs(&parser); if (r) - goto error_fini; + goto error_free_user_pages; r = amdgpu_cs_vm_handling(&parser); if (r) - goto error_fini; + goto error_free_user_pages; r = amdgpu_cs_sync_rings(&parser); if (r) - goto error_fini; + goto error_free_user_pages; trace_amdgpu_cs_ibs(&parser); r = amdgpu_cs_submit(&parser, data); if (r) - goto error_fini; + goto error_free_user_pages; amdgpu_cs_parser_fini(&parser); return 0; +error_free_user_pages: + /* amdgpu_cs_submit() only drops the ranges once it got that far. */ + amdgpu_bo_list_for_each_userptr_entry(e, parser.bo_list) { + amdgpu_hmm_range_free(e->range); + e->range = NULL; + } error_fini: amdgpu_cs_parser_fini(&parser); return r;