From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.227.139 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792760691; b=emjb7sBvzh2jTKQ0vXhZVWLfbnxQwuqVyeywYmLOnFB9KO93PWq65UEpYEMmQG1GBuiU lK2v1sVUO4rLqlur+YeO6TXqQb04SbAOwPgqOnry1xWcZip9Vp7UxXAZGJn9Y1NxXnK9h 2MEMwbvpn8+LPdaXjHtUrYs56ciMT3AqlmKhIfRK+OmcpkDLLz7Vrfo+H5SFOtDzlTxYi 5V7bak1Mo4p1dhHYANpUqS5cgC6KKkVGNvAUiJpIFPDzyuQf7lAvavcnNDEh8b5Ab9S5t k6WRjfD/8S7gh/jqocDnNiVwq/9ok1o/vrUXPjBXOCcCTFTX6O0XJNBOG54orgIJUZg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792760691; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-Id:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=J/9Qj668b8yCGUf9keY9GwKS6HdGazYw0/H94SqUfB4=; b=XHgwXob3FVJ8SK4uPYj6qCo3jV38lE1QRjYDE310a6kxFtocI+OArL4n/AgQMtaLU4y4 IWbFmuBlE5dlwxIcHA+2fqqUemvxftTfM1cgQvLHil8hQ1y8xvfoIE4RHfwx0CST8aRTO KxdtpVrhK1em7xwSMCjMfCPAYYhNcidbcjOiA2t6sljBhftmheuibjzztWgaNi0oAg+Tp BihpOMqmusB9CMcS6KsDOvoq9I8R1hn6QNEj/xvhbWqt3q0fDyTMjKalNQOQvR2cty1rp aVoyqQms918kXK1pksYapIr0VgKdlGzGNN1e+QFXDsD9lx0bfScUwzviOPaIcdLiXTQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b="EXIEDt/g"; arc=none smtp.remote-ip=74.125.227.139 Received: from mail-pj2-f11.google.com (mail-pj2-f11.google.com [74.125.227.139]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01D43606A31E for ; Fri, 23 Oct 2026 13:04:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 01D43606A31E Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=EXIEDt/g Received: by mail-pj2-f11.google.com with SMTP id 98e67ed59e1d1-398a0a87595so437072a91.1 for ; Fri, 23 Oct 2026 06:04:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792760690; x=1793365490; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=J/9Qj668b8yCGUf9keY9GwKS6HdGazYw0/H94SqUfB4=; b=EXIEDt/g77XCyjvCOrXALm3ZjHJcurzVbgOuPo4yHc8b9BSFah8t+KxTVfVdO5QG9V 0NqJXHIxid2iTef539sMqBLQYJxS/4iudVK6vuejtUfgqVySseLWHX5eE1iQOu81gAqD MpsqSTgdIxnQyB8lkVxQJuMSL/PFLJIxgVdgMsEEolkqIQ/jOhqd1FXzG2LYLTo8mvyq REBZ6f1G0tkhszg83Eo7BPUKLk+tRFdu2ZfhneMHQ2I2QroxV1mxQ+1EZ4Av0U+wtswl cmsRBa8cCbx+OuY/8T2FQTy034Rotx+u+UwHD5V7ThgYg+58uHbB1iUuOy+AvWeVZWM1 oVNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792760690; x=1793365490; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=J/9Qj668b8yCGUf9keY9GwKS6HdGazYw0/H94SqUfB4=; b=wf5sj5fSNKYx/sF5tkIsSp8JBNG9uecrwrcWwxExOfB32HNDeTZaw6EQY56X0O86pb zfwtbKBXmYy8HgX9nU6o1Fj8btjygBwBzEgKnKnE85ANtXZU6KPRqI6IJHDsOfH6fpUF N3bRbLjFdEOuE9sqLVj4d6U0g7166PKN/fw54lsrsKhdy5CZQP+L5yr5aSEmULIiDtWT 7TZjuF+v57JUnDTukE3eNMoSz2Xk3B2HS+z/6f5gHGH9mkhPgbUpCBzPs34P0TvTAIbT rG5yaZggLVhXUTQH/iKwdfo8oEkeqU0usvbr50NOjA2jzPlOEzExhu4VPfx+el9m5KKG RaRw== X-Forwarded-Encrypted: i=1; AKwUvBwV1j5Jvctea/AW5DkcDWj0daTMWXD77ZisWvSqswRq/3Mpik5WUplH6944KPMvhDq8CMP1eZ8=@vger.kernel.org X-Gm-Message-State: AFq9FYIo9BudTb4KngA5FjfTgMS3DcbGR1SXT2ZI31G+zheo7yAVIl65 SemdZp//P8MJHJezOMZQ7o+6gm3WiB6zfG/C9SvNrYt19AacYGZFfgA= X-Gm-Gg: AYBFou3ej2INWOwSqutDbf9tTXQvgez0xMU7nLfzh98urRv5Pe+rucrIllACHyWqiCX TyxnPakaxYxhN+iWQhrOc4poK5Qd2nphSEA5E927WvXzLRtjfxSN7cn0DkgdJGsGtIFGLE7nMYM vmH2JjslrskoGGcVIaUxbPJFgiDcckTCf7YvWOqaoM+sihVxbfqO++38DHEuiVordXAoN6UH+lf N/jHV7MZxACmNhhlNymE5RxLDUUXHRkyGmQ8j7e99K4864eh6/C5+qObFUIwJBBLCGQVZAaI7MY yRPLwA+8IITtkrgBaKeIVPvO7+FN73mYPXVrqyZZ3h9r0veEIa/gQqhCYR5VcM0lHGF1IrCVSPY n+zgOXBnW4LnAF5pC2uNjxSfPcotrcoUVtfKjWg1OrCMl6vh8vaA2Cs1EIXT0AqOAqUaIA+QXsE GR9m4eCzFC1bauFXUGWjIcOt//QgzZcmMYqACx0nAR88yxrM/t/vwRQ3ew3HPiAjGEvwGlz6v6b I+7JU2szYm24bgiYMOl0yPAvZ6IPLIp/m50+4R1pz0iVTkME1vgNoVd6QbsLvNhpTgmxvTztM2/ F4TQj1B/wg== X-Received: by 2002:a17:90a:e7c1:b0:3ac:97bc:4c7b with SMTP id 98e67ed59e1d1-3adce02ec99mr1936652a91.14.1792760689865; Fri, 23 Oct 2026 06:04:49 -0700 (PDT) Received: from WIN-2DEDQG69EF6.localdomain ([109.105.193.131]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3add282a8bcsm1349017a91.2.2026.10.23.06.04.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Oct 2026 06:04:48 -0700 (PDT) From: chenhan To: rust-for-linux@vger.kernel.org Cc: a.hindborg@kernel.org, boqun@kernel.org, fujita.tomonori@gmail.com, frederic@kernel.org, lyude@redhat.com, tglx@kernel.org, anna-maria@linutronix.de, jstultz@google.com, sboyd@kernel.org, ojeda@kernel.org, gary@garyguo.net, bjorn3_gh@protonmail.com, lossin@kernel.org, aliceryhl@google.com, tmgross@umich.edu, dakr@kernel.org, daniel.almeida@collabora.com, tamird@kernel.org, acourbot@nvidia.com, work@onurozkan.dev, miguel.ojeda.sandonis@gmail.com, tomo@flapping.org, georgeandrout13@gmail.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH v4 2/3] rust: time: make Delta division and remainder fail consistently Date: Fri, 23 Oct 2026 21:04:12 +0800 Message-Id: <20261023130413.178487-3-chenhan0017.work@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20261023130413.178487-1-chenhan0017.work@gmail.com> References: <20261023130413.178487-1-chenhan0017.work@gmail.com> X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Delta's division and rem_nanos() use Rust operators on 64-bit and C helpers on 32-bit. The report shows that rem_nanos(0) can return 10 for a 10 ns dividend on ARMv7, while the same call panics on x86-64. The i64::MIN / -1 case also differs, and neither API documents these inputs. Check for zero divisors and i64::MIN with -1 before the architecture- specific code, and document the panic conditions on each method. This matches Rust's signed division and remainder operators, including when overflow checks are disabled. Valid-input results and API signatures are unchanged; invalid inputs now panic on 32-bit too. No in-tree calls to either API were found at the base commit. The checks stay in the existing methods so the fix does not depend on introducing a math module. Fixes: 4521438fb076 ("rust: time: Implement basic arithmetic operations for Delta") Reported-by: Georgios Androutsopoulos Closes: https://github.com/Rust-for-Linux/linux/issues/1254 Cc: stable@vger.kernel.org Assisted-by: LLM Signed-off-by: chenhan --- Changes since v3: none. rust/kernel/time.rs | 30 ++++++++++++++++++++++++++++-- 1 file changed, 28 insertions(+), 2 deletions(-) diff --git a/rust/kernel/time.rs b/rust/kernel/time.rs index 16b44e82d2ac..4415e91a5227 100644 --- a/rust/kernel/time.rs +++ b/rust/kernel/time.rs @@ -412,8 +412,20 @@ fn mul_assign(&mut self, rhs: i64) { impl ops::Div for Delta { type Output = i64; + /// # Panics + /// + /// Panics if `rhs` is zero, or if `self` represents [`i64::MIN`] nanoseconds + /// and `rhs` represents `-1` nanosecond. #[inline] fn div(self, rhs: Self) -> Self::Output { + if rhs.value == 0 { + panic!("attempt to divide by zero"); + } + + if self.value == i64::MIN && rhs.value == -1 { + panic!("attempt to divide with overflow"); + } + #[cfg(CONFIG_64BIT)] { self.value / rhs.value @@ -421,7 +433,7 @@ fn div(self, rhs: Self) -> Self::Output { #[cfg(not(CONFIG_64BIT))] { - // SAFETY: This function is always safe to call regardless of the input values + // SAFETY: The checks above exclude a zero divisor and `i64::MIN / -1`. unsafe { bindings::div64_s64(self.value, rhs.value) } } } @@ -615,8 +627,21 @@ pub fn to_jiffies_timeout(self) -> Delta { } /// Return `self % divisor` where `divisor` is in nanoseconds. + /// + /// # Panics + /// + /// Panics if `divisor` is zero, or if `self` represents [`i64::MIN`] + /// nanoseconds and `divisor` is `-1`. #[inline] pub fn rem_nanos(self, divisor: i32) -> Self { + if divisor == 0 { + panic!("attempt to calculate the remainder with a divisor of zero"); + } + + if self.value == i64::MIN && divisor == -1 { + panic!("attempt to calculate the remainder with overflow"); + } + #[cfg(CONFIG_64BIT)] { Self { @@ -628,7 +653,8 @@ pub fn rem_nanos(self, divisor: i32) -> Self { { let mut rem = 0; - // SAFETY: `rem` is in the stack, so we can always provide a valid pointer to it. + // SAFETY: The checks above exclude a zero divisor and `i64::MIN / -1`. + // `&mut rem` provides a valid, aligned, writable pointer for this call. unsafe { bindings::div_s64_rem(self.as_nanos(), divisor, &mut rem) }; Self { -- 2.34.1