From: Greg KH <greg@kroah.com>
To: Jean Delvare <jdelvare@suse.de>
Cc: stable@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH linux-6.18.y] hwmon: (lm90) Consistently use our own mutex
Date: Fri, 30 Oct 2026 09:41:57 +0100 [thread overview]
Message-ID: <2026103057-sinuous-halves-9ba7@gregkh> (raw)
In-Reply-To: <20261030092410.0e585c82@endymion>
On Fri, Oct 30, 2026 at 09:24:10AM +0100, Jean Delvare wrote:
> The backport of commits b09a45601094 ("hwmon: (lm90) Stop work before
> releasing hwmon device") and 873e919e3101 ("hwmon: (lm90) Add lock
> protection to lm90_alert") to stable branch 6.18 makes use of the
> hwmon_lock()/hwmon_unlock() API. While this API is available in
> kernel v6.18, the lm90 driver was not ported to it until v6.19.
> Mixing the use of different locking models within the same driver is
> unsafe and should be avoided.
>
> Update the backports to consistently use the driver's own mutex.
Oh that's going to cause problems over time, right? Why can't we take
the change that did the port instead to make this easier to maintain,
otherwise we will be hitting this problem constantly for any changes for
the next X years that this kernel is alive.
thanks,
greg k-h
next prev parent reply other threads:[~2026-10-30 8:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-30 8:24 [PATCH linux-6.18.y] hwmon: (lm90) Consistently use our own mutex Jean Delvare
2026-10-30 8:41 ` Greg KH [this message]
2026-10-30 18:21 ` Jean Delvare
2026-10-30 18:52 ` Guenter Roeck
2026-10-30 20:54 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026103057-sinuous-halves-9ba7@gregkh \
--to=greg@kroah.com \
--cc=jdelvare@suse.de \
--cc=linux@roeck-us.net \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox