Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Jeremy.Jean@oss.cyber.gouv.fr, Jason@zx2c4.com,
	stable@vger.kernel.org, linux-crypto@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] lib/crypto: arm64: Fix lost Poly1305 carry when resuming NEON" failed to apply to 6.12-stable tree
Date: Sat, 31 Oct 2026 11:58:47 +0100	[thread overview]
Message-ID: <2026103132-crept-dormitory-2414@gregkh> (raw)
In-Reply-To: <20261021164836.GB1879@quark>

On Wed, Oct 21, 2026 at 09:48:36AM -0700, Eric Biggers wrote:
> On Wed, Oct 21, 2026 at 08:48:08AM -0700, Eric Biggers wrote:
> > [+Cc linux-crypto@vger.kernel.org]
> > 
> > On Wed, Oct 21, 2026 at 04:40:37PM +0200, gregkh@linuxfoundation.org wrote:
> > > 
> > > The patch below does not apply to the 6.12-stable tree.
> > > If someone wants it applied there, or to any other stable or longterm
> > > tree, then please email the backport, including the original git commit
> > > id to <stable@vger.kernel.org>.
> > 
> > It's a clean cherry-pick, as git detects the rename of
> > poly1305-armv8.pl.  So there should be no need to require this to be
> > resent.  Also, missing Cc to linux-crypto.
> > 
> > Same for 6.12, 6.6, 6.1, 5.15, and 5.10.
> 
> As I've said before, the reason this keeps happening is that Greg's
> stable scripts perform a cherry-pick by first formatting the commit as a
> patch file with the default 3 lines of context, then applying it with
> 'patch' using the default fuzz of 2.
> 
> (The second step seems to occur in the 'apply_it' script, which isn't
> public.  But based on the observed behavior, it must be what it does.)

That script has been public for decades:
	https://github.com/gregkh/gregkh-linux/blob/master/stable/apply_it

> This process is buggy compared to simply using 'git cherry-pick':

Agreed, see my previous message, we don't use git cherry-pick for this
workflow, sorry.

thanks,

greg k-h

  parent reply	other threads:[~2026-10-31 10:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-21 14:40 FAILED: patch "[PATCH] lib/crypto: arm64: Fix lost Poly1305 carry when resuming NEON" failed to apply to 6.12-stable tree gregkh
2026-10-21 15:48 ` Eric Biggers
2026-10-21 16:48   ` Eric Biggers
2026-10-28 18:20     ` Eric Biggers
2026-10-29 20:35       ` Eric Biggers
2026-10-31 10:58     ` Greg KH [this message]
2026-10-31 10:57   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026103132-crept-dormitory-2414@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=Jason@zx2c4.com \
    --cc=Jeremy.Jean@oss.cyber.gouv.fr \
    --cc=ebiggers@kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox