From: Tristan Madani <tristmd@gmail.com>
To: Brian Norris <briannorris@chromium.org>,
Francesco Dolcini <francesco@dolcini.it>
Cc: linux-wireless@vger.kernel.org, stable@vger.kernel.org,
Tristan Madani <tristan@talencesecurity.com>
Subject: [PATCH wireless 3/3] wifi: mwifiex: cap TLV length in IBSS connected event handler
Date: Sun, 1 Nov 2026 20:58:02 +0000 [thread overview]
Message-ID: <20261101205802.2909524-4-tristmd@gmail.com> (raw)
In-Reply-To: <20261101205802.2909524-1-tristmd@gmail.com>
From: Tristan Madani <tristan@talencesecurity.com>
In the IBSS connected event handler, the buffer-bounded evt_len is
replaced with the TLV header length from the firmware. An inflated
value drives the IE parsing loop past the event buffer.
Cap the TLV-derived length at the remaining event data size.
Fixes: 432da7d243da ("mwifiex: add HT aggregation support for adhoc mode")
Cc: stable@vger.kernel.org
Signed-off-by: Tristan Madani <tristan@talencesecurity.com>
---
drivers/net/wireless/marvell/mwifiex/sta_event.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/wireless/marvell/mwifiex/sta_event.c b/drivers/net/wireless/marvell/mwifiex/sta_event.c
index 1f746e8f6b3e18..3f683698e4a60d 100644
--- a/drivers/net/wireless/marvell/mwifiex/sta_event.c
+++ b/drivers/net/wireless/marvell/mwifiex/sta_event.c
@@ -45,6 +45,8 @@ static int mwifiex_check_ibss_peer_capabilities(struct mwifiex_private *priv,
*/
evt_len = le16_to_cpu(tlv_mgmt_frame->header.len);
curr += (sizeof(*tlv_mgmt_frame) + 12);
+ if (evt_len > event->len - (curr - event->data))
+ evt_len = event->len - (curr - event->data);
} else {
mwifiex_dbg(priv->adapter, MSG,
"management frame tlv not found!\n");
--
2.47.3
prev parent reply other threads:[~2026-11-01 20:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-01 20:57 [PATCH wireless 0/3] wifi: mwifiex: firmware response validation fixes Tristan Madani
2026-11-01 20:58 ` [PATCH wireless 1/3] wifi: mwifiex: validate TID in ADDBA response handler Tristan Madani
2026-11-01 20:58 ` [PATCH wireless 2/3] wifi: mwifiex: validate intf_num in multichannel event handler Tristan Madani
2026-11-01 20:58 ` Tristan Madani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261101205802.2909524-4-tristmd@gmail.com \
--to=tristmd@gmail.com \
--cc=briannorris@chromium.org \
--cc=francesco@dolcini.it \
--cc=linux-wireless@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tristan@talencesecurity.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox