From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793817324; b=xzWyBPUSJzi9LFIervcRAFhRm0xkWdylcbf8spPP4lhMo9QV3LIzvtIL3RqRLepqo5SZ KCtKMAvFGzPmmeuAuDC+OHFUJ6d3eedAlrhDQUqhboDPgRsYWBOZsx/p5S/9AIEs03ZCi sVmR5K89P0/n9p0zjohvf62bdWByGwNfDd7slThgLMGjJ0NLUfUEDg/aTsfovWDEN+U5v Bo1htOteW7I8tQcrPiW7n0cfgI9Sw+C6iEkb8sa08VbvDLNtNbolEayr7skqb8s+szwTJ kq9oRe4t3tKXP/8rNjq/Fv+h5BRiC5o+3iia5Mm5kMf6ReNqjR2ZOyYcE2og5ZyUbJg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793817324; h=Received:DKIM-Signature:Subject:To:Cc:From:Date:Message-ID: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=3+gBBAQ6Sy0t579WklehmMND5ptrRZYJw2z73iwKN0A=; b=pFMqHbxkWHb+C15nObJSEWQMN/z+ep63d4n7jVHaCXcRRFFOb0XG1l7oLjKH026tyHqe rG2jAJhuDDK2qIyJxBivAJ0c8qnuqg+9rZ4zq0QJYYSsor4rmGrM770yFGSTkJQ8yA132 DaHNIxaWKtTChqyRXF7nRuEc6wEVzJwYxOOptv53kMEcix6MVQ+W47LUyqvZM/rfyJz4U f4+FlCBqlVUkcxUhMpwnV+rSyW1awVQgORTKez1fCRAswztLHRmrhecnQmwih3jiWmPEq IDGu0HguvMI2nbi+u4xEEUSfRLBSJtQTiJGk46R+oTfuBzzN4wb0mRcVL7a24P2k8Dw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=YbeYEtoM; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D5A1606D80C for ; Wed, 4 Nov 2026 18:35:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=YbeYEtoM Received: by smtp.kernel.org (Postfix) with ESMTPSA id 786D31F0093A; Wed, 4 Nov 2026 18:35:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1793817323; bh=3+gBBAQ6Sy0t579WklehmMND5ptrRZYJw2z73iwKN0A=; h=Subject:To:Cc:From:Date; b=YbeYEtoMtvB78dtWoedseRz1L0Wgpi0jHzZCtlXikyadjNDIemjLIrn8DruHh4SqZ vIJ6nmDGcJ0+SvGS/7lB7W7EGCOns2x4OkKF0hQiLWokt82hu+boULcEBM/d7eX+Af jST9yds0QKs3NunATjkM81ABf6LZu0RAD2pNfpbo= Subject: FAILED: patch "[PATCH] smb: client: validate the data area in SMB2_read()" failed to apply to 5.15-stable tree To: suruurism@gmail.com,linkinjeon@kernel.org,pc@manguebit.org Cc: From: Date: Wed, 04 Nov 2026 13:35:22 -0500 Message-ID: <2026110422-kitty-unlocking-dd52@gregkh> X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.15-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.15.y git checkout FETCH_HEAD git cherry-pick -x 2ec9cdf469dd32bcf33073aeb30c08e9356e0ca1 # git commit -s git send-email --to '' --in-reply-to '2026110422-kitty-unlocking-dd52@gregkh' --subject-prefix 'PATCH 5.15.y' 'HEAD^..' Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 2ec9cdf469dd32bcf33073aeb30c08e9356e0ca1 Mon Sep 17 00:00:00 2001 From: Abdifatah Suruur Date: Thu, 22 Oct 2026 06:53:29 +0300 Subject: [PATCH] smb: client: validate the data area in SMB2_read() SMB2_read() copies le32_to_cpu(rsp->DataLength) bytes from (char *)rsp + rsp->DataOffset without checking that the range lies within the response actually received. A READ response with DataOffset == 0 makes smb2_get_data_area_len() zero the data length, so smb2_check_message() accepts a frame as short as the fixed response, while SMB2_read() still uses the server-supplied DataLength, capped only by CIFS_MAX_MSGSIZE and the caller's length. A malicious server can answer the synchronous read used by the mfsymlinks (or SFU) symlink parser with an 81-byte READ response carrying DataOffset 0 and DataLength 1067, making the client copy 1067 bytes from a 448-byte receive object (KASAN slab-out-of-bounds; up to 16 KiB in the general case). Clamp a zero (or header-overlapping) DataOffset to read_rsp_size, as handle_read_data() does for the asynchronous path, and reject the response unless DataOffset + DataLength fits within rsp_iov.iov_len. The SMB1 helper was fixed the same way in 5be5bdda5863. Fixes: d8e050398d23 ("CIFS: Add readpage support for SMB2") Cc: stable@vger.kernel.org Signed-off-by: Abdifatah Suruur Reviewed-by: Namjae Jeon Signed-off-by: Paulo Alcantara diff --git a/fs/smb/client/smb2pdu.c b/fs/smb/client/smb2pdu.c index 06a6ca0dc098..f85595136ef8 100644 --- a/fs/smb/client/smb2pdu.c +++ b/fs/smb/client/smb2pdu.c @@ -4948,6 +4948,7 @@ SMB2_read(const unsigned int xid, struct cifs_io_parms *io_parms, struct kvec iov[1]; struct kvec rsp_iov; unsigned int total_len; + u16 data_offset; int flags = CIFS_LOG_ERROR; struct cifs_ses *ses = io_parms->tcon->ses; @@ -5007,8 +5008,29 @@ SMB2_read(const unsigned int xid, struct cifs_io_parms *io_parms, *nbytes = 0; } + data_offset = rsp->DataOffset; + if (data_offset < io_parms->server->vals->read_rsp_size) { + /* + * win2k8 sometimes sends an offset of 0 when the read is beyond + * the EOF. Treat it as if the data starts just after the header, + * as handle_read_data() does. + */ + cifs_dbg(FYI, "data offset %u inside read response header\n", + data_offset); + data_offset = io_parms->server->vals->read_rsp_size; + } + + /* The data area must lie within the response actually received */ + if (*nbytes && (size_t)data_offset + *nbytes > rsp_iov.iov_len) { + cifs_dbg(FYI, "bad data offset %u length %u for response of %zu\n", + data_offset, *nbytes, rsp_iov.iov_len); + rc = smb_EIO2(smb_eio_trace_read_bad_offset, + data_offset, *nbytes); + *nbytes = 0; + } + if (*buf) { - memcpy(*buf, (char *)rsp + rsp->DataOffset, *nbytes); + memcpy(*buf, (char *)rsp + data_offset, *nbytes); free_rsp_buf(resp_buftype, rsp_iov.iov_base); } else if (resp_buftype != CIFS_NO_BUFFER) { *buf = rsp_iov.iov_base;