From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793801863; b=XFY/xU6twJBo++iyZK9Ol1JrfV7fOZGXFcrq9Pn9MRjxf1iiuBoORjqVboHVpp7J+MiI utLs2CFW2oEao/3v8Joi084btW0uAISclxAy3FzsbA0G1b2v0AnMd9ATF2iX541hKMEK2 8im9bCDBC2UBelZd39JrhiqBk0UDeNAhqZ3y7e7CXO7+3GtcJTl2/iv19kFa9YjPKyc5w uKrkN0lvEdrjp9GTGdmy1QVUN0RahKOqX0NfWNQAc41QYOgqpOXrPnGTPUMVjTm6yTqUE tSRsc14tKWBBuEIoLGJ39WJgYrOBKOeAHMeEQt14Mbv3mFROBhwgWO8LeQGlW1XvBrQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793801863; h=Received:DKIM-Signature:Subject:To:Cc:From:Date:Message-ID: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=Nrxz1K9L+6yYGNWnIO0d1Rs6JaGPA5BcFcoLxz8XYHM=; b=0DbnZFAorKXH+aAzOS/lImqPYa0zVFJSiz4u1Ig6wcL7k856Accd07jux2Ws0F5F7Izi EEYalmA8sO9e5Qn+GCPEkpEIredGst3dHjrW2Rq+X86bLFWZiBj+CGeGULoTF9zNShmS0 it1Pz+wugXcaIKm8SmcezkoFVO2ArxJGp7ceeLbnTCn6SV7V7M9fyuJKG0y4FVfd/H042 XWN7HMF2LcgsOxsovwc6oxCKrxLf/FsVCKfY1u47otalHVgZr6g2q2xlu7fu0OZUzYPc6 2CCYRc+O42yo4cITeOSRXt9qeFi8ZGJ3HA+1Vyl9Ffe0JN2jtsLiaObd+xy+h/dLPHg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=S+hGvXzi; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC0DA606A333 for ; Wed, 4 Nov 2026 14:17:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=S+hGvXzi Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E5641F000C1; Wed, 4 Nov 2026 14:17:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1793801862; bh=Nrxz1K9L+6yYGNWnIO0d1Rs6JaGPA5BcFcoLxz8XYHM=; h=Subject:To:Cc:From:Date; b=S+hGvXziYbKUhdKr5rOnZuoSCmm+KdoRcb76pZA1RgssmyEsM6TS7ZLVHHHiNxI0E OsZ4184ViX64y71Sl/aH6YVOZX8zj9enby413X5VtVHhBzJYN+nvpwa+XF0kRdTY64 D++IJ/6KNyXEpq3ak3MEdrSQKU9Bp1UFGYU/21Sk= Subject: FAILED: patch "[PATCH] media: marvell: mcam: stop DMA and cancel s_bh_work before" failed to apply to 5.10-stable tree To: fanwu01@zju.edu.cn,hverkuil+cisco@kernel.org Cc: From: Date: Wed, 04 Nov 2026 15:17:30 +0100 Message-ID: <2026110430-duplicity-rehab-e3ce@gregkh> X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y git checkout FETCH_HEAD git cherry-pick -x 0f29f84317c1e35f6a9265277be33e60d3fc8c1c # git commit -s git send-email --to '' --in-reply-to '2026110430-duplicity-rehab-e3ce@gregkh' --subject-prefix 'PATCH 5.10.y' 'HEAD^..' Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 0f29f84317c1e35f6a9265277be33e60d3fc8c1c Mon Sep 17 00:00:00 2001 From: Fan Wu Date: Fri, 7 Aug 2026 05:35:53 +0000 Subject: [PATCH] media: marvell: mcam: stop DMA and cancel s_bh_work before freeing DMA buffers In vmalloc mode the frame-completion IRQ queues mcam_frame_work() on cam->s_bh_work, which memcpy()s from the dma_bufs[] that mcam_free_dma_bufs() frees with dma_free_coherent(). mccic_shutdown() frees those buffers without stopping the controller, so while streaming a late frame IRQ can re-arm the work after the buffers are gone, causing a use-after-free. Stop the controller in mccic_shutdown() when streaming is still active (gated on an open fd, which holds a runtime-PM reference, so the device is powered), cancel s_bh_work in mcam_free_dma_bufs(), and move INIT_WORK() into mccic_register() before the device can be published. Fixes: 67a8dbbc4e04 ("[media] marvell-cam: Basic working MMP camera driver") Cc: stable@vger.kernel.org Signed-off-by: Fan Wu Signed-off-by: Hans Verkuil diff --git a/drivers/media/platform/marvell/mcam-core.c b/drivers/media/platform/marvell/mcam-core.c index c1e8a2a3012d..2d0b8b60c509 100644 --- a/drivers/media/platform/marvell/mcam-core.c +++ b/drivers/media/platform/marvell/mcam-core.c @@ -406,6 +406,8 @@ static void mcam_free_dma_bufs(struct mcam_camera *cam) { int i; + cancel_work_sync(&cam->s_bh_work); + for (i = 0; i < cam->nbufs; i++) { dma_free_coherent(cam->dev, cam->dma_buf_size, cam->dma_bufs[i], cam->dma_handles[i]); @@ -1306,7 +1308,6 @@ static int mcam_setup_vb2(struct mcam_camera *cam) break; case B_vmalloc: #ifdef MCAM_MODE_VMALLOC - INIT_WORK(&cam->s_bh_work, mcam_frame_work); vq->ops = &mcam_vb2_ops; vq->mem_ops = &vb2_vmalloc_memops; cam->dma_setup = mcam_ctlr_dma_vmalloc; @@ -1864,6 +1865,12 @@ int mccic_register(struct mcam_camera *cam) goto out; } +#ifdef MCAM_MODE_VMALLOC + /* Init before sensor bind: armed by IRQ, cancelled on probe-error paths. */ + if (cam->buffer_mode == B_vmalloc) + INIT_WORK(&cam->s_bh_work, mcam_frame_work); +#endif + mutex_init(&cam->s_mutex); cam->state = S_NOTREADY; mcam_set_config_needed(cam, 1); @@ -1922,10 +1929,15 @@ void mccic_shutdown(struct mcam_camera *cam) * take it down again will wedge the machine, which is frowned * upon. */ + mutex_lock(&cam->s_mutex); if (!list_empty(&cam->vdev.fh_list)) { cam_warn(cam, "Removing a device with users!\n"); + /* Stop so the IRQ can't re-arm s_bh_work after the buffers are freed. */ + if (cam->state == S_STREAMING) + mcam_ctlr_stop_dma(cam); sensor_call(cam, core, s_power, 0); } + mutex_unlock(&cam->s_mutex); if (cam->buffer_mode == B_vmalloc) mcam_free_dma_bufs(cam); v4l2_ctrl_handler_free(&cam->ctrl_handler);