From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793881212; b=zogsZiSNLy2A47n1ZpNXRW2AJPcx/ZemtocJ67iQOyHloD3Fm5JFJLY6pjfu9mkluIpI 7ryvLZSJN1DQUIAYxjWIBXaxy2ZUKabkbCGa4zlOOV/iurh+RmLozsBly9jBTpGnWSP8I DRGelkjZOI/ybVIZwCq7j8QYyfLV8l8HPu3/XoP1YosSVMgKxryeabAvaVm4oB1AqWri7 noXBxBlPYIQJak76pd2vBjl9IYomq3ZvhLM1RPivLgTnaO3T3XDaA9Wu6i6CYEcMqS/BJ acwO/fgkZbgsrAmK4D5QHSwGPyzZAz/Lb32CaBNIpEeqCa5GmmiEwBcmQ0YLRheMK9g== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793881212; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:MIME-Version:Content-Transfer-Encoding; bh=/aRlp93nRJ+CxDWUQ7PJ4AILA7Cqk/ssmW6YyG95Ui4=; b=wxAXToR4vD0J310lSTXET2dNfzKkDNmb8usgiC9GCK+pbF3ysvOej6rnhfk3WXRNQTVM wLirGWxVOYA0uTSwvZfkDqVFvFvkaQKBUuZX0n9h0pS5F1mPD551m1UjVB2gIVrYhhqZy 3h8QJxGozp9QKgO1Itbr9XohLwSbOedx3Y6ZxyFzWSZNWCf1X4CXyHY8RV7y1gZyWDaxi 5b5EC2LcyLtxPUkWW1oszJOxm2LGILFMZ8fbz4E+/kLJAAAhsscTS9WpokgxgIG5Wguog OlWCRnVDfMT7ULCU0eW95WAkcS7JwD+RImRB/qnVjpmtqA8NcB9NQnDitXvq82jXk4Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=jbGmGu4N; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C744606D80C for ; Thu, 5 Nov 2026 12:20:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=jbGmGu4N Received: by smtp.kernel.org (Postfix) with ESMTPSA id 67B181F00A1B; Thu, 5 Nov 2026 12:20:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793881211; bh=/aRlp93nRJ+CxDWUQ7PJ4AILA7Cqk/ssmW6YyG95Ui4=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=jbGmGu4NI9MF/3ZpmAMuKvbcfxNejPCPTHOoFL9vTc8+qWKpA57YlP1kPbQeuL7l4 aIaBD6jMVyLfmpwYq8oSBimZ53UOmGT37GBNoQ7d6iKA1Gid8CGGZg24yVGYgDTdF3 2hXwZR4Hj3ZIykEP+OW6aH6rLmoBFQOjwq11PW0mXhLI63yiiKUwEhvU6nK/H1EgUt jTDleYc6+n1BMXDDk741ZZha0Ko881XeIAMBQbAKVjQva+Q97W4ypISUHjy882BCii 7ZM4pBpdXqh+4ONyX4n/Vyl9RUn30T4Rv97+CkS9HZuB7lbaXkn1pBD7Eh8sJYizv4 DXkQ0dphYCmzQ== From: Sasha Levin To: stable@vger.kernel.org Cc: Sean Young , Hans Verkuil , Sasha Levin Subject: [PATCH 5.10.y] media: rc: Fix race condition during rc_register_device() Date: Thu, 5 Nov 2026 07:20:09 -0500 Message-ID: <20261105121918.1275663-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026110406-streak-snorkel-cd41@gregkh> References: <2026110406-streak-snorkel-cd41@gregkh> X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Sean Young [ Upstream commit ec7cb49871e5c4f85d57290320c50ee0bae4db84 ] Device drivers can call ir_raw_event_store() or ir_raw_event_handle() right after rc_allocate_device(). This means that while rc_register_device() is being called, those functions can be called from e.g. interrupt handlers. Currently dev->raw is being allocated and populated by ir_raw_event_prepare() which is called from rc_register_device(). This is not done in a safe way, e.g. dev->raw is being set before the raw members are populated. Call ir_raw_event_prepare() from rc_allocate_device() instead. Fixes: a3572c34da8d ("V4L/DVB: ir-core: Add logic to decode IR protocols at the IR core") Signed-off-by: Sean Young Cc: stable@vger.kernel.org Reviewed-by: Hans Verkuil [ sashal: adjusted context for kzalloc() calls instead of kzalloc_obj() ] Signed-off-by: Sasha Levin --- drivers/media/rc/rc-ir-raw.c | 20 +------------------- drivers/media/rc/rc-main.c | 19 +++++++++++-------- 2 files changed, 12 insertions(+), 27 deletions(-) diff --git a/drivers/media/rc/rc-ir-raw.c b/drivers/media/rc/rc-ir-raw.c index c65bba4ec4739..d695ca6eaa579 100644 --- a/drivers/media/rc/rc-ir-raw.c +++ b/drivers/media/rc/rc-ir-raw.c @@ -73,9 +73,6 @@ static int ir_raw_event_thread(void *data) */ int ir_raw_event_store(struct rc_dev *dev, struct ir_raw_event *ev) { - if (!dev->raw) - return -EINVAL; - dev_dbg(&dev->dev, "sample: (%05dus %s)\n", ev->duration, TO_STR(ev->pulse)); @@ -104,9 +101,6 @@ int ir_raw_event_store_edge(struct rc_dev *dev, bool pulse) ktime_t now; struct ir_raw_event ev = {}; - if (!dev->raw) - return -EINVAL; - now = ktime_get(); ev.duration = ktime_to_us(ktime_sub(now, dev->raw->last_event)); ev.pulse = !pulse; @@ -131,9 +125,6 @@ int ir_raw_event_store_with_timeout(struct rc_dev *dev, struct ir_raw_event *ev) ktime_t now; int rc = 0; - if (!dev->raw) - return -EINVAL; - now = ktime_get(); spin_lock(&dev->raw->edge_spinlock); @@ -168,9 +159,6 @@ EXPORT_SYMBOL_GPL(ir_raw_event_store_with_timeout); */ int ir_raw_event_store_with_filter(struct rc_dev *dev, struct ir_raw_event *ev) { - if (!dev->raw) - return -EINVAL; - /* Ignore spaces in idle mode */ if (dev->idle && !ev->pulse) return 0; @@ -202,9 +190,6 @@ EXPORT_SYMBOL_GPL(ir_raw_event_store_with_filter); */ void ir_raw_event_set_idle(struct rc_dev *dev, bool idle) { - if (!dev->raw) - return; - dev_dbg(&dev->dev, "%s idle mode\n", idle ? "enter" : "leave"); if (idle) { @@ -228,7 +213,7 @@ EXPORT_SYMBOL_GPL(ir_raw_event_set_idle); */ void ir_raw_event_handle(struct rc_dev *dev) { - if (!dev->raw || !dev->raw->thread) + if (!dev->raw->thread) return; wake_up_process(dev->raw->thread); @@ -613,9 +598,6 @@ EXPORT_SYMBOL(ir_raw_encode_carrier); */ int ir_raw_event_prepare(struct rc_dev *dev) { - if (!dev) - return -EINVAL; - dev->raw = kzalloc(sizeof(*dev->raw), GFP_KERNEL); if (!dev->raw) return -ENOMEM; diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc-main.c index 169a0b632a616..bce7a02c61303 100644 --- a/drivers/media/rc/rc-main.c +++ b/drivers/media/rc/rc-main.c @@ -1699,14 +1699,24 @@ static const struct device_type rc_dev_type = { struct rc_dev *rc_allocate_device(enum rc_driver_type type) { struct rc_dev *dev; + int ret; dev = kzalloc(sizeof(*dev), GFP_KERNEL); if (!dev) return NULL; + if (type == RC_DRIVER_IR_RAW) { + ret = ir_raw_event_prepare(dev); + if (ret < 0) { + kfree(dev); + return NULL; + } + } + if (type != RC_DRIVER_IR_RAW_TX) { dev->input_dev = input_allocate_device(); if (!dev->input_dev) { + ir_raw_event_free(dev); kfree(dev); return NULL; } @@ -1722,6 +1732,7 @@ struct rc_dev *rc_allocate_device(enum rc_driver_type type) spin_lock_init(&dev->rc_map.lock); spin_lock_init(&dev->keylock); } + mutex_init(&dev->lock); dev->dev.type = &rc_dev_type; @@ -1916,12 +1927,6 @@ int rc_register_device(struct rc_dev *dev) dev->sysfs_groups[attr++] = &rc_dev_wakeup_filter_attr_grp; dev->sysfs_groups[attr++] = NULL; - if (dev->driver_type == RC_DRIVER_IR_RAW) { - rc = ir_raw_event_prepare(dev); - if (rc < 0) - goto out_minor; - } - if (dev->driver_type != RC_DRIVER_IR_RAW_TX) { rc = rc_prepare_rx_device(dev); if (rc) @@ -1978,8 +1983,6 @@ int rc_register_device(struct rc_dev *dev) out_rx_free: ir_free_table(&dev->rc_map); out_raw: - ir_raw_event_free(dev); -out_minor: ida_free(&rc_ida, minor); return rc; } -- 2.53.0