From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793932137; b=X0vsSbtaZcX1+d/V6nfyg+3T0t5t7a1AncReMLKw/gS96N7KsvzJE/kZ19KqBSUznAnP JGRBiOVrPA38d0lPPukARIGDQ+kILdi3Nq0jlbgzmNWjMxPm3gVo2FFz2O7n/20Pj6vOH AFdf+G2OzTXT14obB2VjheHJxjKgRqEZ5Hwx+Vev2zpTS4pDsP7Rq7SdAiqUvyI2rsOY3 I2xEhQ2zj568g/81sYEX6Ufs9uDv3YCSjOdrUFQHZrXPo7rUEhQIHO+s/Hkrj4O4NWGNO 7y+CdOQWOB4uNbRmZDJM3FQJN8IbH8MBBaGxzV+teDhmVMJkuJ+AIUElUApl5OiFvxA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793932137; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:MIME-Version:Content-Transfer-Encoding; bh=gVzjapyzThtpHqYy+zr59ZaHq8o+YwoG8UCKDQvTEjY=; b=oThO3+eJ9bZGcXBx9HMuLmqqVf0ST77BZjAol6lB0jkJxvLdP+CWqRKffdY27GQ3seyh pK/dbqQi+9T18L1JC6ek10VpgbQ4M79KcA5C4znHHMsnDkWaWqTLnzx/khJYWv7aZ/b8j AxkXNLKkqqUasXsWesFSCqnUPA6sXqs1zZ9jheYqhgB+ZjS+UGU8YCnY4ejo6Am+hDgV5 XNqXknrTbfTIutbBp3pgQpte8JRDKiNaYaIXvzBpYlspDKSBqWM0ycMcsGCLMm0eVm7Xm co98jAv6mecLm3dvVq//2R7goMuGectdofyYexbouEQebW4qMUfkjylai1Z0jEIwreQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=DBYgjl0Z; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66EBB606A31B for ; Fri, 6 Nov 2026 02:28:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=DBYgjl0Z Received: by smtp.kernel.org (Postfix) with ESMTPSA id 801891F0089F; Fri, 6 Nov 2026 02:28:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793932137; bh=gVzjapyzThtpHqYy+zr59ZaHq8o+YwoG8UCKDQvTEjY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=DBYgjl0ZRptryXgIwlKIFGx01/+SHFJrU0C3jcPYVN/oBOHnqImhqb0O1wEedOn/5 3/M7dIG3RIUFj8Nxh2GJckRbx/fJy0EMKKrusIsA4y3hKMG9r6t3b2CMpSzWkmHICX 4spJBgWm+axdeHof7rSAFFUdy/KM5W2AvVJtsiDVH2SBVVol390hFcmPWmltzKSMHW UMv1RQrDs+m23ZcrKvLcLWfzry9wS4p132eo+Vt5W/DIutEuCd6d4dO23CtVUTxwvm ZOxbBpjEeO1vJMH7fvQOWyoHaxbHzGNtkBHAaygQ4QFYV0iw4bNHSGu0o8u+gPEI9W 9Zf/mrrAyuavg== From: Sasha Levin To: stable@vger.kernel.org Cc: Chuck Lever , syzbot+d5c77cabf7a3492aa650@syzkaller.appspotmail.com, Sasha Levin Subject: [PATCH 7.3.y 1/2] NFSD: Move the cld upcall message out of the caller's stack frame Date: Thu, 5 Nov 2026 21:28:53 -0500 Message-ID: <20261106022847.3726614-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026110452-janitor-overdraft-33cb@gregkh> References: <2026110452-janitor-overdraft-33cb@gregkh> X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Chuck Lever [ Upstream commit c559b05610557fa3c6c30259261f6dae523b3f23 ] __cld_pipe_upcall() builds its struct rpc_pipe_msg on the stack and hands it to rpc_queue_upcall(), which links it into a list the pipe owns until the message is released. Only the completion rules keep that frame alive for as long as the pipe refers to it, and the peer that drives those rules is an untrusted userspace daemon. The gss and idmap upcalls do not take that on: each keeps the message in the object it already allocates. Do the same here and put the message in struct cld_upcall, beside the reply buffer it carries. cld_pipe_destroy_msg() then reaches the upcall from the message directly rather than through msg->data. Reported-by: syzbot+d5c77cabf7a3492aa650@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=d5c77cabf7a3492aa650 Link: https://patch.msgid.link/20260901-alemi-v2-2-e163f94a3a6e@kernel.org Signed-off-by: Chuck Lever Stable-dep-of: 2a83fcb50f3c ("NFSD: Complete a cld upcall when the daemon closes the pipe") Signed-off-by: Sasha Levin --- fs/nfsd/nfs4recover.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/fs/nfsd/nfs4recover.c b/fs/nfsd/nfs4recover.c index 6441e54283a35..6b0c51b8938b5 100644 --- a/fs/nfsd/nfs4recover.c +++ b/fs/nfsd/nfs4recover.c @@ -649,6 +649,7 @@ struct cld_upcall { struct completion cu_done; /* daemon has read the whole upcall; protected by cn_lock */ bool cu_inflight; + struct rpc_pipe_msg cu_pipe_msg; union { struct cld_msg_hdr cu_hdr; struct cld_msg cu_msg; @@ -660,22 +661,22 @@ static int __cld_pipe_upcall(struct rpc_pipe *pipe, void *cmsg, struct nfsd_net *nn) { int ret; - struct rpc_pipe_msg msg; struct cld_upcall *cup = container_of(cmsg, struct cld_upcall, cu_u); + struct rpc_pipe_msg *msg = &cup->cu_pipe_msg; - memset(&msg, 0, sizeof(msg)); - msg.data = cmsg; - msg.len = nn->client_tracking_ops->msglen; + memset(msg, 0, sizeof(*msg)); + msg->data = cmsg; + msg->len = nn->client_tracking_ops->msglen; - ret = rpc_queue_upcall(pipe, &msg); + ret = rpc_queue_upcall(pipe, msg); if (ret < 0) { goto out; } wait_for_completion(&cup->cu_done); - if (msg.errno < 0) - ret = msg.errno; + if (msg->errno < 0) + ret = msg->errno; out: return ret; } @@ -848,9 +849,8 @@ cld_pipe_downcall(struct file *filp, const char __user *src, size_t mlen) static void cld_pipe_destroy_msg(struct rpc_pipe_msg *msg) { - struct cld_msg *cmsg = msg->data; - struct cld_upcall *cup = container_of(cmsg, struct cld_upcall, - cu_u.cu_msg); + struct cld_upcall *cup = container_of(msg, struct cld_upcall, + cu_pipe_msg); struct cld_net *cn = cup->cu_net; /* -- 2.53.0