From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793974434; b=H0LiyoPHpyidlwOFAYFJ7m6QUSalojvzWlg+Qsrx8EfOdX+xZFR9kIDSdKD+Nguogy+6 tZkTIknPGU01kLFKz+b2CqhC3SXtjZ47svKhB5+YvhtCVcHoD4rxAFBCEPq91rfzhen5v Wj1qRQ8GxfGs8M2uG+nlLyfocOhriRi0JKcG+eSL/GIAMnHXLyfvnIkJ2ZO5qg+a48j1M jep7Qx44utNOoMCmFpURil1pB9b8O4S9xdW9kfYhHz0foWfVu4g9J1G2kMIbavsJeI8Hy B7gk45cte1PlkQOC6T94pErceZSMQOhrb8GzGJa9rZOvpm75nWHJRHktp9E9TodeNCQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793974434; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:MIME-Version:Content-Transfer-Encoding; bh=xu1baS48ye+qwWEvBqTZfDWU1JYVsCbOka7SRSIYCuY=; b=cYXIeRUwJzsh1BW9xG+J11Ot+zLwYVa2C3xPxHGSd/RoFU/hZaWJYuCshuKu/iL1y4/Y nNBMzCHUetJ6RZdeouCwIrVB9ilyxyIMKHdq0qPHGAEw9tPl8fXkZmhsq2vtKXuU/AeiQ 0zDnwpD8Is8XvGMUw3fP1yCXJ5jJZs9hNYBLenw4o51UbhvNLnLjBEX+So1IQqlGFUNb0 4lgqHm96A1YLJTljG8QJyluhsSv9/x7SAgKcDfSHwIe9AG19YyGRAM1c6lQxZrv/ezjr7 7mzHSHMz88QtsSOcUpCUISnOhi9mmDEeNIXu6/oD8MewOyGdez7LKZP5h9MRRdvX3Gg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=EtZTG90C; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77697606A336 for ; Fri, 6 Nov 2026 14:13:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=EtZTG90C Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4919C1F008A1; Fri, 6 Nov 2026 14:13:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793974434; bh=xu1baS48ye+qwWEvBqTZfDWU1JYVsCbOka7SRSIYCuY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=EtZTG90Cs+WoHNOkvO/Egi5vgAeX3ucN+phQQbqPFr3pMcbuO92jw+f0/XIkRZnt7 Z1R/xzul83bsfb2i4ErV2ktddPy+vw+n3FQdriy5bLQ9dlW/xb6OwxyA3cVgHTbkmc bAVorGTHDweWwDth28wfjY/2CbGb0wJ5N0Iv4RuGPfxKaaezQjbkdsQ1RcxNbwzM+f panmI4FwqtmlFJiGoRZJocvyE619RodJZE0M2jnXvdCWF9cTCuB57XCuPNwzMdvJe8 TCGIwpmlX90JN+KB0hQsFdX/+SSUMuIJH6vKUlk2PPYwkckVRbodmAg9sYrHZKCTbY NBdN5DMB3VukA== From: Sasha Levin To: stable@vger.kernel.org Cc: David Howells , Marc Dionne , Eric Dumazet , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Simon Horman , linux-afs@lists.infradead.org, Sasha Levin Subject: [PATCH 6.6.y] afs: Fix afs to abort the rxrpc call on send error Date: Fri, 6 Nov 2026 09:13:51 -0500 Message-ID: <20261106141255.246531-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026110414-occultist-maturity-4b0c@gregkh> References: <2026110414-occultist-maturity-4b0c@gregkh> X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: David Howells [ Upstream commit 3e6af08a571fe2943a006acf3e890f36322602bc ] Fix afs_send_empty_reply() and afs_send_simple_reply() to always try to abort the rxrpc call rather than just aborting on -ENOMEM and otherwise abandoning it. If the call is already complete due to network failure or a received abort, this will do nothing. Also make afs_make_call() always abort on send error; again, it does nothing if the rxrpc call is already dead. Fixes: 08e0e7c82eea ("[AF_RXRPC]: Make the in-kernel AFS filesystem use AF_RXRPC.") Link: https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260824091645.415423-1-dhowells%40redhat.com Signed-off-by: David Howells cc: Marc Dionne cc: Eric Dumazet cc: "David S. Miller" cc: Jakub Kicinski cc: Paolo Abeni cc: Simon Horman cc: linux-afs@lists.infradead.org cc: stable@vger.kernel.org Link: https://patch.msgid.link/20261006133011.531806-6-dhowells@redhat.com Signed-off-by: Paolo Abeni [ sashal: adapted rxrpc_kernel_send_data() calls to retain the explicit length argument ] Signed-off-by: Sasha Levin --- fs/afs/rxrpc.c | 49 +++++++++++++----------------------- include/trace/events/rxrpc.h | 2 +- 2 files changed, 18 insertions(+), 33 deletions(-) diff --git a/fs/afs/rxrpc.c b/fs/afs/rxrpc.c index 523272b86ad46..02bb3ad472eec 100644 --- a/fs/afs/rxrpc.c +++ b/fs/afs/rxrpc.c @@ -442,10 +442,8 @@ void afs_make_call(struct afs_addr_cursor *ac, struct afs_call *call, gfp_t gfp) return; error_do_abort: - if (ret != -ECONNABORTED) - rxrpc_kernel_abort_call(call->net->socket, rxcall, - RX_USER_ABORT, ret, - afs_abort_send_data_error); + rxrpc_kernel_abort_call(call->net->socket, rxcall, + RX_USER_ABORT, ret, afs_abort_send_data_error); if (call->async) { afs_see_call(call, afs_call_trace_async_abort); return; @@ -872,6 +870,7 @@ void afs_send_empty_reply(struct afs_call *call) { struct afs_net *net = call->net; struct msghdr msg; + int ret; _enter(""); @@ -884,21 +883,13 @@ void afs_send_empty_reply(struct afs_call *call) msg.msg_controllen = 0; msg.msg_flags = 0; - switch (rxrpc_kernel_send_data(net->socket, call->rxcall, &msg, 0, - afs_notify_end_reply_tx)) { - case 0: - _leave(" [replied]"); - return; - - case -ENOMEM: - _debug("oom"); + ret = rxrpc_kernel_send_data(net->socket, call->rxcall, &msg, 0, + afs_notify_end_reply_tx); + if (ret < 0) { rxrpc_kernel_abort_call(net->socket, call->rxcall, - RXGEN_SS_MARSHAL, -ENOMEM, - afs_abort_oom); - fallthrough; - default: - _leave(" [error]"); - return; + RXGEN_SS_MARSHAL, ret, + afs_abort_send_error); + afs_set_call_complete(call, ret, RXGEN_SS_MARSHAL); } } @@ -910,7 +901,7 @@ void afs_send_simple_reply(struct afs_call *call, const void *buf, size_t len) struct afs_net *net = call->net; struct msghdr msg; struct kvec iov[1]; - int n; + int ret; _enter(""); @@ -925,21 +916,15 @@ void afs_send_simple_reply(struct afs_call *call, const void *buf, size_t len) msg.msg_controllen = 0; msg.msg_flags = 0; - n = rxrpc_kernel_send_data(net->socket, call->rxcall, &msg, len, - afs_notify_end_reply_tx); - if (n >= 0) { - /* Success */ - _leave(" [replied]"); - return; - } - - if (n == -ENOMEM) { - _debug("oom"); + ret = rxrpc_kernel_send_data(net->socket, call->rxcall, &msg, len, + afs_notify_end_reply_tx); + if (ret < 0) { rxrpc_kernel_abort_call(net->socket, call->rxcall, - RXGEN_SS_MARSHAL, -ENOMEM, - afs_abort_oom); + RXGEN_SS_MARSHAL, ret, + afs_abort_send_error); + afs_set_call_complete(call, ret, RXGEN_SS_MARSHAL); + _leave(" [error]"); } - _leave(" [error]"); } /* diff --git a/include/trace/events/rxrpc.h b/include/trace/events/rxrpc.h index 8cbec303cb505..1dbeabf143347 100644 --- a/include/trace/events/rxrpc.h +++ b/include/trace/events/rxrpc.h @@ -20,10 +20,10 @@ /* AFS errors */ \ EM(afs_abort_general_error, "afs-error") \ EM(afs_abort_interrupted, "afs-intr") \ - EM(afs_abort_oom, "afs-oom") \ EM(afs_abort_op_not_supported, "afs-op-notsupp") \ EM(afs_abort_probeuuid_negative, "afs-probeuuid-neg") \ EM(afs_abort_send_data_error, "afs-send-data") \ + EM(afs_abort_send_error, "afs-send-error") \ EM(afs_abort_unmarshal_error, "afs-unmarshal") \ /* rxperf errors */ \ EM(rxperf_abort_general_error, "rxperf-error") \ -- 2.53.0