From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794046006; b=D0uJHHKZbTLpPMlt6hL0/OvmjffoQ0O/RhE7jsYNLqeQCeiV5DBvl7Wkvsda8stD4jyX B9jbERHtpjYg93UdYacM7O0W5hzFTH0uKVREO7cs5Kq7f/G35CsB/PFlkfmmzoRCGd1Ug WGZjQxLrlAh7V4wLHySCxSK3BB6qnwe5i2CXMbAnFhNflqE9FQHJJibPAOHy0tL/+Dtw+ uBsEfj83qqlQ+RsoRj1uEbbji0I1ZOqioxyUrW2tbj/fWECxOTtjcp04VFMnWHIzpYw/G cxxjJGIDClmDSpS11L2BIbyv7h2/ONqdGfMglKr9f4Mq/cpVLps8MRGz3VZctI9cFkg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794046006; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=mYm91lRxYoIl/ath7QwXbs4+gplzyFEdSgEozxoHAMg=; b=nUDxm/uKZ9NRQgiUJF/ihsBFNBZzxRT2kELVHhe6KZolNL7/X0IvGm94/WlmkXtKXX+T yUeGM4IHB6xkqYEPuP+k5Ht4Ia/SY8AdCMSp4q6RFaKlT9kuQQSEqy06UXFcHln7mMhe1 9NuxpVJe+gKELt1mx4jXB4JLkRYJjl7UYV9RGSYOkas1aIuj1QrsIZPCqMgmQm9YD6t6F 4gSCtObr9O+9EzuUCPX32EFYBWuNvotU/g/iXx7gWGz0BU1ll89L89MgBLcM6jBj/ZVwK vbPUIHc7QrY+7My5Bz+H2f3o6wm6ppUtw1e9DVgq6a/x/X3PhgMBujBKSwiLpOsu84A== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=nALwX0e4; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F9C1606A326 for ; Sat, 7 Nov 2026 10:06:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=nALwX0e4 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6C4511F0089F; Sat, 7 Nov 2026 10:06:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794046005; bh=mYm91lRxYoIl/ath7QwXbs4+gplzyFEdSgEozxoHAMg=; h=From:To:Cc:Subject:Date; b=nALwX0e4AahXt4cR54Da/zcbP4EvMdfjOfos8s1cjgBTTZoJpCrePmd60yq7cipBK GztjZvSVxKLM8JMcOj7+s4Nk9MDQA0+yMVsFmZ97a5gzM6uYJ+qyWETXvrSkT+zpHT Fm6nB9cbaxeT6Xtm3hCnmgLZalFU7DPaQCA5egRAI/5S0GGn/YXUhAkJfIuWSDHjnP jwDhAAXq5bksOl6dkyyUHX9Qvcr4EuTx/W1yqf0zOIOqlRIT4c3SPseRaauuUVYGCE tCkXDT3CiW9uOaNfGfaLixpCwokxZjJWyRWRnoHdklTcScZvV7TjCZQjyj6IZvM3ac 1W8Vn5HeuT+wA== From: Sasha Levin To: fabio.cesari@gmail.com, joshua.crofts1@gmail.com, jonathan.cameron@oss.qualcomm.com Cc: stable@vger.kernel.org Subject: FAILED: patch "[PATCH] iio: light: isl29028: fix runtime PM reference leak on error paths" failed to apply to 6.18-stable tree Date: Sat, 7 Nov 2026 05:06:44 -0500 Message-ID: <20261107050644-failed-6.18-0e30d15b1564@kernel.org> X-Mailer: git-send-email 2.53.0 X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The patch below does not apply to the 6.18-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.18.y git checkout FETCH_HEAD git cherry-pick -x 0e30d15b15647df786e60022650613e16dd70645 # git commit -s git send-email --to '' --in-reply-to '20261107050644-failed-6.18-0e30d15b1564@kernel.org' --subject-prefix 'PATCH 6.18.y' 'HEAD^..' Thanks, Sasha ------------------ original commit in Linus's tree ------------------ >From 0e30d15b15647df786e60022650613e16dd70645 Mon Sep 17 00:00:00 2001 From: Fabio Cesari Date: Thu, 10 Sep 2026 08:24:35 +0200 Subject: [PATCH] iio: light: isl29028: fix runtime PM reference leak on error paths isl29028_read_raw() and isl29028_write_raw() take a runtime PM reference with pm_runtime_resume_and_get() but return directly on their error paths without dropping it. The usage count never balances again and the device stops entering autosuspend for good. In isl29028_read_raw() this needs a regmap access to fail; in isl29028_write_raw() one rejected sysfs write is enough, for example echo 200 > in_proximity_sampling_frequency which is outside the [1:100] range and returns -EINVAL with the reference still held. Take the reference with PM_RUNTIME_ACQUIRE_AUTOSUSPEND() instead, so it is released on every return path. This also stops the return value of pm_runtime_put_autosuspend() from reaching userspace. That value only says whether the device could be suspended right away, so -EAGAIN or -EPERM turns a successful access into a failure, and with CONFIG_PM=n the stub returns -ENOSYS on every access. Fixes: 2db5054ac28d ("staging: iio: isl29028: add runtime power management support") Suggested-by: Joshua Crofts Cc: stable@vger.kernel.org Assisted-by: LLM coccinelle Signed-off-by: Fabio Cesari Reviewed-by: Joshua Crofts Signed-off-by: Jonathan Cameron --- drivers/iio/light/isl29028.c | 33 ++++++++------------------------- 1 file changed, 8 insertions(+), 25 deletions(-) diff --git a/drivers/iio/light/isl29028.c b/drivers/iio/light/isl29028.c index 33deb1726689e..e481ac908fc13 100644 --- a/drivers/iio/light/isl29028.c +++ b/drivers/iio/light/isl29028.c @@ -342,8 +342,9 @@ static int isl29028_write_raw(struct iio_dev *indio_dev, struct device *dev = regmap_get_device(chip->regmap); int ret; - ret = pm_runtime_resume_and_get(dev); - if (ret < 0) + PM_RUNTIME_ACQUIRE_AUTOSUSPEND(dev, pm); + ret = PM_RUNTIME_ACQUIRE_ERR(&pm); + if (ret) return ret; mutex_lock(&chip->lock); @@ -392,14 +393,7 @@ static int isl29028_write_raw(struct iio_dev *indio_dev, mutex_unlock(&chip->lock); - if (ret < 0) - return ret; - - ret = pm_runtime_put_autosuspend(dev); - if (ret < 0) - return ret; - - return 0; + return ret; } static int isl29028_read_raw(struct iio_dev *indio_dev, @@ -408,10 +402,11 @@ static int isl29028_read_raw(struct iio_dev *indio_dev, { struct isl29028_chip *chip = iio_priv(indio_dev); struct device *dev = regmap_get_device(chip->regmap); - int ret, pm_ret; + int ret; - ret = pm_runtime_resume_and_get(dev); - if (ret < 0) + PM_RUNTIME_ACQUIRE_AUTOSUSPEND(dev, pm); + ret = PM_RUNTIME_ACQUIRE_ERR(&pm); + if (ret) return ret; mutex_lock(&chip->lock); @@ -461,18 +456,6 @@ static int isl29028_read_raw(struct iio_dev *indio_dev, mutex_unlock(&chip->lock); - if (ret < 0) - return ret; - - /** - * Preserve the ret variable if the call to - * pm_runtime_put_autosuspend() is successful so the reading - * (if applicable) is returned to user space. - */ - pm_ret = pm_runtime_put_autosuspend(dev); - if (pm_ret < 0) - return pm_ret; - return ret; } -- 2.53.0