From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794046115; b=AFHicpLN2fX/5ZJ9j0vvUJ3hR0Wr+ok9N+nq+ZdwQs1kBLWwQzxq6LMoXk9SAY7oSFJW IsQ8TQTbGoZXGZE6+MHloMcyi8o2wuCp8R1i62U7wwIcYYK1bV9ploNU1KAK+KR2NSjtV jSlRXm4S4r6lNiErsuYMt6iZOtA6kPOQ8GYdpsEW2ENhlfEtbt+5ZgFQptJZmoUQBbn0L FhN8YHyIKIhsRON3gBcKttAn8HCZ+d6DUZFsYSbi7YvM9KnJtIPUpWZRZzQhQnfwIIe/Z KKkiKLm+PbwoVyRXSpg1TzI5Gu01rzR4tXMKazUItI63cnRqscZYRtGaB2zEpRc6PVg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794046115; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=T0/JcFyAnyS66dPiKDd4+WztKDJidphTbdNj4Y2cOmc=; b=lcxPC+6bSAOAdfNUlCBuGqIvagCJClJtEwBSCQteQMZ9WRT0R+6CMZzAJhQdrW9OzO4V rt4PRYJDTTf31cHfAcNNOHrtEUxAbN7oQNLx5jV86MBSSpuNoWjr8SByrDqa9izL8qven Nx4vJf6CyWO6Qq6lyOgZB6eLWVDu8FgFkrgaiUzvvZzWIZKmFFFfzF9wZ+ITkCozNcQ9j 6LUP48RfHQ73PylXWd/mNF6tCIuJMSRIR4a58jm/8hC5/cImCO2T/KRdOS4XNKlhGBQhQ yw85RmpVJgaK79IQ+Kc0yfzxObZsadqRB348UplKkT0duyMlsR0sG0BDwFrWevrGxOQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=EjGov4dP; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8106F606A32E for ; Sat, 7 Nov 2026 10:08:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=EjGov4dP Received: by smtp.kernel.org (Postfix) with ESMTPSA id DCEA31F008A1; Sat, 7 Nov 2026 10:08:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794046115; bh=T0/JcFyAnyS66dPiKDd4+WztKDJidphTbdNj4Y2cOmc=; h=From:To:Cc:Subject:Date; b=EjGov4dPTtsYib0awP8ow4cuLhPEZaUmTvH3Qc0kEy+uXRIAVhprpezoezBiXqKKe HH00ylUsHMN5C17WWspZX2UAZ2Yz4RkstXHUb3MZ5/2thUE/vP6DqZ3e5J4Px65KGU rjcFUvJax7nGtN6dsqFSMJG8I3wTAhb/uy0j2qHNAp280LVIhsYJcg/hPvPoeDEiyD EZZyY8sTAN71lRPY3uHzGSCHgrv9BIbNdhFMygv2disjZsl1EoGBFODrg5pg3+a/W3 KakkhtSOTBOuJ1JyQMJw2CQZXSUV9n/afA2KxRqIPQF67S0BOfRqD0z79bj/1IrC8a LYG0YBSl40O6A== From: Sasha Levin To: mhun512@gmail.com, ae878000@gmail.com, broonie@kernel.org Cc: stable@vger.kernel.org Subject: FAILED: patch "[PATCH] ASoC: stm: stm32_i2s: request IRQ after regmap initialization" failed to apply to 6.18-stable tree Date: Sat, 7 Nov 2026 05:08:33 -0500 Message-ID: <20261107050833-failed-6.18-1b207c85551f@kernel.org> X-Mailer: git-send-email 2.53.0 X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The patch below does not apply to the 6.18-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.18.y git checkout FETCH_HEAD git cherry-pick -x 1b207c85551fd74854d632116849295b2305245f # git commit -s git send-email --to '' --in-reply-to '20261107050833-failed-6.18-1b207c85551f@kernel.org' --subject-prefix 'PATCH 6.18.y' 'HEAD^..' Thanks, Sasha ------------------ original commit in Linus's tree ------------------ >From 1b207c85551fd74854d632116849295b2305245f Mon Sep 17 00:00:00 2001 From: Myeonghun Pak Date: Sun, 4 Oct 2026 00:34:51 -0400 Subject: [PATCH] ASoC: stm: stm32_i2s: request IRQ after regmap initialization The ISR accesses the managed regmap, but probe requests the IRQ before creating it. An early interrupt can reach an uninitialized regmap. Reverse-order cleanup can free the regmap while the IRQ remains active. Request the IRQ after regmap initialization so probe unwind and removal free and synchronize it before releasing the regmap. The teardown ordering issue was found by static analysis. Fixes: e4e6ec7b127c ("ASoC: stm32: Add I2S driver") Cc: stable@vger.kernel.org Assisted-by: LLM Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak Link: https://patch.msgid.link/20261004043451.1138613-1-mhun512@gmail.com Signed-off-by: Mark Brown --- sound/soc/stm/stm32_i2s.c | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/sound/soc/stm/stm32_i2s.c b/sound/soc/stm/stm32_i2s.c index a59ad94423726..22196f789ae4a 100644 --- a/sound/soc/stm/stm32_i2s.c +++ b/sound/soc/stm/stm32_i2s.c @@ -1197,7 +1197,7 @@ static int stm32_i2s_parse_dt(struct platform_device *pdev, struct device_node *np = pdev->dev.of_node; struct reset_control *rst; struct resource *res; - int irq, ret; + int ret; if (!np) return -ENODEV; @@ -1243,16 +1243,6 @@ static int stm32_i2s_parse_dt(struct platform_device *pdev, return ret; } - /* Get irqs */ - irq = platform_get_irq(pdev, 0); - if (irq < 0) - return irq; - - ret = devm_request_irq(&pdev->dev, irq, stm32_i2s_isr, 0, - dev_name(&pdev->dev), i2s); - if (ret) - return ret; - /* Reset */ rst = devm_reset_control_get_optional_exclusive(&pdev->dev, NULL); if (IS_ERR(rst)) @@ -1277,7 +1267,7 @@ static int stm32_i2s_probe(struct platform_device *pdev) { struct stm32_i2s_data *i2s; u32 val; - int ret; + int irq, ret; i2s = devm_kzalloc(&pdev->dev, sizeof(*i2s), GFP_KERNEL); if (!i2s) @@ -1303,6 +1293,15 @@ static int stm32_i2s_probe(struct platform_device *pdev) return dev_err_probe(&pdev->dev, PTR_ERR(i2s->regmap), "Regmap init error\n"); + irq = platform_get_irq(pdev, 0); + if (irq < 0) + return irq; + + ret = devm_request_irq(&pdev->dev, irq, stm32_i2s_isr, 0, + dev_name(&pdev->dev), i2s); + if (ret) + return ret; + ret = snd_dmaengine_pcm_register(&pdev->dev, &stm32_i2s_pcm_config, 0); if (ret) return ret; -- 2.53.0