From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794046281; b=D5r32Q0/DPtcmGnFMc+u23WFZ7G1SbIj+C06u9N/xMMkDMrdQ7rNvTc5oBHqMQ4u2d+L kTvYlDzyICjnFN51+peHDNq6WWYoeIDU0qruIfjp/5r1912FAMoeg//++h7TYcpi9DwW5 nrcBZ1Ksjgqyqr5fVLy4JVaorQjiS294B9oNNUy6fWb99xBHG/dlYy37OApTg+LWttKx5 4rHsZwNi0JNP6uxRuBUnRnqFBtR1ldzSCu8rNW4a4k4uz4P2mDOCVYmV3Bgy1R7VnadHr DUs09aKvvoUStT+t0wboOo+jEynwTnNRFDq4xZLRRdpgMHEptrDN41eHNKKMnOCac4g== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794046281; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=iPnMM4L0dK2Y8BRRpQOMblmLhrNMaofkVcRfxuK0ENw=; b=MRmGx8LUeUxWf1KH/LMA9M+6Aeh6RFL4zYmD7kVX7iugTRWasNeCK7FQTcydm90gKK/o xRmmCMxoe8lxg9mjPhvvMBD/SsFGj+CzzBX4ii1D6swJiEeZFRnC3l97+4oC1I8TNTzPD ksfaiYPuUtJJOXMPTCW4YucpsQxP9a4c3l8AQzgZ87lQRwl+LKJX76EdKLXTzp7DilfmB S9kDHHtss/ZTPx6nn9hF89S6GnKBjcMFWgWdBYcvuy7ug7FGiOAQNDLDSLr2h1Sbcdwls daS5hYKP23h7tttNCp2hOfoyfhUNSuqUNOToWdWQ/AcJAq1APSoDQMKN9DcDcepUkhg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=LwkPyMNO; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44C51606A326 for ; Sat, 7 Nov 2026 10:11:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=LwkPyMNO Received: by smtp.kernel.org (Postfix) with ESMTPSA id 204441F008A3; Sat, 7 Nov 2026 10:11:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794046280; bh=iPnMM4L0dK2Y8BRRpQOMblmLhrNMaofkVcRfxuK0ENw=; h=From:To:Cc:Subject:Date; b=LwkPyMNOAyNwb8I9l6rrOEydF3QC4jhU+AaTH0pCAsx/aUkhuzZeryj57YE/+kPt3 CL7b2hhY6nUKWCDJbSNWC3DrYtjc02OaHemibEBAih3N7/6d+QS6/rwcLgyG0z7rRk gf71oQe+DuPBH74pY+EDClW3YBO7oRs6GTXIRNBQRFg+MnbbqcmhoC97eI3TMJL3C8 7VOvMDR7RbVyrh752kNB5elzwZAMOBgLImbAuLu+MLZ+Dv34QcHGPM2YtwzTdAuBeN tZqsPEYNzknCLj3VwYq6vw+weEQ/L8zKPB0VkrtZWRJEYEms4IUsdbp577VbaKx5P7 6f7xPipi0V/Ig== From: Sasha Levin To: gkobakhi@asu.edu, akpm@linux-foundation.org, xmei5@asu.edu, joseph.qi@linux.alibaba.com, mark@fasheh.com, jlbec@evilplan.org Cc: stable@vger.kernel.org Subject: FAILED: patch "[PATCH] ocfs2: fix array out of bound access in __ocfs2_find_path()" failed to apply to 6.18-stable tree Date: Sat, 7 Nov 2026 05:11:19 -0500 Message-ID: <20261107051119-failed-6.18-6193ce7896af@kernel.org> X-Mailer: git-send-email 2.53.0 X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The patch below does not apply to the 6.18-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.18.y git checkout FETCH_HEAD git cherry-pick -x 6193ce7896afb52a321a0063c8b6a45e477a84e2 # git commit -s git send-email --to '' --in-reply-to '20261107051119-failed-6.18-6193ce7896af@kernel.org' --subject-prefix 'PATCH 6.18.y' 'HEAD^..' Thanks, Sasha ------------------ original commit in Linus's tree ------------------ >From 6193ce7896afb52a321a0063c8b6a45e477a84e2 Mon Sep 17 00:00:00 2001 From: Giorgi Kobakhia Date: Tue, 22 Sep 2026 13:21:59 -0700 Subject: [PATCH] ocfs2: fix array out of bound access in __ocfs2_find_path() __ocfs2_find_path() walks down the extent tree and records path by calling find_path_ins(), which appends entry to path->p_node[]. It only has 5 spots. A corrupted ocfs2 image whose extent block is pointing to itself causes __ocfs2_find_path() descent endlessly, writing past the end of path->p_node[] array. UBSAN: array-index-out-of-bounds in fs/ocfs2/alloc.c:677:14 index 5 is out of range for type 'ocfs2_path_item [5]' Call Trace: find_path_ins (fs/ocfs2/alloc.c:677 fs/ocfs2/alloc.c:1914) __ocfs2_find_path.constprop.0 (fs/ocfs2/alloc.c:1882) ocfs2_commit_truncate (fs/ocfs2/alloc.c:1924 fs/ocfs2/alloc.c:7286) ocfs2_truncate_file (fs/ocfs2/file.c:515) ocfs2_setattr (fs/ocfs2/file.c:1224) notify_change (fs/attr.c:556) do_truncate (fs/open.c:68) do_ftruncate (fs/open.c:194 (discriminator 1)) ksys_ftruncate (fs/open.c:206) __x64_sys_ftruncate (fs/open.c:211 fs/open.c:209 fs/open.c:209) Commit a406aff8c051 ("ocfs2: validate l_tree_depth to avoid out-of-bounds access") already restricts el->l_tree_depth to be less than OCFS2_MAX_PATH_DEPTH, which is equal to 5. However, does not handle the infinite descent case. Check if the el->l_tree_depth decreases on each descent. Maximum descents are restricted to 4 and the path->p_node[] array does not overflow. Link: https://lore.kernel.org/20260922202159.2421642-1-gkobakhi@asu.edu Fixes: dcd0538ff4e8 ("ocfs2: sparse b-tree support") Signed-off-by: Giorgi Kobakhia Signed-off-by: Andrew Morton Tested-by: Xiang Mei Reviewed-by: Joseph Qi Assisted-by: LLM Cc: Mark Fasheh Cc: Joel Becker Cc: --- fs/ocfs2/alloc.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/fs/ocfs2/alloc.c b/fs/ocfs2/alloc.c index 2fdc5403b10b0..fc949e5946269 100644 --- a/fs/ocfs2/alloc.c +++ b/fs/ocfs2/alloc.c @@ -1844,6 +1844,7 @@ static int __ocfs2_find_path(struct ocfs2_caching_info *ci, int i, ret = 0; u32 range; u64 blkno; + u32 prev_depth = OCFS2_MAX_PATH_DEPTH; struct buffer_head *bh = NULL; struct ocfs2_extent_block *eb; struct ocfs2_extent_list *el; @@ -1851,14 +1852,16 @@ static int __ocfs2_find_path(struct ocfs2_caching_info *ci, el = root_el; while (el->l_tree_depth) { - if (unlikely(le16_to_cpu(el->l_tree_depth) >= OCFS2_MAX_PATH_DEPTH)) { + if (unlikely(le16_to_cpu(el->l_tree_depth) >= prev_depth)) { ocfs2_error(ocfs2_metadata_cache_get_super(ci), - "Owner %llu has invalid tree depth %u in extent list\n", + "Owner %llu has invalid tree depth %u in extent list (max %u)\n", (unsigned long long)ocfs2_metadata_cache_owner(ci), - le16_to_cpu(el->l_tree_depth)); + le16_to_cpu(el->l_tree_depth), prev_depth - 1); ret = -EROFS; goto out; } + prev_depth = le16_to_cpu(el->l_tree_depth); + if (!el->l_next_free_rec || !el->l_count) { ocfs2_error(ocfs2_metadata_cache_get_super(ci), "Owner %llu has empty extent list at depth %u\n" -- 2.53.0