From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794046509; b=c3FFI7HY/NR/gGkKzyOLim/LdKZVwFshKv2A3f9/9SJwy9kjzCjhHsEdnswVD2NPp1s/ +qsYqPXJB5KH+f2JkDJY6HENk/nEZare+qEcmrMgZXVoRVPGt0CT2U2eP7PMXZ5gnSbtg r9+OEVbK8dHh2SMjxojOpZDC6bfcU+jIpEanfEXjl6PK5zhsR9potNVQkqqpk/GyFQTey hvgAtpqW42U0UWkbmgOB+n8sOeEwSQ78WnwZye7U/hYueyzN4UOr5FTYabQIvgMp5dz69 ACJSKy7YjqNw8EEdRdr24qXmjm+YQ9tug93tg53y9B/F9yXfeCwK5C+ShjxY5BaoAlA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794046509; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=0dOByf+SjD7IEn/P1IG/LE31nlHbNC7RZwNrBYheH8M=; b=hzlDXOyn08baL44yBb/z5f7uA4aV/9Xy8wIk1pyl38KJ0LkX2nmRZJw7YIVJRnPLcnw/ Hy22+gdQmdqDHabS6j2p1lpqOrfr2hd/VVgRHnb7ftQpca1Okbvqny61XsExXDWoz5iV7 851n+rC+MftKhn9OI1iG1S5cSbff1GsQf6GB1IzyNseAEQVJeoMwiqnUD2TCoD+gqUDS9 cuM+OQyhj/PdeloKD+c5MJmKFkKUM3hb2UbWPKz5F8R+QlQN6FKnzoV3c+hoQHFWrrjue ozfkNsSIICJgn1uKQFGowlfx6kpEMo+2fsppcsKywQy9afnrwYCdxBfVZTIYtbB8HhQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=JS91k4KP; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 449E3606A326 for ; Sat, 7 Nov 2026 10:15:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=JS91k4KP Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0018C1F0089F; Sat, 7 Nov 2026 10:15:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794046508; bh=0dOByf+SjD7IEn/P1IG/LE31nlHbNC7RZwNrBYheH8M=; h=From:To:Cc:Subject:Date; b=JS91k4KP3ENPDw1ckHa0aoPY8sgvkXW+lIrp53DXoRtNeMhBcXxTiFxr0MIYc/UgN nEgs9OTwBVMRI/WbM1OSMK9q5PXRpc2NIg1jw0cHbO+aggu+R/wEpnNGoqpbvrOvQ/ Qb3qQ3UYcpE66CYkG/++VHhoSgrP5QqBzkxPll+SYaf0KoMyquMPFUGs+PG0zcZoXO 9Vj26BOgDoQ4c7HFXAwC9HNVb//YwUc2fs1UlY1A4SbnsmBvyjIcRZUkJ9406R6W4F fQsZ+RMRHw0Y+H72eyJdNEiMDaT1WvOPv5cRivH0QFsC+qrEtIGnNIrMPHq29V1Nps 9ry6WxDyUe3UA== From: Sasha Levin To: zhilinz@nebusec.ai, vega@nebusec.ai, idosch@nvidia.com, namangulati@google.com, kuba@kernel.org Cc: stable@vger.kernel.org Subject: FAILED: patch "[PATCH] ipmr: drop packets with unknown ingress VIF" failed to apply to 6.18-stable tree Date: Sat, 7 Nov 2026 05:15:06 -0500 Message-ID: <20261107051506-failed-6.18-09280680f2ea@kernel.org> X-Mailer: git-send-email 2.53.0 X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The patch below does not apply to the 6.18-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.18.y git checkout FETCH_HEAD git cherry-pick -x 09280680f2ea060514be2a39ea84209fb6d721d4 # git commit -s git send-email --to '' --in-reply-to '20261107051506-failed-6.18-09280680f2ea@kernel.org' --subject-prefix 'PATCH 6.18.y' 'HEAD^..' Thanks, Sasha ------------------ original commit in Linus's tree ------------------ >From 09280680f2ea060514be2a39ea84209fb6d721d4 Mon Sep 17 00:00:00 2001 From: Zhiling Zou Date: Thu, 22 Oct 2026 03:01:16 +0800 Subject: [PATCH] ipmr: drop packets with unknown ingress VIF A packet can race with VIF publication and make ipmr_find_vif() return -1 even though the VIF device pointer is already visible. The parent VIF device check can then pass with an invalid ingress VIF. For (*,G) entries, this can also let the packet be forwarded back out its ingress VIF. Drop packets whose ingress VIF lookup fails in both IPv4 and IPv6 forwarding, before checking the MFC parent device. This prevents forwarding with an unknown ingress VIF and avoids the (*,G) hairpin. Without the early check, the negative index can reach the IPv4 offload lookup only for an skb marked for L3 forwarding offload, currently done by mlxsw. The race is rare; the supplied PoC reports only the UBSAN negative-index diagnostic. Fixes: 4eadb88244d1 ("ipmr: do not acquire mrt_lock while calling ip_mr_forward()") Fixes: 9b1c21d898fd ("ip6mr: do not acquire mrt_lock while calling ip6_mr_forward()") Cc: stable@vger.kernel.org Reported-by: Vega Link: https://lore.kernel.org/netdev/b966eb102e98f299e45be59ada033a8766e4c6df.1791899747.git.zhilinz@nebusec.ai/ Suggested-by: Ido Schimmel Suggested-by: Naman Gulati Signed-off-by: Zhiling Zou Reviewed-by: Naman Gulati Reviewed-by: Ido Schimmel Link: https://patch.msgid.link/5271fcb94a4d9e697ed64a348e92ea9e74faab1c.1792608753.git.zhilinz@nebusec.ai Signed-off-by: Jakub Kicinski --- net/ipv4/ipmr.c | 3 ++- net/ipv6/ip6mr.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/net/ipv4/ipmr.c b/net/ipv4/ipmr.c index 915b210c4512b..e8f7d3b573d0f 100644 --- a/net/ipv4/ipmr.c +++ b/net/ipv4/ipmr.c @@ -2089,7 +2089,8 @@ static void ip_mr_forward(struct net *net, struct mr_table *mrt, } /* Wrong interface: drop packet and (maybe) send PIM assert. */ - if (rcu_access_pointer(mrt->vif_table[vif].dev) != dev) { + if (true_vifi < 0 || + rcu_access_pointer(mrt->vif_table[vif].dev) != dev) { if (rt_is_output_route(skb_rtable(skb))) { /* It is our own packet, looped back. * Very complicated situation... diff --git a/net/ipv6/ip6mr.c b/net/ipv6/ip6mr.c index a628acf50b0d8..af968a2c2a784 100644 --- a/net/ipv6/ip6mr.c +++ b/net/ipv6/ip6mr.c @@ -2225,7 +2225,8 @@ static void ip6_mr_forward(struct net *net, struct mr_table *mrt, /* * Wrong interface: drop packet and (maybe) send PIM assert. */ - if (rcu_access_pointer(mrt->vif_table[vif].dev) != dev) { + if (true_vifi < 0 || + rcu_access_pointer(mrt->vif_table[vif].dev) != dev) { atomic_long_inc(&c->_c.mfc_un.res.wrong_if); if (true_vifi >= 0 && READ_ONCE(mrt->mroute_do_assert) && -- 2.53.0