From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794047344; b=BCjFJhUbBtHrxx6BekJmUpDin6K/otA7ZmdIl62/HhrsiLIZZBcXz3qCHl4sL6q9H7CY aZvdSfviSd89cHgAdPn1uixXjlhRQ++mv8C/MPm7qD2gOgitca/TK9Qj+ZiDKcJWQTyIC H8A1fgxLU+gvcOvFHmegnHQwyj971xilfbif11OiCGXFW7zWID0R5xuoE0jzrdIPt3Dkz P05d91y0GmK5YTbGo6aCfkwYIkMw7tgOemG+c5iI7s8eozk0Y5TIIX7N/52deiwiMl9AJ YXKv5GSYgSY5y9PdJWTxjUxNtd0E+dqcBJHsXvmym1zBos7Cys6qKWJ+0VvQa8bugLA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794047344; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=EeJsSWJspSzzVgbhx1CWsM0nperwDaEU5uLvD9pOKkc=; b=WCJ87EQofmXYiCAbOXrATF/T9kH/KeQbgwYJYWAk+EBzrhSUSz5FI1vnJcJ819qgIRMg 9bS6xedvicJAcIuVSV764XHWuuAfoIUaZXQLw4fyGfXD7V72i28nxT1NVejDQMn216vr4 l1diB/Mk8dlnsA1MQNAMOMAtaDKL7MQOEl4AUVl8ceaFZgHiWaE0z62W/5BA1+CsmZ96U KQU7XkyWGwByzzRTYSb0JXn5qOl5pK2PwVHXAUF96FxqaI70U1ryZaz+W8wg/JuJHDcLB K2XZR1NGxv+NipmOvrT1ZURo9YkdcDXEQZokgH9eGRpFoDbsHF6cfSiIn0qUP6QJsHw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=CIg3jRIy; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1EFA8606D803 for ; Sat, 7 Nov 2026 10:29:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=CIg3jRIy Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92E001F0089F; Sat, 7 Nov 2026 10:29:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794047344; bh=EeJsSWJspSzzVgbhx1CWsM0nperwDaEU5uLvD9pOKkc=; h=From:To:Cc:Subject:Date; b=CIg3jRIyl4Ib8W+1TcgLlwxca0eirGH47SETK63IO0ON7ZHrWO35S37MiVzLzobDN F3oSiMYpPGYChl1a3zNyH7ZqBEzDoFXtBfEKQPuVmuT8JjJFWIpqqSHmhuJ/j+hPEu cPtu7KhOfjed2c+v49vZfs2/46Hl3w4F0b1Kt9aKUUyW1GPAq/x9SWZwl5pzP9+fIK Sd173lL1eaa1Ig+JNF1XYPiWQo7ESIJhMr/m6C+orhYU5lW21J2CSN+SQmD5HI+j21 z1Ts1yuIMRsrY8PAi9UP1ksNd8wRYkeyGweEELUHIGCNPzNr8FWaeM72GLZiTlD75d sJjx1RBxIFl8g== From: Sasha Levin To: r772577952@gmail.com, agruenba@redhat.com Cc: stable@vger.kernel.org Subject: FAILED: patch "[PATCH] gfs2: reject invalid inode sizes" failed to apply to 6.6-stable tree Date: Sat, 7 Nov 2026 05:29:02 -0500 Message-ID: <20261107052902-failed-6.6-33ed0a0567e0@kernel.org> X-Mailer: git-send-email 2.53.0 X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The patch below does not apply to the 6.6-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.6.y git checkout FETCH_HEAD git cherry-pick -x 33ed0a0567e0abe66ea65e89dad2e35082890fbe # git commit -s git send-email --to '' --in-reply-to '20261107052902-failed-6.6-33ed0a0567e0@kernel.org' --subject-prefix 'PATCH 6.6.y' 'HEAD^..' Thanks, Sasha ------------------ original commit in Linus's tree ------------------ >From 33ed0a0567e0abe66ea65e89dad2e35082890fbe Mon Sep 17 00:00:00 2001 From: Jiaming Zhang Date: Mon, 31 Aug 2026 18:54:25 +0800 Subject: [PATCH] gfs2: reject invalid inode sizes A corrupted GFS2 image can store a dinode size that is larger than what VFS i_size can represent. gfs2_dinode_in() reads the on-disk di_size as a u64 and writes it directly into inode->i_size. If the value is larger than S64_MAX, the incore i_size becomes negative. That negative value can bypass the existing stuffed inode size check: inode->i_size > gfs2_max_stuffed_size(ip) Later, gfs2_quotad may try to sync the quota file and unstuff the quota inode. gfs2_unstuffer_folio() reads the negative i_size into an unsigned length and passes it to memcpy(), turning it into a huge copy size and triggering a out-of-bound issue. Reject dinodes whose size exceeds sb->s_maxbytes before storing the value in inode->i_size. Also make the stuffed inode check use the raw on-disk size while it is still unsigned. Fixes: 70376c7ff312 ("gfs2: Always check inode size of inline inodes") Closes: https://lore.kernel.org/lkml/CANypQFaF6bvORKKbRALvEL0k_epFaneFiOQqco4gjdmKVbdURg@mail.gmail.com/ Assisted-by: Codex:gpt-5.5-xhigh Cc: stable@vger.kernel.org Signed-off-by: Jiaming Zhang Signed-off-by: Andreas Gruenbacher --- fs/gfs2/glops.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/fs/gfs2/glops.c b/fs/gfs2/glops.c index 662d033fd2caf..2597e1cf2315c 100644 --- a/fs/gfs2/glops.c +++ b/fs/gfs2/glops.c @@ -393,6 +393,7 @@ static int gfs2_dinode_in(struct gfs2_inode *ip, const void *buf) umode_t mode = be32_to_cpu(str->di_mode); struct inode *inode = &ip->i_inode; bool is_new = inode_state_read_once(inode) & I_NEW; + u64 size; if (unlikely(ip->i_no_addr != be64_to_cpu(str->di_num.no_addr))) { gfs2_consist_inode(ip); @@ -418,7 +419,12 @@ static int gfs2_dinode_in(struct gfs2_inode *ip, const void *buf) i_uid_write(inode, be32_to_cpu(str->di_uid)); i_gid_write(inode, be32_to_cpu(str->di_gid)); set_nlink(inode, be32_to_cpu(str->di_nlink)); - i_size_write(inode, be64_to_cpu(str->di_size)); + size = be64_to_cpu(str->di_size); + if (unlikely(size > inode->i_sb->s_maxbytes)) { + gfs2_consist_inode(ip); + return -EIO; + } + i_size_write(inode, size); gfs2_set_inode_blocks(inode, be64_to_cpu(str->di_blocks)); atime.tv_sec = be64_to_cpu(str->di_atime); atime.tv_nsec = be32_to_cpu(str->di_atime_nsec); @@ -462,7 +468,7 @@ static int gfs2_dinode_in(struct gfs2_inode *ip, const void *buf) return -EIO; } - if (gfs2_is_stuffed(ip) && inode->i_size > gfs2_max_stuffed_size(ip)) { + if (gfs2_is_stuffed(ip) && size > gfs2_max_stuffed_size(ip)) { gfs2_consist_inode(ip); return -EIO; } -- 2.53.0