From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794047353; b=1XK7GHiZ5nhiPZ+Le9/8jybyla+5JVNnPjkATYZHJz+5Q6G5dr9ndMFDiu2PTz5+Yy1H MXDhhcTCgq0H6JtJ3yZYo5okx1pA65Pm/WJZ1vgUlXsbckvoUkGY2rPg+yRSFujo3fTjQ nYk2wQHmS88z0UBJaq462Nj2QundH/tEkb3Es62i9ij9ZBK6xgio0gw6ya2uyI33m17B0 vQWKRsotTS7TxQKndKYxNmyDM0ltgXoj8OqOT4CAuZ7APO1ai+I2Nvzx/qDzYQEPpfjSS h5vlVu0veiP2IjqGgq3eJDUciES/AolzcTx8cKmldimN0ShMl89IwsSqmk66IR5VlmA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794047353; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=1f2ByyLht4FWKY/HgaCMuUsk784DXESuv2KxRV0Drf0=; b=kvQUDa1wRzFUO2DlEoUkhQBi1dgwWWYYUqVkoMxEE7cskWFSWWvy4rvA5hcgxZXot9wd fmfqeCXWJOkkdpTvMq5siIa6o5IG0zUDBJC/e86ZD/kHqiCcnjQspg2jWKNE2e7c4GuBx sEsnWNQeAQX4HJWZNDRIyFfn3RmVP6uQri/GTn82Uh48lqSJ4n6xcTGP42N5LbC+uEfYH sGknm7EJryf9hFsDZVzIem/GtSifK381+kBTTInJuKcjMCyZjtg9xhyG6TLzhUNtLwF3U O55Lrj3nDAdnc5KtTxGAGJpOnIuVEYgnX/N/JdYeRRfMyJljtFd+2bKw9Uxo1nwQyFA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=hqbnH3d3; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB656606A332 for ; Sat, 7 Nov 2026 10:29:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=hqbnH3d3 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 205021F0089F; Sat, 7 Nov 2026 10:29:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794047352; bh=1f2ByyLht4FWKY/HgaCMuUsk784DXESuv2KxRV0Drf0=; h=From:To:Cc:Subject:Date; b=hqbnH3d3AbTmkjCzx9YsNqYAWm4XZIXQSHcFv4k+qLjT1WOvLS6a/t1QfQcQIlMEm QpKhZ01rRmhoHeyDYgMtdAr2UKnaMIwdr7jLsC87AtUbkwfsH6gO7kiakQisPQXBV8 VJ7LdLuSPFYKp3Z84/moe7LI7sWyYoWW1TEz1t9qtiBoB5/tm3EiIA1e5NigCYcaCo EiIfV33MCHfm65w4SmUIHfxUHyL1U4SzoETp3sQBCN4jfcm5WkskjNnjJoGf/qqZVa dgNYK4RllGyoZQbGJ3evuHNGaXxMwnQ64WL/X5Ud1U73FlRoW6OVt/0avOLB9rRI/j UVYAZMSAdTb9g== From: Sasha Levin To: fabio.cesari@gmail.com, joshua.crofts1@gmail.com, jonathan.cameron@oss.qualcomm.com Cc: stable@vger.kernel.org Subject: FAILED: patch "[PATCH] iio: light: isl29028: fix runtime PM reference leak on error paths" failed to apply to 6.6-stable tree Date: Sat, 7 Nov 2026 05:29:10 -0500 Message-ID: <20261107052910-failed-6.6-0e30d15b1564@kernel.org> X-Mailer: git-send-email 2.53.0 X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The patch below does not apply to the 6.6-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.6.y git checkout FETCH_HEAD git cherry-pick -x 0e30d15b15647df786e60022650613e16dd70645 # git commit -s git send-email --to '' --in-reply-to '20261107052910-failed-6.6-0e30d15b1564@kernel.org' --subject-prefix 'PATCH 6.6.y' 'HEAD^..' Thanks, Sasha ------------------ original commit in Linus's tree ------------------ >From 0e30d15b15647df786e60022650613e16dd70645 Mon Sep 17 00:00:00 2001 From: Fabio Cesari Date: Thu, 10 Sep 2026 08:24:35 +0200 Subject: [PATCH] iio: light: isl29028: fix runtime PM reference leak on error paths isl29028_read_raw() and isl29028_write_raw() take a runtime PM reference with pm_runtime_resume_and_get() but return directly on their error paths without dropping it. The usage count never balances again and the device stops entering autosuspend for good. In isl29028_read_raw() this needs a regmap access to fail; in isl29028_write_raw() one rejected sysfs write is enough, for example echo 200 > in_proximity_sampling_frequency which is outside the [1:100] range and returns -EINVAL with the reference still held. Take the reference with PM_RUNTIME_ACQUIRE_AUTOSUSPEND() instead, so it is released on every return path. This also stops the return value of pm_runtime_put_autosuspend() from reaching userspace. That value only says whether the device could be suspended right away, so -EAGAIN or -EPERM turns a successful access into a failure, and with CONFIG_PM=n the stub returns -ENOSYS on every access. Fixes: 2db5054ac28d ("staging: iio: isl29028: add runtime power management support") Suggested-by: Joshua Crofts Cc: stable@vger.kernel.org Assisted-by: LLM coccinelle Signed-off-by: Fabio Cesari Reviewed-by: Joshua Crofts Signed-off-by: Jonathan Cameron --- drivers/iio/light/isl29028.c | 33 ++++++++------------------------- 1 file changed, 8 insertions(+), 25 deletions(-) diff --git a/drivers/iio/light/isl29028.c b/drivers/iio/light/isl29028.c index 33deb1726689e..e481ac908fc13 100644 --- a/drivers/iio/light/isl29028.c +++ b/drivers/iio/light/isl29028.c @@ -342,8 +342,9 @@ static int isl29028_write_raw(struct iio_dev *indio_dev, struct device *dev = regmap_get_device(chip->regmap); int ret; - ret = pm_runtime_resume_and_get(dev); - if (ret < 0) + PM_RUNTIME_ACQUIRE_AUTOSUSPEND(dev, pm); + ret = PM_RUNTIME_ACQUIRE_ERR(&pm); + if (ret) return ret; mutex_lock(&chip->lock); @@ -392,14 +393,7 @@ static int isl29028_write_raw(struct iio_dev *indio_dev, mutex_unlock(&chip->lock); - if (ret < 0) - return ret; - - ret = pm_runtime_put_autosuspend(dev); - if (ret < 0) - return ret; - - return 0; + return ret; } static int isl29028_read_raw(struct iio_dev *indio_dev, @@ -408,10 +402,11 @@ static int isl29028_read_raw(struct iio_dev *indio_dev, { struct isl29028_chip *chip = iio_priv(indio_dev); struct device *dev = regmap_get_device(chip->regmap); - int ret, pm_ret; + int ret; - ret = pm_runtime_resume_and_get(dev); - if (ret < 0) + PM_RUNTIME_ACQUIRE_AUTOSUSPEND(dev, pm); + ret = PM_RUNTIME_ACQUIRE_ERR(&pm); + if (ret) return ret; mutex_lock(&chip->lock); @@ -461,18 +456,6 @@ static int isl29028_read_raw(struct iio_dev *indio_dev, mutex_unlock(&chip->lock); - if (ret < 0) - return ret; - - /** - * Preserve the ret variable if the call to - * pm_runtime_put_autosuspend() is successful so the reading - * (if applicable) is returned to user space. - */ - pm_ret = pm_runtime_put_autosuspend(dev); - if (pm_ret < 0) - return pm_ret; - return ret; } -- 2.53.0