From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794047570; b=XkSq0hsQAlmFh2p3FZEGPTMI/rNNh/y8OstW5cwRLMqWB9NZrrKtWbJ0l1SZJqrf2mF0 ief96iKTbUXgImoCn7cfDwgwTaQeQUZ/sFooJckc5KbKWl6jmV65YPmd99rmXQIUhPbIE Zylf1mgvaOInSN+W207LX2QaoAK+4GBB70g3+ELaeAKgHageOB3786/jyLplRlX2OCuho JUMNCbyLLOZU0hQqc1vC0qBaShByxxprIorhnpiD4EA5dBgz+ynmKD2AtO29ML1Sg16JU 8P9qmTauzhEhqExKqAMtAWC2QlCe7VxuOlEThaX/12AnXFIK9Vpaxq1vcu1qngKJbUw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794047570; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=3+7dok/trc6Ik2kS+u6hgVKnLgQkg2lyMtxa8L2+gXk=; b=PKy/OlvdYTBqkTDPGTiddUZ7l5G7ItCSd5OzQa+zQw1cWebLrevaw3Awe8sqofr6LxeE DcnG0vWj2thXI5Ulrd9CUJqnhn7wECU8qUz+C1PPMk1ZXSKy8RCg7aQ8qoEv/ozP7CA0I 6GXjWdDkeLxSksYUREwUMey7qWTeWa9CY1kesRSxb3v4FSBxHWQu3iTCeaDrrBSa01//4 SlcRLjHYCzkxKBlGztrGcHlLesO2hfFrl32VP5kVjt1EjiU8Y5dKZzKsCbJFRQy70ceDg TGv3fArNYgajO6OVmUrlethew/gt2WE76rASgnqf1f85uUcqHDb+8FQd4Nfxi4105Ug== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=WCxkKfji; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81D1E606A330 for ; Sat, 7 Nov 2026 10:32:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=WCxkKfji Received: by smtp.kernel.org (Postfix) with ESMTPSA id BED621F0089F; Sat, 7 Nov 2026 10:32:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794047570; bh=3+7dok/trc6Ik2kS+u6hgVKnLgQkg2lyMtxa8L2+gXk=; h=From:To:Cc:Subject:Date; b=WCxkKfjitQgYEFh198tdBMr569KaJ01uNi7VkPEoYeuSx2RB5Ofij+6VyPKyrhBfR WoF35CYOlyTOqWEUdjVW9U9SKjKp5SvU0aVqkURBOgWGUNTN3RK5t/EAe7uWgWkRbD RXPkvavyUTaVUjFZXvK4okoryFNUG8kyEsX+XLXofuyT+Pb4A45wcAxYWV/8lxfcnI IfTmdSgnRFHb4v9PyUJ8S2suV4sfp3xtW6Rkfx+LV71eY1Z+ZFMgCffEUwRmZlKTrK lzSO0dxLxdrkPpGLnyV2rCBVPFdxnZe9tEvVN9w7qe7Kflfs4deqkeAi5EiDlRLCBu e9weS/kOSV0AQ== From: Sasha Levin To: bartosz.golaszewski@oss.qualcomm.com, sashiko-bot@kernel.org, mani@kernel.org, vkoul@kernel.org Cc: stable@vger.kernel.org Subject: FAILED: patch "[PATCH] dmaengine: qcom: bam_dma: free interrupt before the clock in error path" failed to apply to 6.6-stable tree Date: Sat, 7 Nov 2026 05:32:48 -0500 Message-ID: <20261107053248-failed-6.6-82eed160cfa7@kernel.org> X-Mailer: git-send-email 2.53.0 X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The patch below does not apply to the 6.6-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.6.y git checkout FETCH_HEAD git cherry-pick -x 82eed160cfa7a296ae4eb5acb8dd8f493323eea7 # git commit -s git send-email --to '' --in-reply-to '20261107053248-failed-6.6-82eed160cfa7@kernel.org' --subject-prefix 'PATCH 6.6.y' 'HEAD^..' Thanks, Sasha ------------------ original commit in Linus's tree ------------------ >From 82eed160cfa7a296ae4eb5acb8dd8f493323eea7 Mon Sep 17 00:00:00 2001 From: Bartosz Golaszewski Date: Thu, 8 Oct 2026 11:54:35 +0200 Subject: [PATCH] dmaengine: qcom: bam_dma: free interrupt before the clock in error path The BAM interrupt is requested with a devres helper and so on error it's freed after probe() returns. We disable the clock before freeing or masking it so it may still fire and we may end up reading BAM registers with clock disabled. Stop using devres for interrupts as we free it in remove() manually anyway. Add an appropriate label and free the interrupt before disabling the clock in error path and in remove(). Cc: stable@vger.kernel.org Fixes: e7c0fe2a5c84 ("dmaengine: add Qualcomm BAM dma driver") Reported-by: Sashiko Closes: https://sashiko.dev/#/patchset/20260427-qcom-qce-cmd-descr-v16-0-945fd1cafbbc%40oss.qualcomm.com?part=2 Reviewed-by: Manivannan Sadhasivam Signed-off-by: Bartosz Golaszewski Link: https://patch.msgid.link/20261008-bam-dma-free-irq-v28-1-5e5b10de441e@oss.qualcomm.com Signed-off-by: Vinod Koul --- drivers/dma/qcom/bam_dma.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/dma/qcom/bam_dma.c b/drivers/dma/qcom/bam_dma.c index 94cb957d4b187..f67a93a37d48c 100644 --- a/drivers/dma/qcom/bam_dma.c +++ b/drivers/dma/qcom/bam_dma.c @@ -1332,8 +1332,8 @@ static int bam_dma_probe(struct platform_device *pdev) for (i = 0; i < bdev->num_channels; i++) bam_channel_init(bdev, &bdev->channels[i], i); - ret = devm_request_irq(bdev->dev, bdev->irq, bam_dma_irq, - IRQF_TRIGGER_NONE, "bam_dma", bdev); + ret = request_irq(bdev->irq, bam_dma_irq, IRQF_TRIGGER_NONE, + "bam_dma", bdev); if (ret) goto err_bam_channel_exit; @@ -1366,7 +1366,7 @@ static int bam_dma_probe(struct platform_device *pdev) ret = dma_async_device_register(&bdev->common); if (ret) { dev_err(bdev->dev, "failed to register dma async device\n"); - goto err_bam_channel_exit; + goto err_free_irq; } ret = of_dma_controller_register(pdev->dev.of_node, bam_dma_xlate, @@ -1385,6 +1385,8 @@ static int bam_dma_probe(struct platform_device *pdev) err_unregister_dma: dma_async_device_unregister(&bdev->common); +err_free_irq: + free_irq(bdev->irq, bdev); err_bam_channel_exit: for (i = 0; i < bdev->num_channels; i++) tasklet_kill(&bdev->channels[i].vc.task); @@ -1410,7 +1412,7 @@ static void bam_dma_remove(struct platform_device *pdev) /* mask all interrupts for this execution environment */ writel_relaxed(0, bam_addr(bdev, 0, BAM_IRQ_SRCS_MSK_EE)); - devm_free_irq(bdev->dev, bdev->irq, bdev); + free_irq(bdev->irq, bdev); for (i = 0; i < bdev->num_channels; i++) { bam_dma_terminate_all(&bdev->channels[i].vc.chan); -- 2.53.0