From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794047691; b=Cy1omJRAyA3PvtGZRkZI3bh+pDWb9pu/DCbuWEJ9swMBPkR03idTcl5jtirvA7EedOq6 KrV4vI/MLX4EnGrl8autmB6itH0R9iZBim8m1s7krcgbbm63w2gndLGAH1FfpC8YUSVqz uSBPV2UYDQwMdg6W0ys+lGfpAcME4BecvHvZuXtVA3rEj2ptKCA1EtMYe5K1jtdAaST2l 9y6+ksKETvWRhbHEauRvzFmiMCnRM3zQp9smSsEOS/RuNdmk8gq7wbsymUfCfOgFzEHgl OuKtSsIuvE4EHYiQV6TkAwkSAHuNzNn/V0wcO1VmsWI+T2MsEvXO5kWg+7WdMsrkfKg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794047691; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=iVLNoZHGangElQnngP4aHG+UznvsaNpWmhO8ZXxRYlc=; b=oLjP4BRk7DpWOuukLgrWUXuu5KgYMHu6ka+MCdR+9nJ7Epkv+UN9PO3jr3YWyZkxd28B ZdqIwNAJHabFuINOV8ZDSeOMWqelptHY8IpYisujFK47PGQ8P8sEinRUQlDVZr9XwObRu 0B309A/1P/rXH3yMBk+V3stjmG1MkyvylylSIglmU7x1zk/wCN0DaE3rwiqyQx9DcDQ8Q ZAKapPKpNsH51SZtiHsUOxvHBHLINhMgBqvfpKap5f263XUF3PR172lDfxJsNu6D6EXtv C7M7niXF9XHj4RUnGSsvG4EGEOVkng7uAfJHgz0erwnH8TT+wihG0ec36GThqB4LGnw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=eO2XMD2L; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E8A6606A32C for ; Sat, 7 Nov 2026 10:34:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=eO2XMD2L Received: by smtp.kernel.org (Postfix) with ESMTPSA id 743E51F0089F; Sat, 7 Nov 2026 10:34:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794047691; bh=iVLNoZHGangElQnngP4aHG+UznvsaNpWmhO8ZXxRYlc=; h=From:To:Cc:Subject:Date; b=eO2XMD2L2Gf4w+R70Le1DdN11fPzNEsRm/Geys8Ao+wjW5Q+EsJ2WZk69HjJ2AN6z bobqmKcrg2rahlgRkrftMSmVvRQja+H/ac6FKXlK309DyWieFlSbWK1fw2PTtffBex wtIxAqQZKj/rUrIom+7+Mv98yjLk+uUWLKfhbXA7YaYo3ctWycPxCFiswvvULVtzKk MvGslBOZxP1V15cawbLw94AdxPkqDwgTpF13GjVCdL4YwWnPp2+Lw553Ehdfy4A796 Th/d3apJWP4l8lgknu+GN3rntnxqnVvVwBP6D+w5pFrl/PkwqXiZUORV2dKURN1zzQ mYW4mLill1yjg== From: Sasha Levin To: zhanxusheng1024@gmail.com, zhanxusheng@xiaomi.com, chao@kernel.org, jaegeuk@kernel.org Cc: stable@vger.kernel.org Subject: FAILED: patch "[PATCH] f2fs: fix defragment writeback range truncation on 32-bit" failed to apply to 6.6-stable tree Date: Sat, 7 Nov 2026 05:34:49 -0500 Message-ID: <20261107053449-failed-6.6-92154fe28c37@kernel.org> X-Mailer: git-send-email 2.53.0 X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The patch below does not apply to the 6.6-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.6.y git checkout FETCH_HEAD git cherry-pick -x 92154fe28c3701bebf75176dc5522bec62519a8f # git commit -s git send-email --to '' --in-reply-to '20261107053449-failed-6.6-92154fe28c37@kernel.org' --subject-prefix 'PATCH 6.6.y' 'HEAD^..' Thanks, Sasha ------------------ original commit in Linus's tree ------------------ >From 92154fe28c3701bebf75176dc5522bec62519a8f Mon Sep 17 00:00:00 2001 From: Zhan Xusheng Date: Mon, 5 Oct 2026 23:49:54 +0800 Subject: [PATCH] f2fs: fix defragment writeback range truncation on 32-bit f2fs_defragment_range() flushes the range it is about to defragment: filemap_write_and_wait_range(inode->i_mapping, pg_start << PAGE_SHIFT, (pg_end << PAGE_SHIFT) - 1); pg_start and pg_end are pgoff_t, 32 bits on 32-bit kernels, so both shifts are evaluated in 32 bits and truncated before they are widened to the loff_t parameters. pg_end is only capped by the file's page count, so for a file larger than 4 GiB the shift wraps. For a 5 GiB file pg_end is 1310720 and the range collapses from [0, 5 GiB) to [0, 1 GiB), leaving the rest of the dirty pages unwritten before the blocks are moved. For 8 GiB the shift yields 0, the minus one makes it (loff_t)-1, and the range becomes [0, LLONG_MAX]. The matching call in f2fs_collapse_range() already casts: filemap_write_and_wait_range(inode->i_mapping, (loff_t)index << PAGE_SHIFT, ((loff_t)pg_end << PAGE_SHIFT) - 1); Do the same here. On i386 the shift changes from "shl $0xc,%ecx" to "shld", i.e. from a 32-bit shift to a double-precision one. Cc: stable@kernel.org Fixes: d323d005ac4a ("f2fs: support file defragment") Signed-off-by: Zhan Xusheng Reviewed-by: Chao Yu Signed-off-by: Jaegeuk Kim --- fs/f2fs/file.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 713fb6f49bcb3..d4d859dbef880 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -3036,8 +3036,8 @@ static int f2fs_defragment_range(struct f2fs_sb_info *sbi, /* writeback all dirty pages in the range */ err = filemap_write_and_wait_range(inode->i_mapping, - pg_start << PAGE_SHIFT, - (pg_end << PAGE_SHIFT) - 1); + (loff_t)pg_start << PAGE_SHIFT, + ((loff_t)pg_end << PAGE_SHIFT) - 1); if (err) goto out; -- 2.53.0